From m.seaman@infracaninophile.co.uk  Mon Jul 14 14:27:26 2003
Return-Path: <m.seaman@infracaninophile.co.uk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0E02337B487
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jul 2003 14:27:26 -0700 (PDT)
Received: from smtp.infracaninophile.co.uk (ns0.infracaninophile.co.uk [81.2.69.218])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A874C43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jul 2003 14:27:22 -0700 (PDT)
	(envelope-from m.seaman@infracaninophile.co.uk)
Received: from happy-idiot-talk.infracaninophile.co.uk (localhost [127.0.0.1])
	by smtp.infracaninophile.co.uk (8.12.9/8.12.9) with ESMTP id h6ELPvAI054798
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jul 2003 22:27:18 +0100 (BST)
	(envelope-from matthew@happy-idiot-talk.infracaninophile.co.uk)
Received: (from matthew@localhost)
	by happy-idiot-talk.infracaninophile.co.uk (8.12.9/8.12.9/Submit) id h6ELPvad054797;
	Mon, 14 Jul 2003 22:25:57 +0100 (BST)
	(envelope-from matthew)
Message-Id: <200307142125.h6ELPvad054797@happy-idiot-talk.infracaninophile.co.uk>
Date: Mon, 14 Jul 2003 22:25:57 +0100 (BST)
From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
Reply-To: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [Patch] x11/xstroke Makefile error 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         54485
>Category:       ports
>Synopsis:       [Patch] x11/xstroke Makefile error
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 14 14:30:10 PDT 2003
>Closed-Date:    Wed Jul 16 05:10:02 PDT 2003
>Last-Modified:  Wed Jul 16 05:10:02 PDT 2003
>Originator:     Matthew Seaman
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD happy-idiot-talk.infracaninophile.co.uk 4.8-STABLE FreeBSD 4.8-STABLE #16: Wed Jul 9 14:35:57 BST 2003 root@happy-idiot-talk.infracaninophile.co.uk:/usr/obj/usr/src/sys/HAPPY-IDIOT-TALK i386

>Description:

The last update to the x11/xstroke port Makefile has resulted in a
broken system that goes into an infinite loop attempting to generate
the value of the GETOPTDIR variable by:

    GETOPTDIR!=	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC

The command depends on the value of ${PORTSDIR}, but that appears to
be null at the crucial time, so make -V WRKSRC gets run again in the
same directory.  Etc. Ad nauseam.

Note this kills rebuilding INDEX and so affects rather more people
than just the people with x11/xstroke installed.

>How-To-Repeat:

% cd /usr/ports/x11/xstroke
% make
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
...

>Fix:

	

--- xstroke-Makefile.patch begins here ---
--- Makefile.bak	Mon Jul 14 22:03:51 2003
+++ Makefile	Mon Jul 14 22:14:00 2003
@@ -24,7 +24,7 @@
 CPPFLAGS=	-I${LOCALBASE}/include
 LDFLAGS=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 MAKE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
-GETOPTDIR!=	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC
+GETOPTDIR!=	cd ${.CURDIR}/../../devel/libgnugetopt; make -V WRKSRC
 
 MAN1=	xstroke.1
 
--- xstroke-Makefile.patch ends here ---


>Release-Note:
>Audit-Trail:

From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/54485: [Patch] x11/xstroke Makefile error
Date: Mon, 14 Jul 2003 23:04:15 +0100

 --IS0zKkzwUGydFO0o
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, Jul 14, 2003 at 10:25:57PM +0100, Matthew Seaman wrote:
 >=20
 > The last update to the x11/xstroke port Makefile has resulted in a
 > broken system that goes into an infinite loop attempting to generate
 > the value of the GETOPTDIR variable by:
 >=20
 >     GETOPTDIR!=3D	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC
 >=20
 > The command depends on the value of ${PORTSDIR}, but that appears to
 > be null at the crucial time, so make -V WRKSRC gets run again in the
 > same directory.  Etc. Ad nauseam.
 >=20
 > Note this kills rebuilding INDEX and so affects rather more people
 > than just the people with x11/xstroke installed.
 
 On second thoughts, this patch is better:
 
 --- Makefile.bak	Mon Jul 14 22:03:51 2003
 +++ Makefile	Mon Jul 14 22:58:10 2003
 @@ -24,7 +24,7 @@
  CPPFLAGS=3D	-I${LOCALBASE}/include
  LDFLAGS=3D	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
  MAKE_ENV+=3D	CPPFLAGS=3D"${CPPFLAGS}" LDFLAGS=3D"${LDFLAGS}"
 -GETOPTDIR!=3D	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC
 +GETOPTDIR!=3D	cd ${.CURDIR}/../../devel/libgnugetopt && make -V WRKSRC
 =20
  MAN1=3D	xstroke.1
 =20
 	Cheers,
 
 	Matthew
 
 --=20
 Dr Matthew J Seaman MA, D.Phil.                       26 The Paddocks
                                                       Savill Way
 PGP: http://www.infracaninophile.co.uk/pgpkey         Marlow
 Tel: +44 1628 476614                                  Bucks., SL7 1TH UK
 
 --IS0zKkzwUGydFO0o
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.2 (FreeBSD)
 
 iD8DBQE/EyjfdtESqEQa7a0RAoIfAJ4164zBGTM1vgiTC5taDwHNB0MINACdH+oZ
 ecWR2KU7RvSKNj+6RQdhJ5E=
 =ii0Y
 -----END PGP SIGNATURE-----
 
 --IS0zKkzwUGydFO0o--

From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: freebsd-ports-bugs@freebsd.org
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/54485: [Patch] x11/xstroke Makefile error
Date: Tue, 15 Jul 2003 18:14:35 +0100

 --zhXaljGHf11kAtnf
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 A different fix was committed.  Please close this PR.
 
 	Cheers,
 
 	Matthew
 
 
 --=20
 Dr Matthew J Seaman MA, D.Phil.                       26 The Paddocks
                                                       Savill Way
 PGP: http://www.infracaninophile.co.uk/pgpkey         Marlow
 Tel: +44 1628 476614                                  Bucks., SL7 1TH UK
 
 --zhXaljGHf11kAtnf
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.2 (FreeBSD)
 
 iD8DBQE/FDZ7dtESqEQa7a0RAtSBAJ9vkN1jCWjik/IQphUI4A1KPSR9KACfSWWj
 ydY4SC1n2YI3kQR/PlDhlk8=
 =PWoy
 -----END PGP SIGNATURE-----
 
 --zhXaljGHf11kAtnf--
State-Changed-From-To: open->closed 
State-Changed-By: sf 
State-Changed-When: Wed Jul 16 05:08:35 PDT 2003 
State-Changed-Why:  
port fixed in different way. Thank you for investigation. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54485 
>Unformatted:
