From root@kutulu.org  Mon Jul 14 07:10:56 2003
Return-Path: <root@kutulu.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 13A7037B401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jul 2003 07:10:56 -0700 (PDT)
Received: from basement.kutulu.org (pcp03610121pcs.longhl01.md.comcast.net [68.49.239.235])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 861D643F93
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jul 2003 07:10:55 -0700 (PDT)
	(envelope-from root@kutulu.org)
Received: by basement.kutulu.org (Postfix, from userid 0)
	id 918DAA9A9; Mon, 14 Jul 2003 10:11:05 -0400 (EDT)
Message-Id: <20030714141105.918DAA9A9@basement.kutulu.org>
Date: Mon, 14 Jul 2003 10:11:05 -0400 (EDT)
From: Michael Edenfield <kutulu@kutulu.org>
Reply-To: Michael Edenfield <kutulu@kutulu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: due to changes in bsd.port.mk, ports no longer install on pre-4.7 releases.	
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         54475
>Category:       ports
>Synopsis:       due to changes in bsd.port.mk, ports no longer install on pre-4.7 releases.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 14 07:20:16 PDT 2003
>Closed-Date:    Sat Jul 26 19:08:29 PDT 2003
>Last-Modified:  Sat Jul 26 19:08:29 PDT 2003
>Originator:     Michael Edenfield
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD basement.kutulu.org 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Wed Jul 9 16:49:03 EDT 2003 root@basement.kutulu.org:/usr/obj/usr/src/sys/GATEWAY i386


	
>Description:
bsd.port.mk now performs a check to see if the package is installed, 
using the pkg_info -O option.  This option was not introduced into 
FreeBSD until 5.x and was only MFC'd back as far as 4.7-RELEASE.

>How-To-Repeat:
Try to build any new port on FreeBSD 4.6.x or earlier.
>Fix:
--- bsd.port.mk.5 Fri Jul 11 08:06:04 2003
+++ bsd.port.mk       Mon Jul 14 10:06:00 2003
@@ -3007,7 +3007,7 @@
 
 .if !target(check-already-installed)
 check-already-installed:
-.if !defined(NO_PKG_REGISTER) && !defined(FORCE_PKG_REGISTER)
+.if !defined(NO_PKG_REGISTER) && !defined(FORCE_PKG_REGISTER) && ${OSVERSION} >= 470000
                @${ECHO_MSG} "===>  Checking if ${PKGORIGIN} already installed"
                @already_installed=`${PKG_INFO} -q -O ${PKGORIGIN} 2> /dev/null`; \
                if [ -n "$${already_installed}" ]; then \

>Release-Note:
>Audit-Trail:

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: freebsd-gnats-submit@FreeBSD.org, kutulu@kutulu.org
Cc:  
Subject: Re: ports/54475: due to changes in bsd.port.mk, ports no longer install
 on pre-4.7 releases.
Date: Mon, 14 Jul 2003 17:54:06 +0200

 PR ports/54478 offers an alternative approach to the problem
 
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: erwin 
Responsible-Changed-When: Mon Jul 14 09:20:44 PDT 2003 
Responsible-Changed-Why:  
portmgr territory 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54475 
State-Changed-From-To: open->analyzed 
State-Changed-By: kris 
State-Changed-When: Wed Jul 23 04:56:42 PDT 2003 
State-Changed-Why:  
A fix for this has been submitted and is currently being 
tested on bento. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54475 

From: "Jimbo" <jimbo@jimbosworld.org>
To: <freebsd-gnats-submit@FreeBSD.org>, <kutulu@kutulu.org>
Cc:  
Subject: Re: ports/54475: due to changes in bsd.port.mk, ports no longer install on pre-4.7 releases.
Date: Wed, 23 Jul 2003 19:55:28 -0400

 make install works fine after applying this patch to
 /usr/ports/Mk/bsd.port.mk, but make deinstall still returns error code 1.
 
 This is mostly a minor inconvenience - as far as I can tell, issuing a
 pkg_delete manually accomplishes the same end result, and does in fact
 remove the package as expected.  It would be nice for make deinstall to work
 properly again too, though.
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Sat Jul 26 19:08:05 PDT 2003 
State-Changed-Why:  
Fixed in r1.458 of bsd.port.mk 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54475 
>Unformatted:
