From sem@ciam.ru  Thu Jun 26 11:13:02 2003
Return-Path: <sem@ciam.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8A66A37B401; Thu, 26 Jun 2003 11:13:02 -0700 (PDT)
Received: from harp.mtu.ru (harp.mtu.ru [212.188.8.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C933E43F85; Thu, 26 Jun 2003 11:13:00 -0700 (PDT)
	(envelope-from sem@ciam.ru)
Received: from hueymiccailhuitl.mtu.ru (hueytecuilhuitl.mtu.ru [195.34.32.123])
	by harp.mtu.ru (Postfix) with ESMTP
	id 5A7F123F20; Thu, 26 Jun 2003 22:01:32 +0400 (MSD)
Received: from sem-home.ciam.ru (ppp138-73.dialup.mtu-net.ru [62.118.138.73])
	by hueymiccailhuitl.mtu.ru (Postfix) with ESMTP
	id 49ADDF891E; Thu, 26 Jun 2003 21:53:01 +0400 (MSD)
	(envelope-from sem@ciam.ru)
Received: from sem by sem-home.ciam.ru with local (Exim 4.12)
	id 19Vavd-0000iB-00; Thu, 26 Jun 2003 21:53:01 +0400
Message-Id: <E19Vavd-0000iB-00@sem-home.ciam.ru>
Date: Thu, 26 Jun 2003 21:53:01 +0400
From: Sergey Matveychuk <sem@ciam.ru>
Reply-To: Sergey Matveychuk <sem@ciam.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: kde@freebsd.org, ports@freebsd.org
Subject: Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         53791
>Category:       ports
>Synopsis:       Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 26 11:20:10 PDT 2003
>Closed-Date:    Wed Feb 04 17:54:06 PST 2004
>Last-Modified:  Wed Feb 04 17:54:06 PST 2004
>Originator:     Sergey Matveychuk
>Release:        FreeBSD 5.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD sem-home.ciam.ru 5.1-RELEASE FreeBSD 5.1-RELEASE #0: Wed Jun 11 02:03:37 MSD 2003 root@sem-home.ciam.ru:/usr/src/sys/i386/compile/SEM-HOME i386


	
>Description:
	
	My port can build WITH_QT or without it. Also I pass CPPFLAGS
	to 'configure' by CONFIGURE_ENV. When I don't set WITH_QT
	all goes right, when I don't set it I loss CPPFLAGS in
	'configure'. It's happened because these lines in bsd.kde.mk:

        CONFIGURE_ENV+=	CPPFLAGS="${QTCPPFLAGS}"

	that overrides my CPPFLAGS settings.
	The followed patch fix it. I think it's unpainful for other KDE
	stuff.

	It's important for my port. So let me know if it's possible
	to commit it soon, please.

>How-To-Repeat:
	
>Fix:

	


--- bsd.kde.mk.orig	Thu Jun 26 21:17:13 2003
+++ bsd.kde.mk	Thu Jun 26 21:20:36 2003
@@ -110,8 +110,9 @@
 .if !defined (QT_NONSTANDARD)
 CONFIGURE_ARGS+=--with-extra-libs="${LOCALBASE}/lib" \
 				--with-extra-includes="${LOCALBASE}/include"
-CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" \
-				QTDIR="${QT_CVS_PREFIX}" KDEDIR="${KDE_CVS_PREFIX}"
+CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" \
+				LIBS="${QTCFGLIBS}" QTDIR="${QT_CVS_PREFIX}" \
+				KDEDIR="${KDE_CVS_PREFIX}"
 .endif
 
 .elif ${USE_QT_VER} == 3
@@ -139,7 +140,8 @@
 CONFIGURE_ARGS+=--with-qt-includes=${QT_PREFIX}/include \
 				--with-qt-libraries=${QT_PREFIX}/lib \
 				--with-extra-libs=${LOCALBASE}/lib
-CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}"
+CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" \
+			    LIBS="${QTCFGLIBS}"
 .endif # !defined(QT_NONSTANDARD)
 
 .else # QT2
@@ -159,7 +161,7 @@
 				--with-qt-libraries=${X11BASE}/lib \
 				--with-extra-libs=${LOCALBASE}/lib
 CONFIGURE_ENV+=	MOC="${MOC}" LIBQT="-l${QTNAME}" \
-				CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}"
+				CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}"
 .endif # !defined(QT_NONSTANDARD)
 
 .endif # USE_QT_VER == ???
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: arved 
Responsible-Changed-When: Thu Jun 26 11:43:11 PDT 2003 
Responsible-Changed-Why:  
over to maintainers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53791 
State-Changed-From-To: open->feedback 
State-Changed-By: will 
State-Changed-When: Fri Jun 27 06:02:45 PDT 2003 
State-Changed-Why:  
What's wrong with appending to QTCPPFLAGS?  Also, do you think 
a similar thing should be added to QTCFGLIBS/LIBS (i.e. add 
LDFLAGS to that passed variable? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53791 

From: Tilman Linneweh <arved@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, sem@ciam.ru
Cc: will@FreeBSD.org
Subject: Re: ports/53791: Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch)
Date: Wed, 20 Aug 2003 13:41:48 +0200

 Hi Will, Hi Sem,
 
 IIRC, Will told me on IRC that there were private followups to this PR between 
 you two, which ended in an improved patch. 
 Unfortunately this PR is still open. So I would like to see the improved patch 
 too, either in my Inbox or in my cvsup :-)
 
 regards
 tilman
State-Changed-From-To: feedback->closed 
State-Changed-By: lofi 
State-Changed-When: Wed Feb 4 17:53:35 PST 2004 
State-Changed-Why:  
Should be fixed with the 3.2.0 commit. Thanks for 
reporting! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=53791 
>Unformatted:
