From lioux@brturbo.com  Tue May 13 07:49:07 2003
Return-Path: <lioux@brturbo.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D887E37B404
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 May 2003 07:49:07 -0700 (PDT)
Received: from heaven.gigo.com (heaven.gigo.com [64.57.102.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5703043FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 May 2003 07:49:07 -0700 (PDT)
	(envelope-from lioux@brturbo.com)
Received: from 200-193-225-154.bsace7003.dsl.brasiltelecom.net.br (200-193-225-154.bsace7003.dsl.brasiltelecom.net.br [200.193.225.154])
	by heaven.gigo.com (Postfix) with ESMTP id 337F0B8B6
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 May 2003 07:49:05 -0700 (PDT)
Received: (qmail 30543 invoked by uid 1001); 13 May 2003 14:45:28 -0000
Message-Id: <20030513144528.30542.qmail@exxodus.fedaykin.here>
Date: 13 May 2003 14:45:28 -0000
From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
Reply-To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bsd.port.mk - Modify USE_GETOPT_LONG option when GNU_CONFIGURE
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         52173
>Category:       ports
>Synopsis:       [patch] bsd.port.mk - Modify USE_GETOPT_LONG option when GNU_CONFIGURE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 13 07:50:09 PDT 2003
>Closed-Date:    Sat Mar 20 18:16:01 PST 2004
>Last-Modified:  Sat Mar 20 18:16:01 PST 2004
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD exxodus.home.net 4.8-STABLE FreeBSD 4.8-STABLE #0: Sat May 10 15:40:47 BRT 2003 lioux@exxodus.home.het:/usr/obj/usr/src/sys/LIOUX i386


	
>Description:

	USE_GETOPT_LONG adds CONFIGURE_ENV* information which only
makes sense when GNU_CONFIGURE is being used. Therefore, I've added
that check around the vars. Could we run this test over the weekend
then commit?

>How-To-Repeat:
	
>Fix:

--- bsd.port.mk.orig	Thu Apr 17 16:00:03 2003
+++ bsd.port.mk	Fri Apr 18 13:29:26 2003
@@ -1260,9 +1260,11 @@
 .if defined(USE_GETOPT_LONG)
 .if ${OSVERSION} < 500041
 LIB_DEPENDS=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
+.if defined(GNU_CONFIGURE)
 CPPFLAGS+=		-I${LOCALBASE}/include
 LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+.endif
 .endif
 .endif
 

>Release-Note:
>Audit-Trail:

From: Tilman Linneweh <tilman@arved.de>
To: Mario Sergio Fujikawa Ferreira <lioux@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: Tue, 13 May 2003 18:45:18 +0200

 * Mario Sergio Fujikawa Ferreira [Di, 13 Mai 2003 at 16:50 GMT]:
 > --- bsd.port.mk.orig	Thu Apr 17 16:00:03 2003
 > +++ bsd.port.mk	Fri Apr 18 13:29:26 2003
 > @@ -1260,9 +1260,13 @@
 >  .if defined(USE_GETOPT_LONG)
 >  .if ${OSVERSION} < 500041
 >  LIB_DEPENDS=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
 > +.if defined(GNU_CONFIGURE)
 >  CPPFLAGS+=		-I${LOCALBASE}/include
 >  LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 >  CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
   +.else
   +MAKE_ENV+=		CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 > +.endif
 >  .endif
 >  .endif
 
 regards
 tilman

From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: Tilman Linneweh <tilman@arved.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: Tue, 13 May 2003 15:06:36 -0300

 	Updated patch with arved's catch.
 Do you propose that we always define CPPFLAGS and LDFLAGS?
 And use them as MAKE_ENV if not GNU_CONFIGURE?
 Isn't CFLAGS more appropriate then CPPFLAGS when we don't have
 GNU_CONFIGURE?
 
 --- With arved's catch
 
 --- bsd.port.mk.orig	Tue May  6 03:46:16 2003
 +++ bsd.port.mk	Tue May 13 15:03:01 2003
 @@ -1271,7 +1271,11 @@
  LIB_DEPENDS+=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
  CPPFLAGS+=		-I${LOCALBASE}/include
  LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 +.if defined(GNU_CONFIGURE)
  CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +.else
 +MAKE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +.endif
  .endif
  .endif
 
 --- Using CFLAGS's idea (still not sure about it)
 
 --- bsd.port.mk.orig	Tue May  6 03:46:16 2003
 +++ bsd.port.mk	Tue May 13 15:06:11 2003
 @@ -1269,9 +1269,14 @@
  .if defined(USE_GETOPT_LONG)
  .if ${OSVERSION} < 500041
  LIB_DEPENDS+=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
 -CPPFLAGS+=		-I${LOCALBASE}/include
  LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 +.if defined(GNU_CONFIGURE)
 +CPPFLAGS+=		-I${LOCALBASE}/include
  CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +.else
 +CFLAGS+=		-I${LOCALBASE}/include
 +MAKE_ENV+=	CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}"
 +.endif
  .endif
  .endif
  
 -- 
 Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
 FreeBSD Committer | CS Developer
 flames to beloved devnull@someotherworldbeloworabove.org
 feature, n: a documented bug | bug, n: an undocumented feature

From: Eric Anholt <eta@lclark.edu>
To: Mario Sergio Fujikawa Ferreira <lioux@freebsd.org>
Cc: gnats <freebsd-gnats-submit@FreeBSD.ORG>
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: 13 May 2003 11:37:25 -0700

 On Tue, 2003-05-13 at 11:10, Mario Sergio Fujikawa Ferreira wrote:
 >  Do you propose that we always define CPPFLAGS and LDFLAGS?
 >  And use them as MAKE_ENV if not GNU_CONFIGURE?
 >  Isn't CFLAGS more appropriate then CPPFLAGS when we don't have
 >  GNU_CONFIGURE?
 
 What about things that use imake, which are non-GNU_CONFIGURE and have a
 make depend step that needs the -I flags but doesn't want other CFLAGS
 options.  CPPFLAGS seems like the appropriate thing to handle that.  (I
 was looking at this for xstroke)
 
 -- 
 Eric Anholt                                eta@lclark.edu          
 http://people.freebsd.org/~anholt/         anholt@FreeBSD.org
 
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: ijliao 
Responsible-Changed-When: Wed May 14 09:48:01 PDT 2003 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52173 

From: Tilman Linneweh <arved@FreeBSD.org>
To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: Wed, 14 May 2003 23:14:59 +0200

 --=.ackSzwaXtIUn8a
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 * Mario Sergio Fujikawa Ferreira [Tue, 13 May 2003 15:06:36 -0300]:
 
 > 	Updated patch with arved's catch.
 > Do you propose that we always define CPPFLAGS and LDFLAGS?
 > And use them as MAKE_ENV if not GNU_CONFIGURE?
 > Isn't CFLAGS more appropriate then CPPFLAGS when we don't have
 > GNU_CONFIGURE?
  
 
 > --- Using CFLAGS's idea (still not sure about it)
 > 
 > --- bsd.port.mk.orig	Tue May  6 03:46:16 2003
 > +++ bsd.port.mk	Tue May 13 15:06:11 2003
 > @@ -1269,9 +1269,14 @@
 >  .if defined(USE_GETOPT_LONG)
 >  .if ${OSVERSION} < 500041
 >  LIB_DEPENDS+=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
 > -CPPFLAGS+=		-I${LOCALBASE}/include
 >  LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 > +.if defined(GNU_CONFIGURE)
 > +CPPFLAGS+=		-I${LOCALBASE}/include
 >  CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 > +.else
 > +CFLAGS+=		-I${LOCALBASE}/include
 > +MAKE_ENV+=	CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}"
 > +.endif
 >  .endif
 >  .endif
 
 You are right! CFLAGS is much more common in Makefiles without
 configure.
 
 regards
 tilman
 
 
 
 
 --=.ackSzwaXtIUn8a
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.2 (FreeBSD)
 
 iD8DBQE+wrHTfCLDn4B6xToRAukGAJ45a/d9zZ68jDmZWpLeNM3wXh/CYgCghmAH
 22/VbkYhxnHdaYQGwl+IFVg=
 =HfEP
 -----END PGP SIGNATURE-----
 
 --=.ackSzwaXtIUn8a--

From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: Tilman Linneweh <arved@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, anholt@FreeBSD.org
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: Wed, 14 May 2003 21:02:27 -0300

 Hi,
 
 	I hope this last version settles it. Eric raised a fair
 point that imake uses CPPFLAGS but ignores CFLAGS. Therefore, I
 added that to the CFLAGS version of the patch. The patch looks more
 complicated now but this is the trimmed version.  I can duplicate
 code to make it more readable if that's necessary.
 
 --- bsd.port.mk.orig	Tue May  6 02:14:56 2003
 +++ bsd.port.mk	Wed May 14 21:01:04 2003
 @@ -1266,14 +1266,28 @@
  BUILD_DEPENDS+=	gcc32:${PORTSDIR}/lang/gcc32
  .endif
  
 +# GNU_CONFIGURE uses CPPFLAGS and LDFLAGS with CONFIGURE_ENV
 +# USE_IMAKE uses CPPFLAGS and LDFLAGS with MAKE_ENV
 +# otherwise, default to CFLAGS and LDFLAGS with MAKE_ENV
  .if defined(USE_GETOPT_LONG)
  .if ${OSVERSION} < 500041
  LIB_DEPENDS+=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
 -CPPFLAGS+=		-I${LOCALBASE}/include
  LDFLAGS+=		-L${LOCALBASE}/lib -lgnugetopt
 -CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 -.endif
 +.if defined(GNU_CONFIGURE) || defined(USE_IMAKE)
 +CPPFLAGS+=		-I${LOCALBASE}/include
  .endif
 +.if defined(GNU_CONFIGURE)
 +CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +.else # !GNU_CONFIGURE
 +.if defined(USE_IMAKE)
 +MAKE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +.else # !(GNU_CONFIGURE || USE_IMAKE)
 +CFLAGS+=		-I${LOCALBASE}/include
 +MAKE_ENV+=	CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}"
 +.endif # USE_IMAKE
 +.endif # GNU_CONFIGURE
 +.endif # ${OSVERSION} < 500041
 +.endif # USE_GETOPT_LONG
  
  .if defined(USE_LINUX)
  RUN_DEPENDS+=	${LINUXBASE}/etc/redhat-release:${PORTSDIR}/emulators/linux_base
 
 -- 
 Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
 FreeBSD Committer | CS Developer
 flames to beloved devnull@someotherworldbeloworabove.org
 feature, n: a documented bug | bug, n: an undocumented feature
State-Changed-From-To: open->analyzed 
State-Changed-By: kris 
State-Changed-When: Sun Jul 6 17:09:04 PDT 2003 
State-Changed-Why:  
Scheduled for testing on the next bento run 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52173 
State-Changed-From-To: analyzed->suspended 
State-Changed-By: kris 
State-Changed-When: Wed Jul 23 22:06:04 PDT 2003 
State-Changed-Why:  
The most recent patch in the audit trail causes problems 
with a number of ports.  e.g. 

csv2latex-20030501 
zh-oto-0.4_1 
smtpmap-0.8_1 
pptpclient-1.1.0_1 
... 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52173 
State-Changed-From-To: suspended->closed 
State-Changed-By: kris 
State-Changed-When: Sat Mar 20 18:15:42 PST 2004 
State-Changed-Why:  
Patch was broken, no followup submitted. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52173 
>Unformatted:
