From cyrille.lefevre@laposte.net  Mon May  5 05:57:50 2003
Return-Path: <cyrille.lefevre@laposte.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B931737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 May 2003 05:57:50 -0700 (PDT)
Received: from smtp.noos.fr (nan-smtp-03.noos.net [212.198.2.72])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6376943F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 May 2003 05:57:49 -0700 (PDT)
	(envelope-from cyrille.lefevre@laposte.net)
Received: (qmail 35657041 invoked by uid 0); 5 May 2003 12:57:47 -0000
Received: from unknown (HELO mail.gits.dyndns.org) ([212.198.231.104])
          (envelope-sender <cyrille.lefevre@laposte.net>)
          by 212.198.2.72 (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <FreeBSD-gnats-submit@freebsd.org>; 5 May 2003 12:57:47 -0000
Received: from gits.gits.fr.invalid (7b3msad6wcsl5iqd@localhost [127.0.0.1])
	by mail.gits.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h45CvhZ9099237
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 5 May 2003 14:57:44 +0200 (CEST)
	(envelope-from cyrille.lefevre@laposte.net)
Received: by gits.gits.fr.invalid (tmda-inject, from uid 0);
	Mon, 05 May 2003 14:57:43 +0200
Message-Id: <20030505125738.GA57622@gits.dyndns.org>
Date: Mon, 5 May 2003 14:57:38 +0200
From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
Reply-To: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: tg@freebsd.org
Subject: Change-request: shell/pdksh (pdksh-5.2.14p2 -> pdksh-5.2.14.p2)
X-Send-Pr-Version: 3.113

>Number:         51791
>Category:       ports
>Synopsis:       Change-request: shell/pdksh (pdksh-5.2.14p2 -> pdksh-5.2.14.p2)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 05 06:00:20 PDT 2003
>Closed-Date:    Thu May 13 09:16:11 PDT 2004
>Last-Modified:  Thu May 13 09:20:22 PDT 2004
>Originator:     Cyrille Lefevre
>Release:        FreeBSD 5.0-RELEASE-p4 i386
>Organization:
ACME
>Environment:
System: FreeBSD gits 5.0-RELEASE-p4 FreeBSD 5.0-RELEASE-p4 #8: Thu Apr 24 19:09:07 CEST 2003 root@gits:/disk3/freebsd/current/obj/disk3/freebsd/current/src/sys/CUSTOM i386
>Description:
	regarding the porters handbook, this port should be named
	pdksh-5.2.14.p2 and not pdksh-5.2.14p2. see the following
	URL for details :

	http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#PORTING-PKGNAME

	Makefile
		PORTVERSION and DISTNAME changed
		USE_REINPLACE added
		"ed" changed to REINPLACE_CMD
>How-To-Repeat:
	n/a
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/shells/pdksh/Makefile,v
retrieving revision 1.28
diff -u -I$Id.*$ -I$.+BSD.*$ -r1.28 Makefile
--- Makefile	7 Mar 2003 06:10:39 -0000	1.28
+++ Makefile	29 Apr 2003 06:23:06 -0000
@@ -6,14 +6,14 @@
 #
 
 PORTNAME=	pdksh
-PORTVERSION=	5.2.14p2
+PORTVERSION=	5.2.14.p2
 CATEGORIES=	shells
 MASTER_SITES=	ftp://ftp.cs.mun.ca/pub/pdksh/ \
 		http://gd.tuwien.ac.at/utils/shells/pdksh/ \
 		ftp://ftp.lip6.fr/pub/unix/shells/pdksh/ \
 		ftp://ftp.demon.net/pub/mirrors/pdksh/ \
 		ftp://ftp.rge.com/pub/shells/pdksh/
-DISTNAME=	${PORTNAME}-${PORTVERSION:C/p.*//}
+DISTNAME=	${PORTNAME}-${PORTVERSION:R}
 
 PATCH_SITES=	${MASTER_SITES}
 PATCHFILES=	${DISTNAME}-patches.1 ${DISTNAME}-patches.2
@@ -22,13 +22,17 @@
 MAINTAINER=	tg@FreeBSD.org
 COMMENT=	The Public Domain Korn Shell
 
+USE_REINPLACE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ENV=	LDSTATIC=-static
 MAN1=		ksh.1
 
 post-patch:
-	@(${ECHO_CMD} ",s/v${PORTVERSION:C/p.*//}/v${PORTVERSION:S/p/./}/"; \
-		${ECHO_CMD} "wq") | ed -s ${WRKSRC}/version.c
+.for file in ksh.Man version.c
+	@${REINPLACE_CMD} -e \
+	"s/v${PORTVERSION:N*p*}${PORTVERSION:M*p*:R} /v${PORTVERSION:S/p//} /"\
+		${WRKSRC}/${file}
+.endfor
 
 post-install:
 	@${ECHO} "Updating /etc/shells"
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->tg 
Responsible-Changed-By: oliver 
Responsible-Changed-When: Thu Jun 19 05:18:57 PDT 2003 
Responsible-Changed-Why:  
over the maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51791 
State-Changed-From-To: open->closed 
State-Changed-By: vs 
State-Changed-When: Thu May 13 09:08:55 PDT 2004 
State-Changed-Why:  
Solution not straight-forward and current state not really 
harmful (feel free to disagree). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51791 

From: Volker Stolz <vs@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, cyrille.lefevre@laposte.net
Cc:  
Subject: Re: ports/51791: Change-request: shell/pdksh (pdksh-5.2.14p2 -> pdksh-5.2.14.p2)
Date: Thu, 13 May 2004 18:13:29 +0200

 Unluckily, the new suggested version would be smaller than the previous 
 version:
 menelaos> pkg_version -t pdksh-5.2.14p2 pdksh-5.2.14.p2
 >
 
 So this would require a PORTEPOCH-bump which would stick around even after 
 an eventual
 update to 6.x. I think we can live with the current state of affairs.
 
 Volker
>Unformatted:
