From os@brain.cc.rsu.ru  Mon Apr 28 05:27:56 2003
Return-Path: <os@brain.cc.rsu.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4D9F737B401; Mon, 28 Apr 2003 05:27:56 -0700 (PDT)
Received: from brain.cc.rsu.ru (brain.cc.rsu.ru [195.208.252.154])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 19E5A43FAF; Mon, 28 Apr 2003 05:27:55 -0700 (PDT)
	(envelope-from os@brain.cc.rsu.ru)
Received: from brain.cc.rsu.ru (smmsp@localhost [127.0.0.1])
	by brain.cc.rsu.ru (8.12.9/8.12.9) with ESMTP id h3SCRlq4014332;
	Mon, 28 Apr 2003 16:27:47 +0400 (MSD)
	(envelope-from os@brain.cc.rsu.ru)
Received: (from os@localhost)
	by brain.cc.rsu.ru (8.12.9/8.12.9/Submit) id h3SCHq9S069129;
	Mon, 28 Apr 2003 16:17:52 +0400 (MSD)
	(envelope-from os)
Message-Id: <200304281217.h3SCHq9S069129@brain.cc.rsu.ru>
Date: Mon, 28 Apr 2003 16:17:52 +0400 (MSD)
From: Oleg Sharoiko <os@rsu.ru>
Reply-To: Oleg Sharoiko <os@rsu.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: DougB@freebsd.org
Subject: [patch] mail/pine4 can not be build with OpenSSL from ports
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51492
>Category:       ports
>Synopsis:       [patch] mail/pine4 can not be build with OpenSSL from ports
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 28 05:30:10 PDT 2003
>Closed-Date:    Mon Apr 28 10:32:57 PDT 2003
>Last-Modified:  Mon Apr 28 10:32:57 PDT 2003
>Originator:     Oleg Sharoiko
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
>Environment:
System: FreeBSD brain.cc.rsu.ru 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Mon Apr 28 11:38:32 GMT 2003 os@make.cc.rsu.ru:/usr/src/sys/compile/brain.k7.RELENG_4.2003-04-25 i386


	
>Description:
	mail/pine4 uses USE_OPENSSL from bsd.ports/mk which makes it
	impossible to build pine with OpenSSL from ports. The applied patch
	solves the problem by using security/openssl/bsd.openssl.mk and
	bsd.port.pre.mk + bsd.port.post.mk instead of bsd.port.mk

>How-To-Repeat:
	
>Fix:

	The patch for mail/pine4/Makefile:

--- Makefile    19 Apr 2003 05:43:02 -0000      1.70
+++ Makefile    28 Apr 2003 12:12:59 -0000
@@ -23,6 +23,8 @@
 
 RUN_DEPENDS=   ispell:${PORTSDIR}/textproc/ispell
 
+.include <bsd.port.pre.mk>
+
 # Define "WITH_LDAP" to include ldap support.
 # If the ldap port is installed somewhere other than /usr/local, define
 # LDAP_PREFIX as well.
@@ -35,7 +37,7 @@
 .if defined(WITHOUT_SSL)
 MAKE_ARGS+=    SSLTYPE=none
 .else
-USE_OPENSSL=   yes
+.include "${PORTSDIR}/security/openssl/bsd.openssl.mk"
 EXTRA_OPTS=    SSLINCLUDE=${OPENSSLINC} SSLLIB=${OPENSSLLIB}
 .if defined(WITH_SSL_AND_PLAINTEXT)
 EXTRA_OPTS+=   SSLTYPE=unix
@@ -96,4 +98,4 @@
 
        @${CAT} pkg-message
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dougb 
Responsible-Changed-By: arved 
Responsible-Changed-When: Mon Apr 28 06:26:46 PDT 2003 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51492 
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Mon Apr 28 10:30:38 PDT 2003 
State-Changed-Why:  

A better solution is to use the option in the openssl Makefile 
to have the port installation override the base. 

A better solution still is to upgrade your system to get the 
latest openssl built in.  

I'm sorry to say, I don't think that the solution you propose is 
suitable for the vast majority of pine users, and since other, 
arguably better solutions already exist, I will not be adopting 
your suggestion. 

Thanks for your interest. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51492 
>Unformatted:
