From stacey@vickiandstacey.com  Sat Apr 26 16:57:29 2003
Return-Path: <stacey@vickiandstacey.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B605737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Apr 2003 16:57:29 -0700 (PDT)
Received: from shockwave.systems.pipex.net (shockwave.systems.pipex.net [62.241.160.9])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA7F943FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Apr 2003 16:57:28 -0700 (PDT)
	(envelope-from stacey@vickiandstacey.com)
Received: from omni.vickiandstacey.com (81-86-129-77.dsl.pipex.com [81.86.129.77])
	by shockwave.systems.pipex.net (Postfix) with ESMTP id 41AAC1600009F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Apr 2003 00:57:26 +0100 (BST)
Received: from omni.vickiandstacey.com (localhost [127.0.0.1])
	by omni.vickiandstacey.com (8.12.9/8.12.9) with ESMTP id h3QNvQtD071139
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Apr 2003 00:57:27 +0100 (BST)
	(envelope-from stacey@omni.vickiandstacey.com)
Received: (from stacey@localhost)
	by omni.vickiandstacey.com (8.12.9/8.12.9/Submit) id h3QNvPxX071138;
	Sun, 27 Apr 2003 00:57:25 +0100 (BST)
Message-Id: <200304262357.h3QNvPxX071138@omni.vickiandstacey.com>
Date: Sun, 27 Apr 2003 00:57:25 +0100 (BST)
From: Stacey Roberts <stacey@vickiandstacey.com>
Reply-To: Stacey Roberts <stacey@vickiandstacey.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: "startx" coredumps since portupgrading XFree86-4-Server today
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51450
>Category:       ports
>Synopsis:       "startx" coredumps since portupgrading XFree86-4-Server today
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    anholt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 26 17:00:26 PDT 2003
>Closed-Date:    Sat May 03 15:18:49 PDT 2003
>Last-Modified:  Sat May 03 15:18:49 PDT 2003
>Originator:     Stacey Roberts
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD omni.vickiandstacey.com 4.8-STABLE FreeBSD 4.8-STABLE #0: Mon Apr 21 20:53:10 BST 2003 stacey@omni.vickiandstacey.com:/usr/src/sys/compile/XE2 i386

>Description:
I am unable to log into X since I portupgraded XFree86-4-Server today. I had not logged off immediately after upgrading, but had logged off just now, and when I attempted to run "startx" I got a coredump. I don't know how to submit the log file with send-pr, but I am happy to send this to whomever is responsible for XFree-4-Server.
Note, I habe *not* changed anything on this machine recently other than installing Opera. The machine has an uptime of over 5 days, and has been running fine in that time. The only changes to occur is the upgrade to XFree86-4-Server today.

>How-To-Repeat:
For me, running "startx" on this machine with the latest XFree86-4-Server, default cvsup server is cvsup2.FreeBSD.org - earlier today.

>Fix:
Haven't a clue


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->anholt 
Responsible-Changed-By: adamw 
Responsible-Changed-When: Sat Apr 26 17:16:58 PDT 2003 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51450 

From: Eric Anholt <eta@lclark.edu>
To: freebsd-gnats-submit@FreeBSD.org, stacey@vickiandstacey.com
Cc:  
Subject: Re: ports/51450: "startx" coredumps since portupgrading
	XFree86-4-Server today
Date: 02 May 2003 03:19:45 -0700

 --=-Bi9EnTlcGVbFh0dVFFe1
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 In your private email, you posted a log including a crash with the
 siliconmotion driver.  XFree86 bug #50 seems to cover this issue and
 includes a patch.  I've attached a patch, please apply it to
 XFree86-4-Server and rebuild and see if it fixes things.
 
 Note: this PR would have been much more helpful if it had included what
 XFree86 version you updated from.  The XFree86.0.log could have been
 included with send-pr -a.  Though that would have put it in the "Fix"
 section, I would have been able to look up this problem and fix it much
 earlier rather than letting it rot in my inbox.
 
 -- 
 Eric Anholt                                eta@lclark.edu          
 http://people.freebsd.org/~anholt/         anholt@FreeBSD.org
 
 --=-Bi9EnTlcGVbFh0dVFFe1
 Content-Disposition: attachment; filename=smi.diff
 Content-Type: text/x-patch; name=smi.diff; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/x11-servers/XFree86-4-Server/Makefile,v
 retrieving revision 1.138
 diff -u -r1.138 Makefile
 --- Makefile	30 Apr 2003 00:16:00 -0000	1.138
 +++ Makefile	2 May 2003 10:04:27 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	Server
  PORTVERSION=	4.3.0
 -PORTREVISION=	5
 +PORTREVISION=	6
  CATEGORIES=	x11-servers
  MASTER_SITES=	${MASTER_SITE_XFREE:S/$/:x/} \
  		${MASTER_SITE_LOCAL:S/$/:local/}
 @@ -34,7 +34,7 @@
  .for pf in patch-savage-pci-id patch-alpha_video.c patch-Pci.h patch-radeondri \
  	patch-r128_driver.c patch-mga_driver.c patch-xkbInit.c patch-radeon_dri.c \
  	patch-mga_dri.c patch-nv_driver.c patch-nv_setup.c patch-int10-generic.c \
 -	patch-radeon_cursor.c patch-radeon_reg.h
 +	patch-radeon_cursor.c patch-radeon_reg.h patch-smi
  EXTRA_PATCHES+=		${FILESDIR}/${pf}
  .endfor
  SCRIPTS_ENV=		OSVERSION=${OSVERSION} \
 Index: files/patch-smi
 ===================================================================
 RCS file: files/patch-smi
 diff -N files/patch-smi
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-smi	2 May 2003 10:10:01 -0000
 @@ -0,0 +1,40 @@
 +--- programs/Xserver/hw/xfree86/drivers/siliconmotion/smi_driver.c.orig	Wed Feb  5 09:45:29 2003
 ++++ programs/Xserver/hw/xfree86/drivers/siliconmotion/smi_driver.c	Fri May  2 03:09:24 2003
 +@@ -1410,7 +1410,7 @@
 + 	ENTER_PROC("SMI_Save");
 + 
 + 	/* Save the standard VGA registers */
 +-	vgaHWSave(pScrn, vgaSavePtr, VGA_SR_MODE);
 ++	vgaHWSave(pScrn, vgaSavePtr, VGA_SR_ALL);
 + 	save->smiDACMask = VGAIN8(pSmi, VGA_DAC_MASK);
 + 	VGAOUT8(pSmi, VGA_DAC_READ_ADDR, 0);
 + 	for (i = 0; i < 256; i++)
 +@@ -1601,7 +1601,7 @@
 + 		VGAOUT8_INDEX(pSmi, VGA_SEQ_INDEX, VGA_SEQ_DATA, 0xA0, restore->SRA0);
 + 
 + 		/* Restore the standard VGA registers */
 +-		vgaHWRestore(pScrn, vgaSavePtr, VGA_SR_MODE);
 ++		vgaHWRestore(pScrn, vgaSavePtr, VGA_SR_ALL);
 + 		if (restore->smiDACMask)
 + 		{
 + 			VGAOUT8(pSmi, VGA_DAC_MASK, restore->smiDACMask);
 +@@ -1672,7 +1672,7 @@
 + 		} 
 + 
 + 		if (restore->modeInit)
 +-		    vgaHWRestore(pScrn, vgaSavePtr, VGA_SR_MODE);
 ++		    vgaHWRestore(pScrn, vgaSavePtr, VGA_SR_ALL);
 + 
 + 		if (!SMI_LYNXM_SERIES(pSmi->Chipset))
 + 		{
 +--- programs/Xserver/hw/xfree86/drivers/siliconmotion/smi_video.c.orig	Sat Jan 11 19:55:49 2003
 ++++ programs/Xserver/hw/xfree86/drivers/siliconmotion/smi_video.c	Fri May  2 03:09:24 2003
 +@@ -277,7 +277,7 @@
 +     {XvSettable | XvGettable,        0,             1, XV_INTERLACED_NAME},
 + };
 + 
 +-static XF86AttributeRec SMI_VideoAttributes[N_ATTRS] = {
 ++static XF86AttributeRec SMI_VideoAttributes[2] = {
 +     {XvSettable | XvGettable,        0,           255, XV_BRIGHTNESS_NAME},
 +     {XvSettable | XvGettable, 0x000000,      0xFFFFFF, XV_COLORKEY_NAME},
 + };
 
 --=-Bi9EnTlcGVbFh0dVFFe1--
 
State-Changed-From-To: open->closed 
State-Changed-By: anholt 
State-Changed-When: Sat May 3 15:18:23 PDT 2003 
State-Changed-Why:  
The patch has been committed.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51450 
>Unformatted:
