From m@isrv.tric.tomsk.gov.ru  Mon Apr  7 11:01:58 2003
Return-Path: <m@isrv.tric.tomsk.gov.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C6DC037B401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Apr 2003 11:01:58 -0700 (PDT)
Received: from isrv.tric.tomsk.gov.ru (isrv.tric.tomsk.gov.ru [213.183.106.13])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3608543FBD
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Apr 2003 11:01:56 -0700 (PDT)
	(envelope-from m@isrv.tric.tomsk.gov.ru)
Received: from isrv.tric.tomsk.gov.ru (localhost [127.0.0.1])
	by isrv.tric.tomsk.gov.ru (8.12.9/8.12.9) with ESMTP id h37I1XKx096546
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 8 Apr 2003 01:01:33 +0700 (NOVST)
	(envelope-from m@isrv.tric.tomsk.gov.ru)
Received: (from root@localhost)
	by isrv.tric.tomsk.gov.ru (8.12.9/8.12.9/Submit) id h37I1X7c096545;
	Tue, 8 Apr 2003 01:01:33 +0700 (NOVST)
	(envelope-from m)
Message-Id: <200304071801.h37I1X7c096545@isrv.tric.tomsk.gov.ru>
Date: Tue, 8 Apr 2003 01:01:33 +0700 (NOVST)
From: Mike Boev <mike@tric.tomsk.gov.ru>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] www/apache13-modssl fails to install
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50688
>Category:       ports
>Synopsis:       [PATCH] www/apache13-modssl fails to install
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 07 11:10:05 PDT 2003
>Closed-Date:    Mon Apr 07 20:33:27 CEST 2003
>Last-Modified:  Mon Apr 07 20:33:27 CEST 2003
>Originator:     Mike Boev <mike@tric.tomsk.gov.ru>
>Release:        FreeBSD 4.8-RC i386
>Organization:
Tomsk Regional Information Center
>Environment:
System: FreeBSD isrv.tric.tomsk.gov.ru 4.8-RC FreeBSD 4.8-RC #2: Mon Mar 31 11:20:55 NOVST 2003 root@isrv.tric.tomsk.gov.ru:/usr/obj/srv/FreeBSD/src/sys/ISRV i386

A fresh checkout of the port, currently Makefile at v 1.118 2003/04/03 19:39:15 dinoe
x

>Description:
	Installation of the port fails at the pre-install stage
when it tries to execute the pkg-install script.
The script resides in the ports tree and but not in the WRKDIR

>How-To-Repeat:
	cd /usr/ports/www/apache13-modssl
	make
	make install
	<breaks here>
>Fix:
	We can use the (standard?) technique of executing pkg-install by 
referencing it indirectly (through $PKGINSTALL macro), as is done in
net/cvsupit, for example

please, find the patch that makes that change:

--- www/apache13-modssl/Makefile.orig   Tue Apr  8 00:30:22 2003
+++ www/apache13-modssl/Makefile        Tue Apr  8 00:43:17 2003
@@ -147,7 +147,7 @@
        && ${MAKE} certificate TYPE=${TYPE} CRT=${CRT} KEY=${KEY}

 pre-install:
-       PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL
+       @PKG_PREFIX=${PREFIX} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL

 post-install:
        ${INSTALL_DATA} ${WRKSRC}/apache.sh ${PREFIX}/etc/rc.d/apache.sh-dist
>Release-Note:
>Audit-Trail:

From: "Michael O. Boev" <mike@tric.tomsk.gov.ru>
To: <freebsd-gnats-submit@FreeBSD.org>,
	"Michael O. Boev" <mike@tric.tomsk.gov.ru>
Cc:  
Subject: Re: ports/50688: [PATCH] www/apache13-modssl fails to install
Date: Tue, 8 Apr 2003 01:27:54 +0700

 It is also doubtable whether this script needs the PKG_PREFIX defined.
 
 So, I'd suggest the second version of the patch:
 
  --- www/apache13-modssl/Makefile.orig   Tue Apr  8 00:30:22 2003
 +++ www/apache13-modssl/Makefile        Tue Apr  8 00:43:17 2003
 @@ -147,7 +147,7 @@
         && ${MAKE} certificate TYPE=${TYPE} CRT=${CRT} KEY=${KEY}
 
  pre-install:
 -       PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL
 +       @${PKGINSTALL} ${PKGNAME} PRE-INSTALL
 
  post-install:
         ${INSTALL_DATA} ${WRKSRC}/apache.sh
 ${PREFIX}/etc/rc.d/apache.sh-dist
 
 Best wishes,
 Mike Boev.
 
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Mon Apr 7 20:31:07 CEST 2003 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50688 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Mon Apr 7 20:33:15 CEST 2003 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50688 
>Unformatted:
