From ast@marabu.ch  Tue Mar 18 10:08:08 2003
Return-Path: <ast@marabu.ch>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0743D37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Mar 2003 10:08:08 -0800 (PST)
Received: from oneplusone.ch (oneplusone.ch [212.55.208.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1D20143FA3
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Mar 2003 10:08:06 -0800 (PST)
	(envelope-from ast@marabu.ch)
Received: from oneplusone.ch (localhost [127.0.0.1])
	by oneplusone.ch (8.12.6/8.12.3) with ESMTP id h2II83LP027978
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Mar 2003 19:08:03 +0100 (MET)
	(envelope-from ast@marabu.ch)
Received: (from uucp@localhost)
	by oneplusone.ch (8.12.6/8.12.3/Submit) with UUCP id h2II82YE027977
	for FreeBSD-gnats-submit@freebsd.org; Tue, 18 Mar 2003 19:08:02 +0100 (MET)
Received: (from ast@localhost)
	by marabu.ch (8.11.6/8.11.6) id h2II3w674184;
	Tue, 18 Mar 2003 19:03:58 +0100 (MET)
	(envelope-from ast)
Message-Id: <200303181803.h2II3w674184@marabu.ch>
Date: Tue, 18 Mar 2003 19:03:58 +0100 (MET)
From: Adrian Steinmann <ast@marabu.ch>
Reply-To: Adrian Steinmann <ast@marabu.ch>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Re: make release failure in ports/textproc/jade
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50103
>Category:       ports
>Synopsis:       Re: make release failure in ports/textproc/jade
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 18 10:10:11 PST 2003
>Closed-Date:    Sat Apr 12 18:43:24 PDT 2003
>Last-Modified:  Sat Apr 12 18:43:24 PDT 2003
>Originator:     Adrian Steinmann
>Release:        FreeBSD 4.7-STYX i386
>Organization:
Webgroup Consulting AG
>Environment:
System: FreeBSD sano.marabu.ch 4.7-STYX FreeBSD 4.7-STYX #0: Sat Mar 15 16:40:17 CET 2003 root@rumori.com:/usr/src/sys/compile/STYX i386
>Description:

make release CHROOTDIR=... CVSROOT=... RELEASETAG=RELENG_4
fails with cvsup date 2003/03/17UTC while building docs.

jade has USE_LIBTOOL in it's Makefile, but it configures itself
*before* it goes and builds libtool, so when 'make jade' finally
comes back (after it installs the prerequisites expat, iconv,
gettext, and gmake) the patch-libtool target has already run (a
no-op in this case) because it's in the _CONFIGURE_SEQ (see
usr/ports/Mk/bsd.port.mk) and the ltconfig path is of course not
patched, hence /ltconfig.

>How-To-Repeat:

You can observe this by doing a chroot into the CHROOTDIR hierarchy,
cd /usr/ports/textproc/jade, rm work/.config*; make configure which
lo' and behold will *not* fail. If you then 'pkg_delete -x libtool',
then 'make configure' will fail again.

>Fix:

I've fixed this locally by forcing USE_LIBTOOL to create a *PATCH*
dependancy instead of a BUILD dependancy (it is actually a CONFIGURE
dependancy, but we have no such hooks) in bsd.port.mk:

Index: bsd.port.mk
===================================================================
RCS file: /usr/cvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.442
diff -u -r1.442 bsd.port.mk
--- bsd.port.mk	12 Mar 2003 00:28:17 -0000	1.442
+++ bsd.port.mk	18 Mar 2003 17:37:20 -0000
@@ -1226,7 +1226,7 @@
 
 .if defined(USE_LIBTOOL)
 GNU_CONFIGURE=	yes
-BUILD_DEPENDS+=		libtool:${PORTSDIR}/devel/libtool
+PATCH_DEPENDS+=		libtool:${PORTSDIR}/devel/libtool
 .if defined(USE_AUTOCONF)
 LIBTOOLFILES?=		aclocal.m4
 .else

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: nork 
Responsible-Changed-When: Wed Mar 19 08:15:58 PST 2003 
Responsible-Changed-Why:  
Over to maintainer.  Because of problem of bsd.port.mk. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50103 
State-Changed-From-To: open->closed 
State-Changed-By: kris 
State-Changed-When: Sat Apr 12 18:43:10 PDT 2003 
State-Changed-Why:  
This was fixed just prior to 4.8-R 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50103 
>Unformatted:
