From chris@Shenton.Org  Sun Mar  2 06:57:22 2003
Return-Path: <chris@Shenton.Org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EBA0037B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 Mar 2003 06:57:22 -0800 (PST)
Received: from Shenton.org (23.ebbed1.client.atlantech.net [209.190.235.35])
	by mx1.FreeBSD.org (Postfix) with SMTP id 861BB43FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 Mar 2003 06:57:19 -0800 (PST)
	(envelope-from chris@Shenton.Org)
Received: (qmail 40855 invoked by uid 1000); 2 Mar 2003 14:57:18 -0000
Message-Id: <20030302145718.40854.qmail@PECTOPAH.shenton.org>
Date: 2 Mar 2003 14:57:18 -0000
From: Chris Shenton <chris@Shenton.Org>
Reply-To: Chris Shenton <chris@Shenton.Org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: math/guppi 0.40.3_2 compile fails, syntax error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48839
>Category:       ports
>Synopsis:       math/guppi 0.40.3_2 compile fails, syntax error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 02 07:00:23 PST 2003
>Closed-Date:    Tue Apr 01 19:33:53 PST 2003
>Last-Modified:  Tue Apr 01 19:33:53 PST 2003
>Originator:     Chris Shenton
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD Pectopah.shenton.org 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Wed Feb 19 17:08:39 EST 2003 chris@Pectopah.shenton.org:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
	Compile fails with syntax error in source code.

>How-To-Repeat:

cd /usr/ports/math/guppi/
make
===>  Extracting for guppi-0.40.3_2
>Fix:

Don't know, that line looks pretty innocuous:

  double INFINITY = 1.79769313486231570815E308; /* 2**1024*(1-MACHEP) */

And I don't see any "float" nearby. :-(


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: arved 
Responsible-Changed-When: Mon Mar 3 15:20:19 PST 2003 
Responsible-Changed-Why:  
Over to Maintainers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48839 

From: Heath Nielson <heath@cs.byu.edu>
To: freebsd-gnats-submit@FreeBSD.org, chris@Shenton.Org
Cc:  
Subject: Re: ports/48839: math/guppi 0.40.3_2 compile fails, syntax error
Date: Wed, 12 Mar 2003 00:08:07 -0700

 I ran into the exact same problem.  It looks like this problem is caused 
 because INFINITY is defined in /usr/include/math.h.  It looks like it was 
 added in rev 1.21 (about a month ago).  I just commented out the block with 
 the following patch:
 
 --- src/libguppispecfns/const.c.orig    Tue Mar 11 23:33:38 2003
 +++ src/libguppispecfns/const.c Tue Mar 11 23:34:02 2003
 @@ -93,10 +93,12 @@
  double LOGSQ2 = 3.46573590279972654709E-1;     /* log(2)/2 */
  double THPIO4 = 2.35619449019234492885;        /* 3*pi/4 */
  double TWOOPI = 6.36619772367581343075535E-1;  /* 2/pi */
 +#if 0
  #ifdef INFINITIES
  double INFINITY = 1.0 / 0.0;   /* 99e999; */
  #else
  double INFINITY = 1.79769313486231570815E308;  /* 2**1024*(1-MACHEP) */
 +#endif
  #endif
 
  #ifdef MINUSZERO
 
 
 I don't know if using the #defined value in math.h will break Guppi or not, 
 but at least it now compiles :).  This problem only occurs CURRENT because 
 STABLE's math.h doesn't define INFINITY.
 
 Heath
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Tue Apr 1 19:33:37 PST 2003 
State-Changed-Why:  
This should now be fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48839 
>Unformatted:
 >> Checksum OK for Guppi-0.40.3.tar.gz.
 ===>  Patching for guppi-0.40.3_2
 ===>  Applying FreeBSD patches for guppi-0.40.3_2
 ===>  Configuring for guppi-0.40.3_2
 ...
 cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I/usr/X11R6/include
 -I../.. -I../../src/libguppiuseful -I/usr/X11R6/include/gtk12
 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -I/usr/X11R6/include/gnome-1.0
 -I/usr/X11R6/include -DNEED_GNOMESUPPORT_H -I/usr/X11R6/lib/gnome-libs/include
 -I/usr/local/include/glib12 -I/usr/local/include/orbit-1.0 -I/usr/local/include
 -I/usr/X11R6/include/gtk12 -I/usr/local/include/gnome-xml
 -I/usr/X11R6/include/libglade-1.0 -I/usr/X11R6/include/gnome-1.0 -I/usr/X11R6/include
 -DNEED_GNOMESUPPORT_H -I/usr/X11R6/lib/gnome-libs/include -I/usr/local/include/glib12
 -I/usr/local/include/orbit-1.0 -I/usr/local/include -I/usr/X11R6/include/gtk12
 -I/usr/X11R6/include/gnome-1.0 -I/usr/local/include/freetype2 -I/usr/local/include
 -I/usr/X11R6/include -DNEED_GNOMESUPPORT_H -I/usr/X11R6/lib/gnome-libs/include
 -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12
 -I/usr/X11R6/include/gdk-pixbuf-1.0 -I/usr/local/include/gnome-xml -I/usr/X11R6/include/gdk-pixbuf-1.0
 -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include
 -I/usr/X11R6/include -I/usr/local/include/glib12 -I/usr/local/include/orbit-1.0
 -I/usr/local/include -I/usr/X11R6/include/gnome-1.0 -I/usr/X11R6/include
 -DNEED_GNOMESUPPORT_H -I/usr/X11R6/lib/gnome-libs/include -I/usr/X11R6/include/gtk12
 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include/gdk-pixbuf-1.0
 -I/usr/local/include/freetype2 -I/usr/local/include/gnome-xml
 -I/usr/local/include/orbit-1.0 -DG_LOG_DOMAIN=\"libguppispecfns\" -I/usr/local/include
 -I/usr/X11R6/include/libglade-1.0 -I/usr/X11R6/include/gtk12
 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -O -pipe -mcpu=pentiumpro -Wall
 -Wunused -c const.c  -fPIC -DPIC -o const.o
 const.c:99: syntax error before "float"
 gmake[3]: *** [const.lo] Error 1
 gmake[3]: Leaving directory
 `/usr/local/ports/math/guppi/work/Guppi-0.40.3/src/libguppispecfns'
 gmake[2]: *** [all-recursive] Error 1
 gmake[2]: Leaving directory
 `/usr/local/ports/math/guppi/work/Guppi-0.40.3/src'
 gmake[1]: *** [all-recursive] Error 1
 gmake[1]: Leaving directory
 `/usr/local/ports/math/guppi/work/Guppi-0.40.3'
 gmake: *** [all-recursive-am] Error 2
 *** Error code 2
 
