From kawata@mta.biglobe.ne.jp  Mon Feb 24 07:51:24 2003
Return-Path: <kawata@mta.biglobe.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4A51637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Feb 2003 07:51:24 -0800 (PST)
Received: from rcpt-expgw.biglobe.ne.jp (rcpt-expgw.biglobe.ne.jp [202.225.89.154])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0205E43F75
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Feb 2003 07:51:23 -0800 (PST)
	(envelope-from kawata@mta.biglobe.ne.jp)
Received: from smtp-gw.biglobe.ne.jp
	by rcpt-expgw.biglobe.ne.jp (mnmy/5508310702) with ESMTP id h1OFpMK16322
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Feb 2003 00:51:22 +0900 (JST)
Received: from figo (202.225.164.62 [202.225.164.62]) by smtp-gw.biglobe.ne.jp
	id AAVIC0A826A6; Tue, 25 Feb 2003 00:51:21 +0900 (JST)
Message-Id: <20030225005633.59FB.KAWATA@mta.biglobe.ne.jp>
Date: Tue, 25 Feb 2003 00:56:42 +0900
From: KAWATA Masahiko <kawata@mta.biglobe.ne.jp>
Reply-To: kawata@mta.biglobe.ne.jp
To: FreeBSD-gnats-submit@freebsd.org
Subject: Build options in Makefile.local are ignored
X-Send-Pr-Version: 3.113

>Number:         48636
>Category:       ports
>Synopsis:       Build options in Makefile.local are ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kris
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 24 08:00:27 PST 2003
>Closed-Date:    Mon Jul 28 01:45:21 PDT 2003
>Last-Modified:  Mon Jul 28 01:50:04 PDT 2003
>Originator:     KAWATA Masahiko
>Release:        FreeBSD 4.7-STABLEE i386
>Organization:
>Environment:
	FreeBSD coco 4.7-STABLE FreeBSD 4.7-STABLE #28: Fri Feb 21 18:30:35 JST 2003     kawata:/usr/src/sys/compile/COCO  i386

>Description:
	To specify local build options, I use Makefile.local instead of
	command line. In many other ports this way is effective but it's
	ignored in sane-backends port.

>How-To-Repeat:
	[/usr/ports/graphics/sane-backends]% cat Makefile.local
	WITH_GPHOTO2=yes
	[/usr/ports/graphics/sane-backends]% make

>Fix:
	Use <bsd.port.(pre|post).mk> instead of <bsd.port.mk>
--------
# diff -u Makefile.orig Makefile
--- Makefile.orig	Wed Feb 19 12:15:25 2003
+++ Makefile	Mon Feb 24 19:13:24 2003
@@ -28,6 +28,8 @@
 MAKE_ENV=	NOPORTDOCS=${NOPORTDOCS}
 INSTALLS_SHLIB=	yes
 
+.include <bsd.port.pre.mk>
+
 .if defined(WITH_GPHOTO2)
 LIB_DEPENDS+=	gphoto2.2:${PORTSDIR}/graphics/gphoto2
 CONFIGURE_ARGS+=	--with-gphoto2=yes
@@ -49,4 +51,4 @@
 		 s|gphoto2 2.0.1|gphoto2 2.0|g' ${WRKSRC}/configure
 
 .include "Makefile.man"
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: kris 
State-Changed-When: Wed Jul 23 05:03:24 PDT 2003 
State-Changed-Why:  
This may have been fixed in r1.455 of bsd.port.mk.  Can you 
please confirm? 


Responsible-Changed-From-To: freebsd-ports-bugs->kris 
Responsible-Changed-By: kris 
Responsible-Changed-When: Wed Jul 23 05:03:24 PDT 2003 
Responsible-Changed-Why:  
I'm following this up. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48636 
State-Changed-From-To: feedback->closed 
State-Changed-By: kris 
State-Changed-When: Mon Jul 28 01:45:08 PDT 2003 
State-Changed-Why:  
Submitter confirms problem has been resolved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48636 

From: Kris Kennaway <kris@obsecurity.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/48636: Build options in Makefile.local are ignored
Date: Mon, 28 Jul 2003 01:45:00 -0700

 ----- Forwarded message from "?$B@nED ?$B2mI'" <kawata@mta.biglobe.ne.jp> -----
 
 X-Original-To: kkenn@localhost
 Delivered-To: kkenn@localhost.obsecurity.org
 Delivered-To: kris@freebsd.org
 X-Biglobe-Sender: <kawata@mta.biglobe.ne.jp>
 Date: Mon, 28 Jul 2003 15:38:23 +0900
 From: ?$B@nED ?$B2mI' <kawata@mta.biglobe.ne.jp>
 To: Kris Kennaway <kris@FreeBSD.org>, freebsd-ports-bugs@FreeBSD.org
 Subject: Re: ports/48636: Build options in Makefile.local are ignored
 In-Reply-To: <200307231204.h6NC4RvN045052@freefall.freebsd.org>
 X-Face: 3y}9uu'!/huBf$/$!{,:%>rU"Y.XLR*]L!coJ*0MJ8V@|vT>,~P2oaJd6qpYn,:$UG-H%Lj L4Z}XB%D8#BIksDEAEcu-2#YS?>DXZjyZ$;#r6flA_rK}ja0>ah_~q.M=Up5U$L)8=)s#:sBG68MzJ 3@zf=.hDr.TrswfVS-P5f.S+(
 X-Mailer: Becky! ver. 2.05.10
 X-UIDL: 74573a6bfd8d5cb3b010b842cf8bfe1c
 X-Bogosity: No, tests=bogofilter, spamicity=0.000042, version=0.13.7.2
 
 > Synopsis: Build options in Makefile.local are ignored
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: kris
 > State-Changed-When: Wed Jul 23 05:03:24 PDT 2003
 > State-Changed-Why: 
 > This may have been fixed in r1.455 of bsd.port.mk.  Can you
 > please confirm?
 
 My PR has been fixed in r1.47 of graphics/sane-backends/Makefile.
 
 Thanks.
 
 
 ----- End forwarded message -----
>Unformatted:
 SEND-PR: -*- send-pr -*-
 SEND-PR: Lines starting with `SEND-PR' will be removed automatically, as
 SEND-PR: will all comments (text enclosed in `<' and `>').
 SEND-PR:
 SEND-PR: Please consult the following URL if you are not sure how to
 SEND-PR: fill out a problem report:
 SEND-PR: http://www.freebsd.org/doc/en/articles/problem-reports/article.html
 SEND-PR:
 SEND-PR: Note that the Synopsis field is mandatory.
 SEND-PR:
 SEND-PR: Please note that (unless you state otherwise) if your report 
 SEND-PR: includes a patch then it will be taken under the same license as 
 SEND-PR: the one on the file(s) you want to change.
 SEND-PR:
 SEND-PR: BE ADVISED THAT FREEBSD PROBLEM REPORTS ARE PUBLIC INFORMATION AND
 SEND-PR: WILL BE PUBLISHED AS-IS ON THE PROJECT'S MAILING LISTS AND WEB SITES.
 SEND-PR: DO NOT SUBMIT ANY INFORMATION YOU DO NOT WANT MADE PUBLIC.
 SEND-PR:
 SEND-PR: For sensitive security issues, consider contacting the FreeBSD
 SEND-PR: security officer team (security-officer@freebsd.org) directly.
 SEND-PR:
 SEND-PR: Choose from the following categories:
 SEND-PR:
 SEND-PR: advocacy  alpha     bin       conf      docs      gnu       
 SEND-PR: i386      ia64      java      kern      misc      ports     
 SEND-PR: powerpc   sparc64   standards www       
 SEND-PR:
