From alane@wwweasel.geeksrus.net  Wed Feb 19 00:24:56 2003
Return-Path: <alane@wwweasel.geeksrus.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BF53C37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Feb 2003 00:24:56 -0800 (PST)
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 072A743F85
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Feb 2003 00:24:56 -0800 (PST)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: from wwweasel.geeksrus.net (localhost [127.0.0.1])
	by wwweasel.geeksrus.net (8.12.7/8.12.6) with ESMTP id h1J8OGh6033916
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Feb 2003 03:24:16 -0500 (EST)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: (from root@localhost)
	by wwweasel.geeksrus.net (8.12.7/8.12.6/Submit) id h1J8OE9v033671;
	Wed, 19 Feb 2003 03:24:14 -0500 (EST)
	(envelope-from alane)
Message-Id: <200302190824.h1J8OE9v033671@wwweasel.geeksrus.net>
Date: Wed, 19 Feb 2003 03:24:14 -0500 (EST)
From: Alan Eldridge <alane@freebsd.org>
Reply-To: Alan Eldridge <alane@geeksrus.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: irc/xchat2: PLIST_SUBS overwrites itself so port won't package
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48451
>Category:       ports
>Synopsis:       irc/xchat2: PLIST_SUBS overwrites itself so port won't package
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 19 00:30:03 PST 2003
>Closed-Date:    Wed Feb 19 00:33:32 PST 2003
>Last-Modified:  Wed Feb 19 00:33:32 PST 2003
>Originator:     Alan Eldridge
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.7-STABLE FreeBSD 4.7-STABLE #0: Sat Feb 15 04:01:53 EST 2003 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/VROOM i386


>Description:

PLIST_SUB= used where it should be += so substitutions are overwitten
by later ones.

>How-To-Repeat:
>Fix:


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/irc/xchat2/Makefile,v
retrieving revision 1.108
diff -d -U4 -r1.108 Makefile
--- Makefile	18 Feb 2003 20:30:17 -0000	1.108
+++ Makefile	19 Feb 2003 08:17:56 -0000
@@ -42,12 +42,12 @@
 
 .if defined(WITH_PYTHON)
 USE_PYTHON=    yes
 CONFIGURE_ARGS+=	--enable-python
-PLIST_SUB=	PYTHON=""
+PLIST_SUB+=	PYTHON=""
 .else
 CONFIGURE_ARGS+=	--disable-python
-PLIST_SUB=	PYTHON="@comment "
+PLIST_SUB+=	PYTHON="@comment "
 .endif
 
 .if defined(WITH_TCL)
 LIB_DEPENDS=    tcl83.1:${PORTSDIR}/lang/tcl83
@@ -55,12 +55,12 @@
 CONFIGURE_ENV=  CPPFLAGS="-I${LOCALBASE}/include ${PTHREAD_CFLAGS} \
 		-I${LOCALBASE}/include/tcl8.3" \
 		LIBS="-L${LOCALBASE}/lib ${PTHREAD_LIBS} \
 		-L${LOCALBASE}/lib/tcl8.3"
-PLIST_SUB=	TCL=""
+PLIST_SUB+=	TCL=""
 .else
 CONFIGURE_ARGS+=	--enable-tcl=no
-PLIST_SUB=	TCL="@comment "
+PLIST_SUB+=	TCL="@comment "
 .endif
 
 pre-everything::
 .if !defined(WITH_PYTHON) || !defined(WITH_SOCKS) || !defined(WITH_TCL)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Wed Feb 19 00:33:11 PST 2003 
State-Changed-Why:  
Doh!  Thanks for catching this, Alan. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48451 
>Unformatted:
