From kirk@kanga.honeypot.net  Fri Feb  7 10:35:48 2003
Return-Path: <kirk@kanga.honeypot.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E02AD37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Feb 2003 10:35:47 -0800 (PST)
Received: from kanga.honeypot.net (kanga.honeypot.net [208.162.254.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CAEAA43FAF
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Feb 2003 10:35:46 -0800 (PST)
	(envelope-from kirk@kanga.honeypot.net)
Received: from kanga.honeypot.net (localhost [127.0.0.1])
	by kanga.honeypot.net (8.12.6/8.12.6) with ESMTP id h17IZj3v069024
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 7 Feb 2003 12:35:45 -0600 (CST)
	(envelope-from kirk@kanga.honeypot.net)
Received: (from kirk@localhost)
	by kanga.honeypot.net (8.12.6/8.12.6/Submit) id h17IZiot069023;
	Fri, 7 Feb 2003 12:35:44 -0600 (CST)
	(envelope-from kirk)
Message-Id: <200302071835.h17IZiot069023@kanga.honeypot.net>
Date: Fri, 7 Feb 2003 12:35:44 -0600 (CST)
From: Kirk Strauser <kirk@strauser.com>
Reply-To: Kirk Strauser <kirk@strauser.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Nitpicks for the comms/qpage port
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48059
>Category:       ports
>Synopsis:       Nitpicks for the comms/qpage port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 07 10:40:09 PST 2003
>Closed-Date:    Sat Jan 10 00:48:39 PST 2004
>Last-Modified:  Sat Jan 10 00:48:39 PST 2004
>Originator:     Kirk Strauser
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
The Strauser Group
>Environment:
System: FreeBSD kanga.honeypot.net 4.7-STABLE FreeBSD 4.7-STABLE #1: Sun Dec 8 16:52:58 CST 2002 root@kanga.honeypot.net:/usr/obj/usr/src/sys/HONEYPOT_KANGA i386


	
>Description:
	

The comms/qpage port has a few minor problems.  A default installation gives
the following errors when the /usr/local/etc/rc.d/qpage.sh script is
execute:

    qpage[68438]: cannot open /etc/qpage.cf: No such file or directory
    qpage[68438]: cannot access LockDir(/var/spool/lock): Permission denied
    qpage[68438]: cannot access QueueDir(/var/spool/qpage): No such file or directory
    qpage[68438]: cannot chdir to QueueDir(/var/spool/qpage): No such file or directory

In short:

1) qpage looks for its configuration file in /etc instead of /usr/local/etc
2) It setuid()'s to a user (daemon) without permission to access /var/spool/lock
but does not document this anywhere outside of the source.
3) It's queue directory is not created by installing the port.


>How-To-Repeat:
	

portinstall comms/qpage

>Fix:

	

1) Apply this patch (or something similar) to get qpage to look in /usr/local/etc .

########################################
    diff -u qpage-3.3-old/config.h.in qpage-3.3/config.h.in
    --- qpage-3.3-old/config.h.in   Sun Jul 26 14:38:35 1998
    +++ qpage-3.3/config.h.in       Fri Feb  7 12:31:54 2003
    @@ -17,7 +17,7 @@
     #undef SNPP_SERVER_FILE
    
     /* Define as the location of the qpage configuration file.  */
    -#define QPAGE_CONFIG "/etc/qpage.cf"
    +#define QPAGE_CONFIG "/usr/local/etc/qpage.cf"
    
     /* Define as the location of the lock directory.  */
     #undef DEFAULT_LOCKDIR
    diff -u qpage-3.3-old/config.input qpage-3.3/config.input
    --- qpage-3.3-old/config.input  Thu Nov  5 00:05:36 1998
    +++ qpage-3.3/config.input      Fri Feb  7 12:31:02 2003
    @@ -20,7 +20,7 @@
     # See the QuickPage documentation for complete details about
     # the syntax of the configuration file.
     #
    -QPAGE_CONFIG="/etc/qpage.cf"
    +QPAGE_CONFIG="/usr/local/etc/qpage.cf"
    
    
     #
    @@ -41,7 +41,7 @@
     # copies of the configuration file.  Only one filename
     # may be specified.
     #
    -SNPP_SERVER_FILE="/etc/qpage.servers"
    +SNPP_SERVER_FILE="/usr/local/etc/qpage.servers"
    
    
     #
    diff -u qpage-3.3-old/qpage.man qpage-3.3/qpage.man
    --- qpage-3.3-old/qpage.man     Sat May  8 17:07:31 1999
    +++ qpage-3.3/qpage.man Fri Feb  7 12:31:29 2003
    @@ -867,7 +867,7 @@
     must be able to detect when it's safe to send dial commands to the modem.
     .LP
     .SH FILES
    -/etc/qpage.cf
    +/usr/local/etc/qpage.cf
     .SH SEE ALSO
     .B RFC-1861
     .SH KNOWN BUGS
    diff -u qpage-3.3-old/qpage.ps qpage-3.3/qpage.ps
    --- qpage-3.3-old/qpage.ps      Sat May  8 17:07:49 1999
    +++ qpage-3.3/qpage.ps  Fri Feb  7 12:32:21 2003
    @@ -1312,7 +1312,7 @@
     9 B f
     (FILES)720 1368 w
     10 R f
    -(/etc/qpage.cf)1080 1488 w
    +(/usr/local/etc/qpage.cf)1080 1488 w
     9 B f
     (SEE ALSO)1 460 1 720 1656 t
     10 B f
########################################

2) Create a user for qpage and add it to the `dialer' group.
3) Create /var/spool/qpage with appropriate permissions (and delete it upon
uninstalling).

>Release-Note:
>Audit-Trail:

From: Peter Pentchev <roam@ringlet.net>
To: Kirk Strauser <kirk@strauser.com>
Cc: Joe Stein <joes@seaport.net>, bug-followup@FreeBSD.org
Subject: Re: ports/48059: Nitpicks for the comms/qpage port
Date: Fri, 21 Feb 2003 10:45:38 +0200

 Hi,
 
 Is Joe Stein <joes@seaport.net>, the comms/qpage port maintainer,
 aware of this problem report?
 
 G'luck,
 Peter
 
 -- 
 Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 This inert sentence is my body, but my soul is alive, dancing in the sparks of your brain.
 
 On Fri, Feb 07, 2003 at 12:35:44PM -0600, Kirk Strauser wrote:
 > 
 > >Number:         48059
 > >Category:       ports
 > >Synopsis:       Nitpicks for the comms/qpage port
 > >Originator:     Kirk Strauser
 > >Release:        FreeBSD 4.7-STABLE i386
 > >Organization:
 > The Strauser Group
 > >Environment:
 > System: FreeBSD kanga.honeypot.net 4.7-STABLE FreeBSD 4.7-STABLE #1: Sun Dec 8 16:52:58 CST 2002 root@kanga.honeypot.net:/usr/obj/usr/src/sys/HONEYPOT_KANGA i386
 > 
 > 
 > 	
 > >Description:
 > 	
 > 
 > The comms/qpage port has a few minor problems.  A default installation gives
 > the following errors when the /usr/local/etc/rc.d/qpage.sh script is
 > execute:
 > 
 >     qpage[68438]: cannot open /etc/qpage.cf: No such file or directory
 >     qpage[68438]: cannot access LockDir(/var/spool/lock): Permission denied
 >     qpage[68438]: cannot access QueueDir(/var/spool/qpage): No such file or directory
 >     qpage[68438]: cannot chdir to QueueDir(/var/spool/qpage): No such file or directory
 > 
 > In short:
 > 
 > 1) qpage looks for its configuration file in /etc instead of /usr/local/etc
 > 2) It setuid()'s to a user (daemon) without permission to access /var/spool/lock
 > but does not document this anywhere outside of the source.
 > 3) It's queue directory is not created by installing the port.
 > 
 > 
 > >How-To-Repeat:
 > 	
 > 
 > portinstall comms/qpage
 > 
 > >Fix:
 > 
 > 	
 > 
 > 1) Apply this patch (or something similar) to get qpage to look in /usr/local/etc .
 > 
 > ########################################
 >     diff -u qpage-3.3-old/config.h.in qpage-3.3/config.h.in
 >     --- qpage-3.3-old/config.h.in   Sun Jul 26 14:38:35 1998
 >     +++ qpage-3.3/config.h.in       Fri Feb  7 12:31:54 2003
 >     @@ -17,7 +17,7 @@
 >      #undef SNPP_SERVER_FILE
 >     
 >      /* Define as the location of the qpage configuration file.  */
 >     -#define QPAGE_CONFIG "/etc/qpage.cf"
 >     +#define QPAGE_CONFIG "/usr/local/etc/qpage.cf"
 >     
 >      /* Define as the location of the lock directory.  */
 >      #undef DEFAULT_LOCKDIR
 >     diff -u qpage-3.3-old/config.input qpage-3.3/config.input
 >     --- qpage-3.3-old/config.input  Thu Nov  5 00:05:36 1998
 >     +++ qpage-3.3/config.input      Fri Feb  7 12:31:02 2003
 >     @@ -20,7 +20,7 @@
 >      # See the QuickPage documentation for complete details about
 >      # the syntax of the configuration file.
 >      #
 >     -QPAGE_CONFIG="/etc/qpage.cf"
 >     +QPAGE_CONFIG="/usr/local/etc/qpage.cf"
 >     
 >     
 >      #
 >     @@ -41,7 +41,7 @@
 >      # copies of the configuration file.  Only one filename
 >      # may be specified.
 >      #
 >     -SNPP_SERVER_FILE="/etc/qpage.servers"
 >     +SNPP_SERVER_FILE="/usr/local/etc/qpage.servers"
 >     
 >     
 >      #
 >     diff -u qpage-3.3-old/qpage.man qpage-3.3/qpage.man
 >     --- qpage-3.3-old/qpage.man     Sat May  8 17:07:31 1999
 >     +++ qpage-3.3/qpage.man Fri Feb  7 12:31:29 2003
 >     @@ -867,7 +867,7 @@
 >      must be able to detect when it's safe to send dial commands to the modem.
 >      .LP
 >      .SH FILES
 >     -/etc/qpage.cf
 >     +/usr/local/etc/qpage.cf
 >      .SH SEE ALSO
 >      .B RFC-1861
 >      .SH KNOWN BUGS
 >     diff -u qpage-3.3-old/qpage.ps qpage-3.3/qpage.ps
 >     --- qpage-3.3-old/qpage.ps      Sat May  8 17:07:49 1999
 >     +++ qpage-3.3/qpage.ps  Fri Feb  7 12:32:21 2003
 >     @@ -1312,7 +1312,7 @@
 >      9 B f
 >      (FILES)720 1368 w
 >      10 R f
 >     -(/etc/qpage.cf)1080 1488 w
 >     +(/usr/local/etc/qpage.cf)1080 1488 w
 >      9 B f
 >      (SEE ALSO)1 460 1 720 1656 t
 >      10 B f
 > ########################################
 > 
 > 2) Create a user for qpage and add it to the `dialer' group.
 > 3) Create /var/spool/qpage with appropriate permissions (and delete it upon
 > uninstalling).
 > 
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-ports-bugs" in the body of the message
 > 
State-Changed-From-To: open->analyzed 
State-Changed-By: roam 
State-Changed-When: Fri Feb 21 01:05:22 PST 2003 
State-Changed-Why:  
I'll take care of this one. 


Responsible-Changed-From-To: freebsd-ports-bugs->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Fri Feb 21 01:05:22 PST 2003 
Responsible-Changed-Why:  
I'll take care of this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48059 
State-Changed-From-To: analyzed->open 
State-Changed-By: pav 
State-Changed-When: Fri Jan 2 07:43:23 PST 2004 
State-Changed-Why:  
This port is no longer maintained. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48059 
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Sat Jan 10 00:48:35 PST 2004 
State-Changed-Why:  
Commited, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48059 
>Unformatted:
