From jear@eden.squad.dk  Fri Jan 31 04:00:02 2003
Return-Path: <jear@eden.squad.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DF53C37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 31 Jan 2003 04:00:01 -0800 (PST)
Received: from eden.squad.dk (geek.squad.dk [80.162.145.90])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 90F6243F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 31 Jan 2003 04:00:00 -0800 (PST)
	(envelope-from jear@eden.squad.dk)
Received: from eden.squad.dk (localhost [127.0.0.1])
	by eden.squad.dk (8.12.6/8.12.5) with ESMTP id h0VBxvGt047160;
	Fri, 31 Jan 2003 12:59:57 +0100 (CET)
	(envelope-from jear@eden.squad.dk)
Received: (from jear@localhost)
	by eden.squad.dk (8.12.6/8.12.5/Submit) id h0VBxvgo047159;
	Fri, 31 Jan 2003 12:59:57 +0100 (CET)
Message-Id: <200301311159.h0VBxvgo047159@eden.squad.dk>
Date: Fri, 31 Jan 2003 12:59:57 +0100 (CET)
From: Jens Arnfast <jens@arnfast.net>
Reply-To: Jens Arnfast <jens@arnfast.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jens@arnfast.net
Subject: New port: evilbar - minimalistic statusbar with XMMS control, APM status and clock
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         47729
>Category:       ports
>Synopsis:       New port: evilbar - minimalistic statusbar with XMMS control, APM status and clock
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 31 04:00:23 PST 2003
>Closed-Date:    Thu Feb 13 04:42:57 PST 2003
>Last-Modified:  Thu Feb 13 04:42:57 PST 2003
>Originator:     Jens Arnfast <jens@arnfast.net>
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
>Environment:
System: FreeBSD eden.squad.dk 4.7-STABLE FreeBSD 4.7-STABLE #1: Sat Dec 21 23:22:10 CET 2002 r00t@eden.squad.dk:/usr/obj/usr/src/sys/EDEN i386

	
>Description:
evilbar is a minimalist statusbar originally  designed  to suit the simplistic window manager evilwm.
It contains the most essential tools for the desktop - a clock, XMMS  control and optionally APM status.
Using keyboard controls it is possible to control the most commonly used functions of XMMS.
	
>How-To-Repeat:
	
>Fix:
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#       evilbar
#       evilbar/pkg-plist
#       evilbar/pkg-descr
#       evilbar/pkg-comment
#       evilbar/distinfo
#       evilbar/Makefile
#
echo c - evilbar
mkdir -p evilbar > /dev/null 2>&1
echo x - evilbar/pkg-plist
sed 's/^X//' >evilbar/pkg-plist << 'END-of-evilbar/pkg-plist'
Xbin/evilbar
Xbin/launch_evilbar
Xman/man1/evilbar.1
Xman/man1/launch_evilbar.1
END-of-evilbar/pkg-plist
echo x - evilbar/pkg-descr
sed 's/^X//' >evilbar/pkg-descr << 'END-of-evilbar/pkg-descr'
Xevilbar is a minimalistic ncurses-based statusbar
Xwith XMMS control, APM status and a clock.
X
XWWW: http://arnfast.net/evilbar/
X
X-- Jens Arnfast <jens@arnfast.net>
END-of-evilbar/pkg-descr
echo x - evilbar/pkg-comment
sed 's/^X//' >evilbar/pkg-comment << 'END-of-evilbar/pkg-comment'
XMinimalistic statusbar with XMMS control, APM status and clock
END-of-evilbar/pkg-comment
echo x - evilbar/distinfo
sed 's/^X//' >evilbar/distinfo << 'END-of-evilbar/distinfo'
XMD5 (evilbar-1.2.0.tar.gz) = 8c99e3617adc277bb65471fbf2f579cb
END-of-evilbar/distinfo
echo x - evilbar/Makefile
sed 's/^X//' >evilbar/Makefile << 'END-of-evilbar/Makefile'
X# New ports collection makefile for:    evilbar
X# Date created:                         31 Januar 2003
X# Whom:                                 Jens Arnfast <jens@arnfast.net>
X#
X# $FreeBSD$
X#
X
XPORTNAME=      evilbar
XPORTVERSION=   1.2.0
XCATEGORIES+=   audio sysutils x11-clocks
XMASTER_SITES=  http://arnfast.net/projects/
X
XMAINTAINER?=   jens@arnfast.net
X
XBUILD_DEPENDS=  xmms:${PORTSDIR}/multimedia/xmms
XRUN_DEPENDS=    xmms:${PORTSDIR}/multimedia/xmms
X
XHAS_CONFIGURE=  yes
X
X.include <bsd.port.pre.mk>
X
X.if defined(WITHOUT_XMMS)
XCONFIGURE_ARGS+=       --disable-xxms
X.endif
X
X.if defined(WITH_APM)
XCONFIGURE_ARGS+=       --enable-apm
X.endif
X
Xpre-extract:
X.if !defined(WITHOUT_XMMS)
X       @${ECHO_MSG}
X       @${ECHO_MSG} "You can disable XMMS control by defining WITHOUT_XMMS."
X.endif
X.if !defined(WITH_APM)
X       @${ECHO_MSG}
X       @${ECHO_MSG} "You can enable APM status by defining WITH_APM."
X.endif
X       @${ECHO_MSG}
X
X.include <bsd.port.post.mk>
END-of-evilbar/Makefile
exit



>Release-Note:
>Audit-Trail:

From: Jens Arnfast <jens@arnfast.net>
To: freebsd-gnats-submit@FreeBSD.org, jens@arnfast.net
Cc:  
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with
 XMMS control, APM status and clock
Date: Fri, 31 Jan 2003 17:34:30 +0100

 Gah! Typo in Makefile.
 
 < CONFIGURE_ARGS+=      --disable-xxms
  > CONFIGURE_ARGS+=      --disable-xmms
 
 .. I'm so sorry.
 
 --jens
 
 

From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
To: Jens Arnfast <jens@arnfast.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with
 XMMS control, APM status and clock
Date: Sat, 1 Feb 2003 16:08:05 +0100

 --=.'ziqPk_gi7C5zm
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Lately Jens Arnfast told:
 
 > sed 's/^X//' >evilbar/pkg-plist << 'END-of-evilbar/pkg-plist'
 > Xbin/evilbar
 > Xbin/launch_evilbar
 > Xman/man1/evilbar.1
 > Xman/man1/launch_evilbar.1
 
 man pages shouldn't appear in plist; instead, use ${MAN1}
 
 > sed 's/^X//' >evilbar/Makefile << 'END-of-evilbar/Makefile'
 [...]
 > X.include <bsd.port.pre.mk>
 
 what for?
 
 > X.if defined(WITHOUT_XMMS)
 > XCONFIGURE_ARGS+=       --disable-xxms
 > X.endif
 
 doesn't that interfere with build and run depends?
 
 [...]
 > Xpre-extract:
 
 pre-everything:: ?
 
 cheers
   simon
 
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.'ziqPk_gi7C5zm
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (FreeBSD)
 
 iD8DBQE+O+LVr5S+dk6z85oRAtnOAKC2Fr1OUX2AxRyCniEz/QLGl7gNagCgxmOg
 AYSAN5EcbB46zMP/mhG1F6s=
 =yTnm
 -----END PGP SIGNATURE-----
 
 --=.'ziqPk_gi7C5zm--

From: Jens Arnfast <jens@arnfast.net>
To: Simon 'portlint' Schubert <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with
 XMMS control, APM status and clock
Date: Sat, 01 Feb 2003 20:20:12 +0100

 Hi Simon,
 
 thanks for your reply.
 As you clearly discovered this is my first time creating a port :)
 
 Simon 'portlint' Schubert wrote:
 > Lately Jens Arnfast told:
 [snip]
 > man pages shouldn't appear in plist; instead, use ${MAN1}
 
 Looks like I didn't read the plist chapter of Porter's Handbook 
 thoroughly. I'll remove the mans from plist and instead use ${MAN1}
 
 >>X.include <bsd.port.pre.mk>
 > what for?
 
 It seemed right at the time :) I think I got the idea that @${ECHO_MSG} 
 required the pre.mk
 
 >>X.if defined(WITHOUT_XMMS)
 >>XCONFIGURE_ARGS+=       --disable-xxms
 >>X.endif
 > doesn't that interfere with build and run depends?
 It certainly appears so. I've moved the LIB_DEPENDS and RUN_DEPENDS so 
 they only get set if !defined(WITHOUT_XMMS)
 
 >>Xpre-extract:
 > pre-everything:: ?
 Once again you're right :) (fixed)
 
 So.. now I have an new, improved and hopefully more correct Makefile - 
 what do I do with that? Send it to you or a new send-pr?
 
 Cheers,
 -jens
 

From: Jens Arnfast <jens@arnfast.net>
To: freebsd-gnats-submit@FreeBSD.org, jens@arnfast.net,
	corecode@corecode.ath.cx
Cc:  
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with
 XMMS control, APM status and clock
Date: Sun, 02 Feb 2003 23:04:30 +0100

 Allright, let's try with a new improved port :-)
 
 The following shar obsoletes the original shar in this pr.
 
 Thank you for your patience
 
 Regards,
 -jens
 
 # This is a shell archive.  Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file".  Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 #       evilbar
 #       evilbar/pkg-comment
 #       evilbar/pkg-plist
 #       evilbar/distinfo
 #       evilbar/Makefile
 #       evilbar/pkg-descr
 #
 echo c - evilbar
 mkdir -p evilbar > /dev/null 2>&1
 echo x - evilbar/pkg-comment
 sed 's/^X//' >evilbar/pkg-comment << 'END-of-evilbar/pkg-comment'
 XMinimalistic statusbar with XMMS control, APM status and clock
 END-of-evilbar/pkg-comment
 echo x - evilbar/pkg-plist
 sed 's/^X//' >evilbar/pkg-plist << 'END-of-evilbar/pkg-plist'
 Xbin/evilbar
 Xbin/launch_evilbar
 END-of-evilbar/pkg-plist
 echo x - evilbar/distinfo
 sed 's/^X//' >evilbar/distinfo << 'END-of-evilbar/distinfo'
 XMD5 (evilbar-1.2.0.tar.gz) = 8c99e3617adc277bb65471fbf2f579cb
 END-of-evilbar/distinfo
 echo x - evilbar/Makefile
 sed 's/^X//' >evilbar/Makefile << 'END-of-evilbar/Makefile'
 X# New ports collection makefile for:    evilbar
 X# Date created:                         31 Januar 2003
 X# Whom:                                 Jens Arnfast <jens@arnfast.net>
 X#
 X# $FreeBSD$
 X#
 X
 XPORTNAME=      evilbar
 XPORTVERSION=   1.2.0
 XCATEGORIES+=   audio sysutils x11-clocks
 XMASTER_SITES=  http://arnfast.net/projects/
 X
 XMAINTAINER?=   jens@arnfast.net
 X
 XHAS_CONFIGURE=  yes
 X
 XMAN1=          evilbar.1 launch_evilbar.1
 X
 X.if !defined(WITHOUT_XMMS)
 XBUILD_DEPENDS+=  xmms:${PORTSDIR}/multimedia/xmms
 XRUN_DEPENDS+=    xmms:${PORTSDIR}/multimedia/xmms
 X.else
 XCONFIGURE_ARGS+=       --disable-xmms
 X.endif
 X
 X.if defined(WITH_APM)
 XCONFIGURE_ARGS+=       --enable-apm
 X.endif
 X
 Xpre-everything:
 X.if !defined(WITHOUT_XMMS)
 X       @${ECHO_MSG}
 X       @${ECHO_MSG} "You can disable XMMS control by defining 
 WITHOUT_XMMS."
 X.endif
 X.if !defined(WITH_APM)
 X       @${ECHO_MSG}
 X       @${ECHO_MSG} "You can enable APM status by defining WITH_APM."
 X.endif
 X       @${ECHO_MSG}
 X
 X.include <bsd.port.mk>
 END-of-evilbar/Makefile
 echo x - evilbar/pkg-descr
 sed 's/^X//' >evilbar/pkg-descr << 'END-of-evilbar/pkg-descr'
 Xevilbar is a minimalistic ncurses-based statusbar
 Xwith XMMS control, APM status and a clock.
 X
 XWWW: http://arnfast.net/evilbar/
 X
 X-- Jens Arnfast <jens@arnfast.net>
 END-of-evilbar/pkg-descr
 exit
 
State-Changed-From-To: open->analyzed 
State-Changed-By: roam 
State-Changed-When: Tue Feb 11 04:41:53 PST 2003 
State-Changed-Why:  
There are a couple of issues with disabling XMMS support that 
I will sort out with the author. 


Responsible-Changed-From-To: freebsd-ports-bugs->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Tue Feb 11 04:41:53 PST 2003 
Responsible-Changed-Why:  
I'll take care of this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47729 

From: Peter Pentchev <roam@ringlet.net>
To: Jens Arnfast <jens@arnfast.net>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with XMMS control, APM status and clock
Date: Tue, 11 Feb 2003 14:46:22 +0200

 --1yeeQ81UyVL57Vl7
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: inline
 
 On Sun, Feb 02, 2003 at 02:10:14PM -0800, Jens Arnfast wrote:
 > 
 >  Allright, let's try with a new improved port :-)
 >  
 >  The following shar obsoletes the original shar in this pr.
 
 Hi,
 
 Unfortunately, there are a couple of problems with your port (or maybe
 with the evilbar source itself) when XMMS support is disabled.  Attached
 is a patch to the evilbar source, which does several things:
 - moves the --disable-xmms check above the actual xmms-config path
   search;
 - moves the --disable-apm check along with the --disable-xmms one as
   close to the start as possible, just in case;
 - changes the two checks to use $enableval instead of $enable_optname,
   because the latter is not always defined;
 - sets PATH_XMMSCONFIG to 'true' instead of 'no' in the --disable-xmms
   case, since 'no --cflags' and 'no --libs' would break the build;
 - encloses the whole xmmsc.c in an #ifdef USE_XMMS; it would be better
   to exclude it from the build altogether, but this would require more
   invasive changes to the Makefile.
 
 Keep up the good work!
 
 G'luck,
 Peter
 
 -- 
 Peter Pentchev	roam@ringlet.net	roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 If I were you, who would be reading this sentence?
 
 --1yeeQ81UyVL57Vl7
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: attachment; filename="evilbar-xmms.patch"
 
 Index: configure.in
 ===================================================================
 RCS file: /home/cvs/ringlet/c/contrib/audio/evilbar/configure.in,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 configure.in
 --- configure.in	11 Feb 2003 12:25:21 -0000	1.1.1.1
 +++ configure.in	11 Feb 2003 12:37:30 -0000
 @@ -13,6 +13,22 @@
  AC_PROG_CC
  AC_PROG_LIBTOOL
  
 +# Add ./configure --enable-apm
 +AC_ARG_ENABLE(apm,
 +    [  --enable-apm            compile with APM module],
 +    apm=$enableval,
 +    apm=no
 +)
 +
 +#Add ./configure --disable-xmms
 +AC_ARG_ENABLE(xmms,
 +    [  --disable-xmms          compile without XMMS module],
 +    xmms=$enableval,
 +    xmms=yes
 +)
 +
 +if test $xmms = "yes"; then
 +
  AC_PATH_PROG(PATH_XMMSCONFIG,xmms-config, no,
          $PATH:/usr/X11R6/bin:/usr/local/bin)
  
 @@ -26,23 +42,15 @@
          exit
  fi
  
 +else
 +
 +PATH_XMMSCONFIG="true"
 +
 +fi
 +
  AC_HEADER_STDC
  AC_CHECK_HEADER(curses.h, AC_DEFINE(HAVE_CURSES_H), AC_MSG_ERROR(Can't compile without curses.h))
  AC_CHECK_HEADER(pthread.h, AC_DEFINE(HAVE_PTHREAD_H), AC_MSG_ERROR(Can't compile without pthread.h))
 -
 -# Add ./configure --enable-apm
 -AC_ARG_ENABLE(apm,
 -    [  --enable-apm            compile with APM module],
 -    apm=$enable_apm,
 -    apm=no
 -)
 -
 -#Add ./configure --disable-xmms
 -AC_ARG_ENABLE(xmms,
 -    [  --disable-xmms          compile without XMMS module],
 -    xmms=$disable_xmms,
 -    xmms=yes
 -)
  
  AC_MSG_CHECKING(for enabled APM)
  if test "x$apm" = xyes; then
 Index: xmmsc.c
 ===================================================================
 RCS file: /home/cvs/ringlet/c/contrib/audio/evilbar/xmmsc.c,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 xmmsc.c
 --- xmmsc.c	11 Feb 2003 12:25:21 -0000	1.1.1.1
 +++ xmmsc.c	11 Feb 2003 12:38:12 -0000
 @@ -1,3 +1,4 @@
 +#ifdef USE_XMMS
  /* $Id: xmmsc.c,v 1.10 2003/01/20 08:14:56 jear Exp $ */
  #include <stdio.h>
  #include <string.h>
 @@ -229,3 +230,4 @@
    }
    pthread_exit(NULL);
  }
 +#endif
 
 --1yeeQ81UyVL57Vl7--

From: Jens Arnfast <jens@arnfast.net>
To: Peter Pentchev <roam@ringlet.net>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/47729: New port: evilbar - minimalistic statusbar with
 XMMS control, APM status and clock
Date: Tue, 11 Feb 2003 15:24:40 +0100

 This is a multi-part message in MIME format.
 --------------010001040005010503010707
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Peter Pentchev wrote:
 > Unfortunately, there are a couple of problems with your port (or maybe
 > with the evilbar source itself) when XMMS support is disabled.  Attached
 > is a patch to the evilbar source, which does several things:
 > - moves the --disable-xmms check above the actual xmms-config path
 >   search;
 > - moves the --disable-apm check along with the --disable-xmms one as
 >   close to the start as possible, just in case;
 > - changes the two checks to use $enableval instead of $enable_optname,
 >   because the latter is not always defined;
 > - sets PATH_XMMSCONFIG to 'true' instead of 'no' in the --disable-xmms
 >   case, since 'no --cflags' and 'no --libs' would break the build;
 > - encloses the whole xmmsc.c in an #ifdef USE_XMMS; it would be better
 >   to exclude it from the build altogether, but this would require more
 >   invasive changes to the Makefile.
 
 Ah .. that makes perfect sense :)
 I disregarded your last point and implemented the changes you sent me.
 I also corrected a few other #ifdef bugs in the code and bumped the 
 revision up to 1.2.1
 
 Attached is a patch to the evilbar/Makefile and evilbar/distinfo
 
 Thank you for the extensive help :-)
 
 Cheers,
 -jens
 
 --------------010001040005010503010707
 Content-Type: text/plain;
  name="evilbar-120bump121.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="evilbar-120bump121.patch"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/cvs/evilbar/port/evilbar/Makefile,v
 retrieving revision 1.1
 retrieving revision 1.2
 diff -u -r1.1 -r1.2
 --- Makefile	11 Feb 2003 13:03:15 -0000	1.1
 +++ Makefile	11 Feb 2003 14:12:15 -0000	1.2
 @@ -6,7 +6,7 @@
  #
  
  PORTNAME= 	evilbar
 -PORTVERSION= 	1.2.0
 +PORTVERSION= 	1.2.1
  CATEGORIES+= 	audio sysutils x11-clocks
  MASTER_SITES=	http://arnfast.net/projects/
  
 Index: distinfo
 ===================================================================
 RCS file: /home/cvs/evilbar/port/evilbar/distinfo,v
 retrieving revision 1.1
 retrieving revision 1.2
 diff -u -r1.1 -r1.2
 --- distinfo	11 Feb 2003 13:03:15 -0000	1.1
 +++ distinfo	11 Feb 2003 14:12:15 -0000	1.2
 @@ -1 +1 @@
 -MD5 (evilbar-1.2.0.tar.gz) = 8c99e3617adc277bb65471fbf2f579cb
 +MD5 (evilbar-1.2.1.tar.gz) = fb93267570c167c4c9bfad65b88ee4bb
 
 --------------010001040005010503010707--
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: roam 
State-Changed-When: Thu Feb 13 04:42:26 PST 2003 
State-Changed-Why:  
Oops; I actually committed the new port two days ago, yet 
forgot to close this PR :) 

Thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47729 
>Unformatted:
