From dean@odyssey.apana.org.au  Thu Jan 23 01:38:22 2003
Return-Path: <dean@odyssey.apana.org.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F88237B401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Jan 2003 01:38:22 -0800 (PST)
Received: from odyssey.apana.org.au (odyssey.apana.org.au [203.11.114.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D2F8A43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Jan 2003 01:38:09 -0800 (PST)
	(envelope-from dean@odyssey.apana.org.au)
Received: (from dean@localhost)
	by odyssey.apana.org.au (8.9.3/8.9.3) id RAA84360;
	Thu, 23 Jan 2003 17:37:36 +0800 (WST)
Message-Id: <200301230937.RAA84360@mail.wa.apana.org.au>
Date: Thu, 23 Jan 2003 17:37:36 +0800 (WST)
From: Dean Hollister <dean@odyssey.apana.org.au>
Reply-To: Dean Hollister <dean@odyssey.apana.org.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Updated Port: security/fakeident
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         47390
>Category:       ports
>Synopsis:       Updated Port: security/fakeident
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 23 01:40:05 PST 2003
>Closed-Date:    Wed Jan 29 19:56:02 PST 2003
>Last-Modified:  Wed Jan 29 19:56:02 PST 2003
>Originator:     Dean Hollister
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Australian Public Access Network Association Inc
>Environment:
System: FreeBSD odyssey.apana.org.au 4.7-STABLE FreeBSD 4.7-STABLE #0: Mon Nov 18 15:16:12 WST 2002 root@odyssey.apana.org.au:/usr/obj/usr/src/sys/ODYSSEY i386
>Description:
Updated Port: security/fakeident - rc.d script and localbase fix 
>How-To-Repeat:
>Fix:
diff -ruN fakeident.old/Makefile fakeident/Makefile
--- fakeident.old/Makefile	Thu Jan 23 17:24:23 2003
+++ fakeident/Makefile	Thu Jan 23 17:22:05 2003
@@ -7,6 +7,7 @@
 
 PORTNAME=	fakeident
 PORTVERSION=	1.7
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	http://www.wa.apana.org.au/~dean/sources/ \
 		ftp://ftp.wa.apana.org.au/pub/pc/unix/packages/
@@ -26,7 +27,7 @@
 	@echo ""
 
 do-install:
-	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
-	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
+	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
+	$(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
 
 .include <bsd.port.mk>
diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
--- fakeident.old/files/fakeident.sh	Thu Jan  1 08:00:00 1970
+++ fakeident/files/fakeident.sh	Thu Jan 23 17:36:22 2003
@@ -0,0 +1,29 @@
+#! /bin/sh
+#
+
+PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
+
+# This can be changed as desired.
+# The username does not need to exist anywhere in your system.
+
+USERNAME=nobody
+
+if ! PREFIX=$(expr $0 : "\(/.*\)/etc/rc\.d/$(basename $0)\$"); then
+    echo "$0: Cannot determine the PREFIX" >&2
+    exit 1
+fi
+
+case "$1" in
+start)
+    $PREFIX/sbin/identd $USERNAME && echo -n ' fakeidentd'
+    ;;
+
+stop)
+    kill -9 `cat /var/run/identd.pid` && echo -n ' fakeidentd'
+    ;;
+
+*)
+    echo "Usage: `basename $0` {start|stop}" >&2
+    exit 64
+    ;;
+esac
>Release-Note:
>Audit-Trail:

From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Dean Hollister <dean@odyssey.apana.org.au>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 10:56:42 +0100

 --=.QSucp1gThSKh+Q
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Lately Dean Hollister told:
 
 > diff -ruN fakeident.old/Makefile fakeident/Makefile
 [...]
 >  do-install:
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
 > +	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
 > +	$(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
 
 are you sure about this? seems like making this not PREFIX clean.
 better use:
 
 ${INSTALL_PROGRAM} ${WRKSRC}/identd ${PREFIX}/sbin
 ${INSTALL_SCRIPT} ${FILESDIR}/fakeident.sh ${PREFIX}/etc/rc.d
 
 > diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
 [...]
 > +stop)
 > +    kill -9 `cat /var/run/identd.pid` && echo -n ' fakeidentd'
 > +    ;;
 
 how about checking for /var/run/identd.pid existance?
 otherwise stopping a not running fakeidentd will produce an ugly error
 message:
 cat: /var/run/identd.pid: No such file or directory
 
 cheers
   simon
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.QSucp1gThSKh+Q
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (FreeBSD)
 
 iD8DBQE+L7xar5S+dk6z85oRAgYnAJ91cNkfJDrxoALVjUVfn7bQRUIdiwCgzrty
 +ecUM3KGHtw5HGFIoTpVx2Y=
 =rWzl
 -----END PGP SIGNATURE-----
 
 --=.QSucp1gThSKh+Q--

From: Dean Hollister <dean@odyssey.apana.org.au>
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 18:00:08 +0800

 At 10:56 23/01/2003 +0100, Simon 'corecode' Schubert wrote:
 
 >how about checking for /var/run/identd.pid existance?
 >otherwise stopping a not running fakeidentd will produce an ugly error
 >message:
 >cat: /var/run/identd.pid: No such file or directory  simon--
 
 The problem is that the identd daemon doesn't remove this file upon 
 exiting, as a result, a stop will return a no such process error anyway.
 
 Kind of a case of 6 of one, half a dozen of the other...
 
 That said, it's certainly feasible to check for the existence of the pid 
 file, and if it exists, send a kill to the pid in it and then rm the file, 
 all within the rc.d script.
 
 Regards,
 
 d.
 
 

From: Dean Hollister <dean@odyssey.apana.org.au>
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 18:07:17 +0800 (WST)

 Following diff I believe addresses all issues satisfactorily now. :-)
 
 diff -ruN fakeident.old/Makefile fakeident/Makefile
 --- fakeident.old/Makefile	Thu Jan 23 17:24:23 2003
 +++ fakeident/Makefile	Thu Jan 23 17:22:05 2003
 @@ -7,6 +7,7 @@
 
  PORTNAME=	fakeident
  PORTVERSION=	1.7
 +PORTREVISION=	1
  CATEGORIES=	security
  MASTER_SITES=	http://www.wa.apana.org.au/~dean/sources/ \
  		ftp://ftp.wa.apana.org.au/pub/pc/unix/packages/
 @@ -26,7 +27,7 @@
  	@echo ""
 
  do-install:
 -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
 -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
 +	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
 +	$(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
 
  .include <bsd.port.mk>
 diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
 --- fakeident.old/files/fakeident.sh	Thu Jan  1 08:00:00 1970
 +++ fakeident/files/fakeident.sh	Thu Jan 23 18:04:15 2003
 @@ -0,0 +1,32 @@
 +#! /bin/sh
 +#
 +
 +PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
 +
 +# This can be changed as desired.
 +# The username does not need to exist anywhere in your system.
 +
 +USERNAME=nobody
 +
 +if ! PREFIX=$(expr $0 : "\(/.*\)/etc/rc\.d/$(basename $0)\$"); then
 +    echo "$0: Cannot determine the PREFIX" >&2
 +    exit 1
 +fi
 +
 +case "$1" in
 +start)
 +    $PREFIX/sbin/identd $USERNAME && echo -n ' fakeidentd'
 +    ;;
 +
 +stop)
 +    if [ -r /var/run/identd.pid ] ; then
 +    kill -9 `cat /var/run/identd.pid` >>/dev/null 2>&1
 +    rm -f /var/run/identd.pid
 +    fi
 +    ;;
 +
 +*)
 +    echo "Usage: `basename $0` {start|stop}" >&2
 +    exit 64
 +    ;;
 +esac

From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Dean Hollister <dean@odyssey.apana.org.au>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 11:14:15 +0100

 --=.xXvPcNWZ'hXCi=
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Lately Dean Hollister told:
 
 > Following diff I believe addresses all issues satisfactorily now. :-)
 > 
 > diff -ruN fakeident.old/Makefile fakeident/Makefile
 [...]
 >  do-install:
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
 > +	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
 > +	$(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
 
 uhm, i don't want to appear as being a nitpicky bitchy person, but
 please install into ${PREFIX}
 and while you're at it you may use ${INSTALL_PROGRAM} and
 ${INSTALL_SCRIPT} to get the owners and modes set as desired
 
 > diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
 [...]
 > +stop)
 > +    if [ -r /var/run/identd.pid ] ; then
 > +    kill -9 `cat /var/run/identd.pid` >>/dev/null 2>&1
 > +    rm -f /var/run/identd.pid
 > +    fi
 > +    ;;
 
 very nice
 
 cheers
   simon
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.xXvPcNWZ'hXCi=
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (FreeBSD)
 
 iD8DBQE+L8B3r5S+dk6z85oRAu1UAKCbyJ9rFi+ukGcfaC7fq4LQCCFtdgCfev96
 8a80wCFsOajPAHNZLODWnEE=
 =zNbm
 -----END PGP SIGNATURE-----
 
 --=.xXvPcNWZ'hXCi=--

From: Dean Hollister <dean@odyssey.apana.org.au>
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 18:26:27 +0800 (WST)

 Ok... How about....
 
 diff -ruN fakeident.old/Makefile fakeident/Makefile
 --- fakeident.old/Makefile	Thu Jan 23 17:24:23 2003
 +++ fakeident/Makefile	Thu Jan 23 18:24:24 2003
 @@ -7,6 +7,7 @@
 
  PORTNAME=	fakeident
  PORTVERSION=	1.7
 +PORTREVISION=	1
  CATEGORIES=	security
  MASTER_SITES=	http://www.wa.apana.org.au/~dean/sources/ \
  		ftp://ftp.wa.apana.org.au/pub/pc/unix/packages/
 @@ -26,7 +27,7 @@
  	@echo ""
 
  do-install:
 -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
 -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
 +	$(INSTALL_SCRIPT) $(WRKSRC)/identd $(PREFIX)/sbin
 +	$(INSTALL_SCRIPT) $(FILESDIR)/fakeident.sh $(PREFIX)/etc/rc.d
 
  .include <bsd.port.mk>
 diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
 --- fakeident.old/files/fakeident.sh	Thu Jan  1 08:00:00 1970
 +++ fakeident/files/fakeident.sh	Thu Jan 23 18:04:15 2003
 @@ -0,0 +1,32 @@
 +#! /bin/sh
 +#
 +
 +PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
 +
 +# This can be changed as desired.
 +# The username does not need to exist anywhere in your system.
 +
 +USERNAME=nobody
 +
 +if ! PREFIX=$(expr $0 : "\(/.*\)/etc/rc\.d/$(basename $0)\$"); then
 +    echo "$0: Cannot determine the PREFIX" >&2
 +    exit 1
 +fi
 +
 +case "$1" in
 +start)
 +    $PREFIX/sbin/identd $USERNAME && echo -n ' fakeidentd'
 +    ;;
 +
 +stop)
 +    if [ -r /var/run/identd.pid ] ; then
 +    kill -9 `cat /var/run/identd.pid` >>/dev/null 2>&1
 +    rm -f /var/run/identd.pid
 +    fi
 +    ;;
 +
 +*)
 +    echo "Usage: `basename $0` {start|stop}" >&2
 +    exit 64
 +    ;;
 +esac
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Wed Jan 29 19:55:48 PST 2003 
State-Changed-Why:  
Commited, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47390 
>Unformatted:
