From yar@bsd.chem.msu.ru  Wed Jan 22 06:54:04 2003
Return-Path: <yar@bsd.chem.msu.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AA39E37B401; Wed, 22 Jan 2003 06:54:04 -0800 (PST)
Received: from bsd.chem.msu.ru (bsd.chem.msu.ru [195.208.208.23])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 336C243F13; Wed, 22 Jan 2003 06:54:03 -0800 (PST)
	(envelope-from yar@bsd.chem.msu.ru)
Received: from bsd.chem.msu.ru (localhost [127.0.0.1])
	by bsd.chem.msu.ru (8.12.6/8.12.6) with ESMTP id h0MEs1fn049631;
	Wed, 22 Jan 2003 17:54:01 +0300 (MSK)
	(envelope-from yar@bsd.chem.msu.ru)
Received: (from yar@localhost)
	by bsd.chem.msu.ru (8.12.6/8.12.6/Submit) id h0MEs068049629;
	Wed, 22 Jan 2003 17:54:00 +0300 (MSK)
Message-Id: <200301221454.h0MEs068049629@bsd.chem.msu.ru>
Date: Wed, 22 Jan 2003 17:54:00 +0300 (MSK)
From: Yar Tikhiy <yar@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jmz@freebsd.org
Subject: Optional FIDO support for comms/mgetty+sendfax port
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         47364
>Category:       ports
>Synopsis:       Optional FIDO support for comms/mgetty+sendfax port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 22 07:00:14 PST 2003
>Closed-Date:    Thu Jan 23 10:36:18 PST 2003
>Last-Modified:  Thu Jan 23 10:36:18 PST 2003
>Originator:     Yar Tikhiy
>Release:        FreeBSD 4.7-RELEASE-p3 i386
>Organization:
Moscow State University
>Environment:
	FreeBSD

>Description:
	mgetty+sendfax includes optional support for FIDO on dialup lines.
	When building mgetty from its original sources, it can be enabled
	as easily as by adding -DFIDO to CFLAGS.
	Unfortunately, the comms/mgetty+sendfax port provides no conventional
	way to enable that feature when building the port.

>How-To-Repeat:
	Install comms/mgetty+sendfax

>Fix:

The below patch moves the CFLAGS tweak from a patchfile to Makefile
and allows adding -DFIDO to CFLAGS as an option.

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/comms/mgetty+sendfax/Makefile,v
retrieving revision 1.40
diff -u -r1.40 Makefile
--- Makefile	28 Oct 2002 00:19:19 -0000	1.40
+++ Makefile	22 Jan 2003 14:40:36 -0000
@@ -58,6 +58,18 @@
 		pvf.1 voctopvf.1 \
 		pvf.1 wavtopvf.1
 
+CFLAGS+=	-DAUTO_PPP
+.if defined(WITH_FIDO) && ${WITH_FIDO:L} != no
+CFLAGS+=	-DFIDO
+.endif
+
+pre-everything::
+.if !defined(WITH_FIDO)
+	@${ECHO_MSG}
+	@${ECHO_MSG} "If you need FIDO EMSI support, use \"make WITH_FIDO=yes\""
+	@${ECHO_MSG}
+.endif
+
 pre-install:
 	@(cd ${WRKSRC}/doc; ${MAKE} manpages)
 
Index: files/patch-ab
===================================================================
RCS file: /home/ncvs/ports/comms/mgetty+sendfax/files/patch-ab,v
retrieving revision 1.8
diff -u -r1.8 patch-ab
--- files/patch-ab	1 Dec 1998 09:08:21 -0000	1.8
+++ files/patch-ab	22 Jan 2003 14:40:36 -0000
@@ -16,7 +16,7 @@
  #
  #CFLAGS=-Wall -O2 -pipe -DSECUREWARE -DUSE_POLL
 -CFLAGS=-O2 -Wall -pipe
-+CFLAGS+=-DAUTO_PPP
++#CFLAGS=-O2 -Wall -pipe
  #CFLAGS=-O -DSVR4
  #CFLAGS=-O -DSVR4 -DSVR42
  #CFLAGS=-O -DUSE_POLL
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jmz 
Responsible-Changed-By: arved 
Responsible-Changed-When: Thu Jan 23 10:10:02 PST 2003 
Responsible-Changed-Why:  
Over to Maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47364 
State-Changed-From-To: open->closed 
State-Changed-By: jmz 
State-Changed-When: Thu Jan 23 10:35:52 PST 2003 
State-Changed-Why:  
Patch committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47364 
>Unformatted:
