From lth@thegler.dk  Fri Jan  3 06:00:37 2003
Return-Path: <lth@thegler.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A7D6637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Jan 2003 06:00:37 -0800 (PST)
Received: from cicero0.cybercity.dk (cicero0.cybercity.dk [212.242.40.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C105D43ED8
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Jan 2003 06:00:36 -0800 (PST)
	(envelope-from lth@thegler.dk)
Received: from minerva.thegler.dk (port156.ds1-bav.adsl.cybercity.dk [217.157.188.161])
	by cicero0.cybercity.dk (Postfix) with ESMTP
	id 9A1B4102F52; Fri,  3 Jan 2003 15:00:34 +0100 (CET)
Received: by minerva.thegler.dk (Postfix, from userid 1001)
	id 16CAD236; Fri,  3 Jan 2003 15:00:34 +0100 (CET)
Message-Id: <20030103140034.16CAD236@minerva.thegler.dk>
Date: Fri,  3 Jan 2003 15:00:34 +0100 (CET)
From: Lars Thegler <lars@thegler.dk>
Reply-To: Lars Thegler <lars@thegler.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: lars@thegler.dk
Subject: Update www/p5-CGI-SpeedyCGI to 2.21
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         46723
>Category:       ports
>Synopsis:       Update www/p5-CGI-SpeedyCGI to 2.21
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 03 06:10:01 PST 2003
>Closed-Date:    Fri Feb 28 17:33:08 PST 2003
>Last-Modified:  Fri Feb 28 17:33:08 PST 2003
>Originator:     Lars Thegler
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
>Environment:
System: FreeBSD minerva.thegler.dk 4.7-RELEASE FreeBSD 4.7-RELEASE #0: Wed Oct 9 15:08:34 GMT 2002 root@builder.freebsdmall.com:/usr/obj/usr/src/sys/GENERIC i386

>Description:
Update port www/p5-CGI-SpeedyCGI to version 2.21.

>How-To-Repeat:
>Fix:
Apply this diff:

--cut--
diff -Naur /usr/ports/www/p5-CGI-SpeedyCGI/Makefile p5-CGI-SpeedyCGI/Makefile
--- /usr/ports/www/p5-CGI-SpeedyCGI/Makefile	Mon Mar 25 14:42:29 2002
+++ p5-CGI-SpeedyCGI/Makefile	Sat Dec 28 17:27:12 2002
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	CGI-SpeedyCGI
-PORTVERSION=	2.11
+PORTVERSION=	2.21
 CATEGORIES=	www perl5
 MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
 MASTER_SITE_SUBDIR=	CGI
diff -Naur /usr/ports/www/p5-CGI-SpeedyCGI/distinfo p5-CGI-SpeedyCGI/distinfo
--- /usr/ports/www/p5-CGI-SpeedyCGI/distinfo	Mon Mar 25 14:42:29 2002
+++ p5-CGI-SpeedyCGI/distinfo	Sat Dec 28 17:27:31 2002
@@ -1 +1 @@
-MD5 (CGI-SpeedyCGI-2.11.tar.gz) = fce7ed7417d8d4166f5e7b54bfbcac13
+MD5 (CGI-SpeedyCGI-2.21.tar.gz) = ff43eaa899c5ff38f208ed692ab12bb4
--cut--

>Release-Note:
>Audit-Trail:

From: Pete Fritchman <petef@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, lars@thegler.dk
Cc:  
Subject: Re: ports/46723: Update www/p5-CGI-SpeedyCGI to 2.21
Date: Sun, 5 Jan 2003 17:54:05 -0800

 ===>  Configuring for p5-CGI-SpeedyCGI-2.21
 
 Optional mod_speedycgi support.
 
 Mod_speedycgi increases performance under Apache by avoiding the fork/exec
 overhead associated with each request under normal SpeedyCGI.  However, it
 requires a working copy of "apxs" in your path, Apache with mod_so
 support, and additional Apache configuration.
 
 Compile mod_speedycgi (default no)? 
 %%
 
 You either need to mark the port interactive, or (what I would
 recommend) patching Makefile.PL to the desired answer.  I answered no
 and it still tried to install mod_speedycgi on the make install stage.
 
 --pete
 

From: "Lars Thegler" <lars@thegler.dk>
To: "Pete Fritchman" <petef@FreeBSD.org>,
	<FreeBSD-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/46723: Update www/p5-CGI-SpeedyCGI to 2.21
Date: Mon, 6 Jan 2003 17:09:39 +0100

 You've got a very valid point there. Sorry I missed this. It seems there is
 an error in the distribution - it will attempt to install mod_speedycgi,
 irrepective of the answer given in the configuration dialogue. I've reported
 this to the author.
 
 I've disabled the mod_speedycgi stuff in the Makefile.PL - this should be a
 separate port anyway (e.g. "www/mod_speedycgi"), so the following patch file
 should be added to the port:
 
 -- files/patch-Makefile.PL begin --
 --- Makefile.PL.orig    Wed Sep 18 08:21:06 2002
 +++ Makefile.PL Mon Jan  6 15:51:55 2003
 @@ -6,26 +6,26 @@
      import SpeedyMake qw(%write_makefile_common);
  }
 
 -print <<END;
 -
 -Optional mod_speedycgi support.
 -
 -Mod_speedycgi increases performance under Apache by avoiding the fork/exec
 -overhead associated with each request under normal SpeedyCGI.  However, it
 -requires a working copy of "apxs" in your path, Apache with mod_so
 -support, and additional Apache configuration.
 -
 -END
 -print "Compile mod_speedycgi (default no)? ";
 +#print <<END;
 +#
 +#Optional mod_speedycgi support.
 +#
 +#Mod_speedycgi increases performance under Apache by avoiding the fork/exec
 +#overhead associated with each request under normal SpeedyCGI.  However, it
 +#requires a working copy of "apxs" in your path, Apache with mod_so
 +#support, and additional Apache configuration.
 +#
 +#END
 +#print "Compile mod_speedycgi (default no)? ";
 
  my @dirs = qw(src speedy_backend speedy);
  my $macro = $write_makefile_common{macro};
 -if (<STDIN> =~ /y/i) {
 -    die "ERROR: Could not find a working copy of 'apxs' in your path.\n"
 -       unless $macro->{APACHE_APXS_WORKS};
 -    print "Compiling for Apache version $macro->{APACHE_VERSION}\n";
 -    push(@dirs, $macro->{MOD_SPEEDYCGI_DIR});
 -}
 +#if (<STDIN> =~ /y/i) {
 +#    die "ERROR: Could not find a working copy of 'apxs' in your path.\n"
 +#      unless $macro->{APACHE_APXS_WORKS};
 +#    print "Compiling for Apache version $macro->{APACHE_VERSION}\n";
 +#    push(@dirs, $macro->{MOD_SPEEDYCGI_DIR});
 +#}
 
  WriteMakefile(
      NAME               => 'CGI::SpeedyCGI',
 @@ -47,12 +47,12 @@
  sub postamble {
      my $extra = SpeedyMake->optdefs_cmds('src');
      my $test_install_extra;
 -    if (my $mod_dir = $macro->{MOD_SPEEDYCGI_DIR}) {
 -       $extra .=
 -           "\ninstall ::\n\tcd $mod_dir && \$(MAKE) install\n";
 -       $test_install_extra =
 -           "\t\@cd $mod_dir && \$(MAKE) test_install \$(PASTHRU)\n";
 -    }
 +#    if (my $mod_dir = $macro->{MOD_SPEEDYCGI_DIR}) {
 +#      $extra .=
 +#          "\ninstall ::\n\tcd $mod_dir && \$(MAKE) install\n";
 +#      $test_install_extra =
 +#          "\t\@cd $mod_dir && \$(MAKE) test_install \$(PASTHRU)\n";
 +#    }
 
  '
  test_install:
 -- files/patch-Makefile.PL end --
 

From: Pete Fritchman <petef@FreeBSD.org>
To: Lars Thegler <lars@thegler.dk>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/46723: Update www/p5-CGI-SpeedyCGI to 2.21
Date: Thu, 9 Jan 2003 00:25:01 -0500

 Ok, things are looking better except "make test" is failing:
 
 http://absolutbsd.org/petef/maketest.out
 
 Details on my system:
 
 pluto(~) [6] > uname -a
 FreeBSD pluto.databits.net 5.0-RC FreeBSD 5.0-RC #1: Tue Jan  7 20:22:07
 EST 2003     root@pluto.databits.net:/usr/obj/usr/src/sys/PLUTO  i386
 pluto(~) [7] > perl -v
 
 This is perl, v5.6.1 built for i386-freebsd
 
 Copyright 1987-2001, Larry Wall
 
 Perl may be copied only under the terms of either the Artistic License
 or the
 GNU General Public License, which may be found in the Perl 5 source kit.
 
 Complete documentation for Perl, including FAQ lists, should be found on
 this system using `man perl' or `perldoc perl'.  If you have access to
 the
 Internet, point your browser at http://www.perl.com/, the Perl Home
 Page.
 
 pluto(~) [8] > 
 
 --pete

From: Anton Berezin <tobez@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, lars@thegler.dk
Cc: petef@FreeBSD.org
Subject: Re: ports/46723: Update www/p5-CGI-SpeedyCGI to 2.21
Date: Fri, 31 Jan 2003 19:12:34 +0100

 Pete Fritchman <petef@FreeBSD.org> wrote:
 
 > Ok, things are looking better except "make test" is failing:
  
 >  http://absolutbsd.org/petef/maketest.out
 
 Pete, I was not able to reproduce failing tests (tested with several
 different perls on a pristine jail with no packages), and the URL above
 is no longer valid.  I am inclined to commit the latest update from
 Lars.  Care to comment?
 
 Cheers,
 ^Anton.
 -- 
 | Anton Berezin                |      FreeBSD: The power to serve |
 | catpipe Systems ApS   _ _ |_ |           http://www.FreeBSD.org |
 | tobez@catpipe.net    (_(_||  |                tobez@FreeBSD.org | 
 | +45 7021 0050                |         Private: tobez@tobez.org |

From: Attila Nagy <bra@fsn.hu>
To: freebsd-gnats-submit@FreeBSD.org
Cc: lars@thegler.dk, Anton Berezin <tobez@FreeBSD.org>
Subject: Re: ports/46723: Update www/p5-CGI-SpeedyCGI to 2.21
Date: Mon, 10 Feb 2003 11:29:51 +0100 (CET)

 Hello,
 
 I've tried the patch, the port seems to build and install correctly.
 
 Anton, could you please commit it?
 
 $ uname -a
 FreeBSD cimtar.bmf.hu 5.0-RELEASE FreeBSD 5.0-RELEASE #2: Wed Jan 22
 10:45:31 CET 2003     root@ns.bmf.hu:/usr/obj/usr/src/sys/OBERON  i386
 $ perl -v
 
 This is perl, v5.8.0 built for i386-freebsd
 
 Copyright 1987-2002, Larry Wall
 
 Perl may be copied only under the terms of either the Artistic License or
 the
 GNU General Public License, which may be found in the Perl 5 source kit.
 
 Complete documentation for Perl, including FAQ lists, should be found on
 this system using `man perl' or `perldoc perl'.  If you have access to the
 Internet, point your browser at http://www.perl.com/, the Perl Home Page.
 
 Thanks,
 ----------[ Free Software ISOs - http://www.fsn.hu/?f=download ]----------
 Attila Nagy					e-mail: Attila.Nagy@fsn.hu
 Free Software Network (FSN.HU)		  phone @work: +361 210 1415 (194)
 						cell.: +3630 306 6758
State-Changed-From-To: open->closed 
State-Changed-By: leeym 
State-Changed-When: Fri Feb 28 17:33:04 PST 2003 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46723 
>Unformatted:
