From tsuyoshi@san.is.s.u-tokyo.ac.jp  Sat Nov  9 14:37:06 2002
Return-Path: <tsuyoshi@san.is.s.u-tokyo.ac.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 02E0137B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  9 Nov 2002 14:37:06 -0800 (PST)
Received: from san.is.s.u-tokyo.ac.jp (san.is.s.u-tokyo.ac.jp [133.11.28.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5920543E6E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  9 Nov 2002 14:37:05 -0800 (PST)
	(envelope-from tsuyoshi@san.is.s.u-tokyo.ac.jp)
Received: from san.is.s.u-tokyo.ac.jp (localhost [127.0.0.1])
	by san.is.s.u-tokyo.ac.jp (8.12.6/8.12.6) with ESMTP id gA9MafE0074502
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 10 Nov 2002 07:36:41 +0900 (JST)
	(envelope-from tsuyoshi@san.is.s.u-tokyo.ac.jp)
Received: (from tsuyoshi@localhost)
	by san.is.s.u-tokyo.ac.jp (8.12.6/8.12.6/Submit) id gA9Mae4F074501;
	Sun, 10 Nov 2002 07:36:40 +0900 (JST)
Message-Id: <200211092236.gA9Mae4F074501@san.is.s.u-tokyo.ac.jp>
Date: Sun, 10 Nov 2002 07:36:40 +0900 (JST)
From: ITO Tsuyoshi <tsuyoshi@is.s.u-tokyo.ac.jp>
Reply-To: ITO Tsuyoshi <tsuyoshi@is.s.u-tokyo.ac.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] mysql323-server ignores WITH_XCHARSET without WITH_CHARSET
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45173
>Category:       ports
>Synopsis:       [PATCH] mysql323-server ignores WITH_XCHARSET without WITH_CHARSET
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dirk
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 09 14:40:01 PST 2002
>Closed-Date:    Sun Nov 17 08:01:34 PST 2002
>Last-Modified:  Sun Nov 17 08:01:34 PST 2002
>Originator:     ITO Tsuyoshi
>Release:        FreeBSD 4.7-RELEASE-p1 i386
>Organization:
The University of Tokyo
>Environment:
System: FreeBSD san.is.s.u-tokyo.ac.jp 4.7-RELEASE-p1 FreeBSD 4.7-RELEASE-p1 #1: Tue Oct 29 19:20:47 JST 2002 root@san.is.s.u-tokyo.ac.jp:/usr/obj/usr/src/sys/SAN i386


	
>Description:
	The `configure' script of MySQL accepts --with-charset and
	--with-extra-charset options.  Each of these has a default
	value (--with-charset=latin1 and --with-extra-charset=none).
	We can specify both, either one, or none of these options.

	With databases/mysql323-server port, we can specify the values
	for these options with WITH_CHARSET and WITH_XCHARSET
	variables on `make' command line.  However, the port ignores
	WITH_XCHARSET if we specify WITH_XCHARSET but not WITH_CHARSET.

>How-To-Repeat:
	After `make WITH_XCHARSET=complex install', examine config.log
	or try `safe_mysqld --user=mysql --default-character-set=ujis'.

>Fix:
	Here is a patch to solve this problem.

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/mysql323-server/Makefile,v
retrieving revision 1.144
diff -u -r1.144 Makefile
--- Makefile    21 Oct 2002 09:22:13 -0000      1.144
+++ Makefile    9 Nov 2002 21:50:19 -0000
@@ -41,9 +41,9 @@
 .endif
 .if defined(WITH_CHARSET) && ${WITH_CHARSET} != ""
 CONFIGURE_ARGS+=--with-charset=${WITH_CHARSET}
+.endif
 .if defined(WITH_XCHARSET) && ${WITH_XCHARSET} != ""
 CONFIGURE_ARGS+=--with-extra-charsets=${WITH_XCHARSET}
-.endif
 .endif
 .if defined(BUILD_STATIC)
 CONFIGURE_ARGS+=--with-mysqld-ldflags=--static

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->dirk 
Responsible-Changed-By: ijliao 
Responsible-Changed-When: Mon Nov 11 00:25:20 PST 2002 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45173 
State-Changed-From-To: open->closed 
State-Changed-By: dirk 
State-Changed-When: Sun Nov 17 08:01:19 PST 2002 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45173 
>Unformatted:
