From alane@wwweasel.geeksrus.net  Tue Oct 29 17:49:04 2002
Return-Path: <alane@wwweasel.geeksrus.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6838B37B404; Tue, 29 Oct 2002 17:49:04 -0800 (PST)
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BCC3243E7B; Tue, 29 Oct 2002 17:49:03 -0800 (PST)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: from wwweasel.geeksrus.net (localhost [127.0.0.1])
	by wwweasel.geeksrus.net (8.12.6/8.12.6) with ESMTP id g9U1mdjR004965;
	Tue, 29 Oct 2002 20:48:39 -0500 (EST)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: (from root@localhost)
	by wwweasel.geeksrus.net (8.12.6/8.12.6/Submit) id g9U1mdgK004964;
	Tue, 29 Oct 2002 20:48:39 -0500 (EST)
	(envelope-from alane)
Message-Id: <200210300148.g9U1mdgK004964@wwweasel.geeksrus.net>
Date: Tue, 29 Oct 2002 20:48:39 -0500 (EST)
From: Alan Eldridge <alane@freebsd.org>
Reply-To: Alan Eldridge <alane@geeksrus.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: tobez@freebsd.org
Subject: www/p5-CGI.pm: p5-File-Spec should only be used if perl < 5.8
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         44730
>Category:       ports
>Synopsis:       www/p5-CGI.pm: p5-File-Spec should only be used if perl < 5.8
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    tobez
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 29 17:50:08 PST 2002
>Closed-Date:    Sat Feb 08 21:16:55 PST 2003
>Last-Modified:  Sat Feb 08 21:16:55 PST 2003
>Originator:     Alan Eldridge
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Geeksrus.NET
>Environment:

System: FreeBSD wwweasel.geeksrus.net 4.7-STABLE FreeBSD 4.7-STABLE #2
Sat Oct 26 12:33:12 EDT 2002
root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/MY_SHITS_FUCKED_UP  i386

>Description:

p5-File-Spec should only be used if perl < 5.8

>How-To-Repeat:

>Fix:

==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
Index: www/p5-CGI.pm/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/p5-CGI.pm/Makefile,v
retrieving revision 1.3
diff -u -3 -r1.3 Makefile
--- www/p5-CGI.pm/Makefile	28 Oct 2002 15:32:11 -0000	1.3
+++ www/p5-CGI.pm/Makefile	29 Oct 2002 09:24:44 -0000
@@ -15,7 +15,6 @@
 
 MAINTAINER=	tobez@FreeBSD.org
 
-BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/File/Spec.pm:${PORTSDIR}/devel/p5-File-Spec
 RUN_DEPENDS=	${BUILD_DEPENDS}
 
 PERL_CONFIGURE=	yes
@@ -27,4 +26,15 @@
 pre-patch:
 	@${PERL} -pi -e '$$_ = "" if /INSTALLDIRS|5\.6\.0/' ${WRKSRC}/Makefile.PL
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+SITE_PERL?=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}
+
+PERL_MAJOR=${PERL_VER:C|^([1-9]+).*|\1|}
+PERL_MINOR=${PERL_VER:C|^[1-9]+\.0*([1-9]+).*|\1|}
+
+.if ${PERL_MAJOR} < 5 || ${PERL_MAJOR} == 5 && ${PERL_MINOR} < 8
+BUILD_DEPENDS+=	${SITE_PERL}/File/Spec.pm:${PORTSDIR}/devel/p5-File-Spec
+.endif # ${PERL_MAJOR} < 5 || ${PERL_MAJOR} == 5 && ${PERL_MINOR} < 8
+
+.include <bsd.port.post.mk>
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->tobez 
Responsible-Changed-By: alane 
Responsible-Changed-When: Tue Oct 29 23:38:29 PST 2002 
Responsible-Changed-Why: Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44730 
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Sat Feb 8 21:16:49 PST 2003 
State-Changed-Why:  
Commited,thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44730 
>Unformatted:
