From xi@ferengi.borderworlds.dk  Mon Oct 14 06:27:38 2002
Return-Path: <xi@ferengi.borderworlds.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5FD8237B401; Mon, 14 Oct 2002 06:27:38 -0700 (PDT)
Received: from ferengi.borderworlds.dk (ferengi.borderworlds.dk [62.79.81.106])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 362EE43EB7; Mon, 14 Oct 2002 06:27:37 -0700 (PDT)
	(envelope-from xi@ferengi.borderworlds.dk)
Received: from ferengi.borderworlds.dk (localhost [127.0.0.1])
	by ferengi.borderworlds.dk (8.12.6/8.12.5) with ESMTP id g9EDRZdH016192;
	Mon, 14 Oct 2002 15:27:35 +0200 (CEST)
	(envelope-from xi@ferengi.borderworlds.dk)
Received: (from root@localhost)
	by ferengi.borderworlds.dk (8.12.6/8.12.6/Submit) id g9EDRYOP016191;
	Mon, 14 Oct 2002 15:27:34 +0200 (CEST)
Message-Id: <200210141327.g9EDRYOP016191@ferengi.borderworlds.dk>
Date: Mon, 14 Oct 2002 15:27:34 +0200 (CEST)
From: Christian Laursen <xi@borderworlds.dk>
Reply-To: Christian Laursen <xi@borderworlds.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jim@freebsd.org
Subject: Update X-Chat to 1.8.10 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         44051
>Category:       ports
>Synopsis:       Update X-Chat to 1.8.10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 14 06:30:03 PDT 2002
>Closed-Date:    Mon Oct 21 09:26:48 PDT 2002
>Last-Modified:  Mon Oct 21 09:26:48 PDT 2002
>Originator:     Christian Laursen <xi@borderworlds.dk>
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
The Border Worlds
>Environment:
System: FreeBSD ferengi.borderworlds.dk 4.7-STABLE FreeBSD 4.7-STABLE #31: Thu Oct 10 09:24:02 CEST 2002 root@ferengi.borderworlds.dk:/usr/obj/usr/src/sys/FERENGI i386


	
>Description:
X-Chat 1.8.10 has been available for more than 2 months now.

I notified the maintainer a month or so ago, but nothing has happened so far.
	
>How-To-Repeat:
	
>Fix:

	

--- xchat.diff begins here ---
diff -ur xchat.orig/Makefile xchat/Makefile
--- xchat.orig/Makefile	Thu Sep 12 11:11:21 2002
+++ xchat/Makefile	Mon Oct 14 15:20:24 2002
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=		xchat
-PORTVERSION=		1.8.9
+PORTVERSION=		1.8.10
 CATEGORIES+=		irc gnome ipv6
 MASTER_SITES=		http://xchat.org/files/source/1.8/ \
 			http://xchat.linuxpower.org/files/source/1.8/
diff -ur xchat.orig/distinfo xchat/distinfo
--- xchat.orig/distinfo	Sun Jun  2 13:38:14 2002
+++ xchat/distinfo	Mon Oct 14 15:21:22 2002
@@ -1 +1 @@
-MD5 (xchat-1.8.9.tar.bz2) = a7d3723053fbee23399647f88afd15fa
+MD5 (xchat-1.8.10.tar.bz2) = 9295830df5d040d7723620322a65f89c
--- xchat.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Christian Laursen <xi@borderworlds.dk>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/44051: Update X-Chat to 1.8.10
Date: 14 Oct 2002 16:21:36 +0200

 Christian Laursen <xi@borderworlds.dk> writes:
 
 > >Number:         44051
 > >Category:       ports
 > >Synopsis:       Update X-Chat to 1.8.10
 
 Hmm, this doesn't seem to work. The build is broken somehow.
 I'll need to figure it out and send an updated diff.
 
 -- 
 Best regards
     Christian Laursen
Responsible-Changed-From-To: freebsd-ports->jim 
Responsible-Changed-By: ijliao 
Responsible-Changed-When: Mon Oct 14 07:27:14 PDT 2002 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44051 

From: Christian Laursen <dev-null@borderworlds.dk>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: jim@freebsd.org
Subject: Re: ports/44051: Update X-Chat to 1.8.10
Date: 14 Oct 2002 20:32:37 +0200

 Christian Laursen <xi@borderworlds.dk> writes:
 
 > The following reply was made to PR ports/44051; it has been noted by GNATS.
 > 
 > From: Christian Laursen <xi@borderworlds.dk>
 > To: FreeBSD-gnats-submit@FreeBSD.org
 > Cc:  
 > Subject: Re: ports/44051: Update X-Chat to 1.8.10
 > Date: 14 Oct 2002 16:21:36 +0200
 > 
 >  Christian Laursen <xi@borderworlds.dk> writes:
 >  
 >  > >Number:         44051
 >  > >Category:       ports
 >  > >Synopsis:       Update X-Chat to 1.8.10
 >  
 >  Hmm, this doesn't seem to work. The build is broken somehow.
 >  I'll need to figure it out and send an updated diff.
 
 It seems to be NLS that is broken somehow.
 
 Either someone needs to fix that, or it can just be disabled.
 
 This patch does the latter.
 
 diff -ur xchat.orig/Makefile xchat/Makefile
 --- xchat.orig/Makefile	Sun Sep  8 05:47:52 2002
 +++ xchat/Makefile	Mon Oct 14 20:04:13 2002
 @@ -6,7 +6,7 @@
  #
  
  PORTNAME=		xchat
 -PORTVERSION=		1.8.9
 +PORTVERSION=		1.8.10
  CATEGORIES+=		irc gnome ipv6
  MASTER_SITES=		http://xchat.org/files/source/1.8/ \
  			http://xchat.linuxpower.org/files/source/1.8/
 @@ -31,7 +31,7 @@
  CONFIGURE_ENV+=		CPPFLAGS="-I${LOCALBASE}/include" \
  			LIBS="-L${LOCALBASE}/lib -lintl -liconv"
  CONFIGURE_ARGS+=	--without-included-gettext \
 -			--enable-nls \
 +			--disable-nls \
  			--enable-ipv6 \
  			--datadir="${PREFIX}/share" \
  			--enable-perl
 diff -ur xchat.orig/distinfo xchat/distinfo
 --- xchat.orig/distinfo	Sun May 26 01:19:43 2002
 +++ xchat/distinfo	Mon Oct 14 19:40:21 2002
 @@ -1 +1 @@
 -MD5 (xchat-1.8.9.tar.bz2) = a7d3723053fbee23399647f88afd15fa
 +MD5 (xchat-1.8.10.tar.bz2) = 9295830df5d040d7723620322a65f89c
 diff -ur xchat.orig/pkg-plist xchat/pkg-plist
 --- xchat.orig/pkg-plist	Fri Jan 11 03:00:24 2002
 +++ xchat/pkg-plist	Mon Oct 14 20:20:04 2002
 @@ -17,32 +17,3 @@
  %%GNOME:%%share/gnome/apps/Internet/xchat.desktop
  %%GNOME:%%share/gnome/pixmaps/xchat.png
  %%PORTDOCS%%@dirrm share/doc/xchat
 -share/locale/ca/LC_MESSAGES/xchat.mo
 -share/locale/cs/LC_MESSAGES/xchat.mo
 -share/locale/da/LC_MESSAGES/xchat.mo
 -share/locale/de/LC_MESSAGES/xchat.mo
 -share/locale/el/LC_MESSAGES/xchat.mo
 -share/locale/es/LC_MESSAGES/xchat.mo
 -share/locale/fi/LC_MESSAGES/xchat.mo
 -share/locale/fr/LC_MESSAGES/xchat.mo
 -share/locale/he/LC_MESSAGES/xchat.mo
 -share/locale/hu/LC_MESSAGES/xchat.mo
 -share/locale/it/LC_MESSAGES/xchat.mo
 -share/locale/ja/LC_MESSAGES/xchat.mo
 -share/locale/ko/LC_MESSAGES/xchat.mo
 -share/locale/lt/LC_MESSAGES/xchat.mo
 -share/locale/lv/LC_MESSAGES/xchat.mo
 -share/locale/nl/LC_MESSAGES/xchat.mo
 -share/locale/no/LC_MESSAGES/xchat.mo
 -share/locale/pt/LC_MESSAGES/xchat.mo
 -share/locale/pt_BR/LC_MESSAGES/xchat.mo
 -share/locale/ro/LC_MESSAGES/xchat.mo
 -share/locale/ru/LC_MESSAGES/xchat.mo
 -share/locale/sk/LC_MESSAGES/xchat.mo
 -share/locale/sl/LC_MESSAGES/xchat.mo
 -share/locale/sr/LC_MESSAGES/xchat.mo
 -share/locale/sv/LC_MESSAGES/xchat.mo
 -share/locale/tr/LC_MESSAGES/xchat.mo
 -share/locale/uk/LC_MESSAGES/xchat.mo
 -share/locale/zh_CN/LC_MESSAGES/xchat.mo
 -share/locale/zh_TW.Big5/LC_MESSAGES/xchat.mo
 
 
 -- 
 Best regards
     Christian Laursen

From: Jim Mock <jim@FreeBSD.org>
To: Christian Laursen <xi@borderworlds.dk>
Cc: FreeBSD-gnats-submit@FreeBSD.org, gnome@FreeBSD.org
Subject: Re: ports/44051: Update X-Chat to 1.8.10
Date: 15 Oct 2002 01:04:15 -0700

 On Mon, 14 Oct 2002 at 20:32:37 +0200, Christian Laursen wrote:
 > Christian Laursen <xi@borderworlds.dk> writes:
 > >  > >Number:         44051
 > >  > >Category:       ports
 > >  > >Synopsis:       Update X-Chat to 1.8.10
 > >  
 > >  Hmm, this doesn't seem to work. The build is broken somehow.
 > >  I'll need to figure it out and send an updated diff.
 > 
 > It seems to be NLS that is broken somehow.
 > 
 > Either someone needs to fix that, or it can just be disabled.
 
 This is exactly why it hasn't been updated yet.  Also, the fact that
 none of the about 10 people who "let me know" 1.8.10 was out didn't
 include any diffs.  I currently don't have access to a FreeBSD machine
 with X on it, so no working diffs == no update.  I did have the ability
 to test it a month or two ago (shortly after 1.8.10 came out) but didn't
 get a chance to look into the NLS issue before I lost my connectivity
 and boxes with X.
 
 Disabling NLS support does (or did when I tested it) seem to work, but
 that seems like a fairly crappy option when the current ported version
 actually builds with NLS support.
 
 I've Cc'd gnome@FreeBSD.org on this to see if anybody shows interest in
 looking into the NLS stuff.  If not, and there's enough demand where
 users want the upgrade and don't care about the NLS support, I'll commit
 it.  I'll give it a week or so.
 
 - jim
 
 -- 
 jim mock <mij@soupnazi.org>                            jim@FreeBSD.org

From: Joe Marcus Clarke <marcus@marcuscom.com>
To: jim@FreeBSD.ORG
Cc: Christian Laursen <xi@borderworlds.dk>,
	FreeBSD-gnats-submit@FreeBSD.ORG, gnome@FreeBSD.ORG
Subject: Re: ports/44051: Update X-Chat to 1.8.10
Date: 15 Oct 2002 11:53:24 -0400

 On Tue, 2002-10-15 at 04:04, Jim Mock wrote:
 > On Mon, 14 Oct 2002 at 20:32:37 +0200, Christian Laursen wrote:
 > > Christian Laursen <xi@borderworlds.dk> writes:
 > > >  > >Number:         44051
 > > >  > >Category:       ports
 > > >  > >Synopsis:       Update X-Chat to 1.8.10
 > > >  
 > > >  Hmm, this doesn't seem to work. The build is broken somehow.
 > > >  I'll need to figure it out and send an updated diff.
 > > 
 > > It seems to be NLS that is broken somehow.
 > > 
 > > Either someone needs to fix that, or it can just be disabled.
 > 
 > This is exactly why it hasn't been updated yet.  Also, the fact that
 > none of the about 10 people who "let me know" 1.8.10 was out didn't
 > include any diffs.  I currently don't have access to a FreeBSD machine
 > with X on it, so no working diffs == no update.  I did have the ability
 > to test it a month or two ago (shortly after 1.8.10 came out) but didn't
 > get a chance to look into the NLS issue before I lost my connectivity
 > and boxes with X.
 > 
 > Disabling NLS support does (or did when I tested it) seem to work, but
 > that seems like a fairly crappy option when the current ported version
 > actually builds with NLS support.
 > 
 > I've Cc'd gnome@FreeBSD.org on this to see if anybody shows interest in
 > looking into the NLS stuff.  If not, and there's enough demand where
 > users want the upgrade and don't care about the NLS support, I'll commit
 > it.  I'll give it a week or so.
 
 I'll take a look.
 
 Joe
 
 > 
 > - jim
 > 
 > -- 
 > jim mock <mij@soupnazi.org>                            jim@FreeBSD.org
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-gnome" in the body of the message
 > 
 -- 
 PGP Key : http://www.marcuscom.com/pgp.asc
 

From: Joe Marcus Clarke <marcus@marcuscom.com>
To: jim@FreeBSD.ORG
Cc: Christian Laursen <xi@borderworlds.dk>,
	FreeBSD-gnats-submit@FreeBSD.ORG, gnome@FreeBSD.ORG
Subject: Re: ports/44051: Update X-Chat to 1.8.10
Date: 15 Oct 2002 12:22:05 -0400

 --=-plIAe3YJy7neL7W92Zrt
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 On Tue, 2002-10-15 at 04:04, Jim Mock wrote:
 > On Mon, 14 Oct 2002 at 20:32:37 +0200, Christian Laursen wrote:
 > > Christian Laursen <xi@borderworlds.dk> writes:
 > > >  > >Number:         44051
 > > >  > >Category:       ports
 > > >  > >Synopsis:       Update X-Chat to 1.8.10
 > > >  
 > > >  Hmm, this doesn't seem to work. The build is broken somehow.
 > > >  I'll need to figure it out and send an updated diff.
 > > 
 > > It seems to be NLS that is broken somehow.
 > > 
 > > Either someone needs to fix that, or it can just be disabled.
 > 
 > This is exactly why it hasn't been updated yet.  Also, the fact that
 > none of the about 10 people who "let me know" 1.8.10 was out didn't
 > include any diffs.  I currently don't have access to a FreeBSD machine
 > with X on it, so no working diffs == no update.  I did have the ability
 > to test it a month or two ago (shortly after 1.8.10 came out) but didn't
 > get a chance to look into the NLS issue before I lost my connectivity
 > and boxes with X.
 > 
 > Disabling NLS support does (or did when I tested it) seem to work, but
 > that seems like a fairly crappy option when the current ported version
 > actually builds with NLS support.
 > 
 > I've Cc'd gnome@FreeBSD.org on this to see if anybody shows interest in
 > looking into the NLS stuff.  If not, and there's enough demand where
 > users want the upgrade and don't care about the NLS support, I'll commit
 > it.  I'll give it a week or so.
 > 
 
 Here you go.  This will update the port to 1.8.10, fix the NLS issues,
 and add two plist entries.
 
 Joe
 
 
 -- 
 PGP Key : http://www.marcuscom.com/pgp.asc
 
 --=-plIAe3YJy7neL7W92Zrt
 Content-Disposition: attachment; filename=xchat.diff
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/x-patch; name=xchat.diff; charset=ISO8859-1
 
 diff -ruN xchat.orig/Makefile xchat/Makefile
 --- xchat.orig/Makefile	Tue Oct 15 12:21:10 2002
 +++ xchat/Makefile	Tue Oct 15 12:19:39 2002
 @@ -6,7 +6,7 @@
  #
 =20
  PORTNAME=3D		xchat
 -PORTVERSION=3D		1.8.9
 +PORTVERSION=3D		1.8.10
  CATEGORIES+=3D		irc gnome ipv6
  MASTER_SITES=3D		http://xchat.org/files/source/1.8/ \
  			http://xchat.linuxpower.org/files/source/1.8/
 diff -ruN xchat.orig/distinfo xchat/distinfo
 --- xchat.orig/distinfo	Tue Oct 15 12:21:10 2002
 +++ xchat/distinfo	Tue Oct 15 12:13:21 2002
 @@ -1 +1 @@
 -MD5 (xchat-1.8.9.tar.bz2) =3D a7d3723053fbee23399647f88afd15fa
 +MD5 (xchat-1.8.10.tar.bz2) =3D 9295830df5d040d7723620322a65f89c
 diff -ruN xchat.orig/files/patch-configure xchat/files/patch-configure
 --- xchat.orig/files/patch-configure	Wed Dec 31 19:00:00 1969
 +++ xchat/files/patch-configure	Tue Oct 15 12:19:00 2002
 @@ -0,0 +1,51 @@
 +--- configure.orig	Tue Oct 15 12:18:08 2002
 ++++ configure	Tue Oct 15 12:18:50 2002
 +@@ -3221,10 +3221,10 @@
 + #include "confdefs.h"
 + #include <libintl.h>
 + extern int _nl_msg_cat_cntr;
 +-extern int *_nl_domain_bindings;
 ++extern int *libintl_nl_domain_bindings;
 + int main() {
 + bindtextdomain ("", "");
 +-return (int) gettext ("") + _nl_msg_cat_cntr + *_nl_domain_bindings
 ++return (int) gettext ("") + _nl_msg_cat_cntr + *libintl_nl_domain_binding=
 s
 + ; return 0; }
 + EOF
 + if { (eval echo configure:3231: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5;=
  } && test -s conftest${ac_exeext}; then
 +@@ -3610,7 +3610,7 @@
 + #include "confdefs.h"
 + #include <libintl.h>
 + extern int _nl_msg_cat_cntr;
 +-extern int *_nl_domain_bindings;
 ++extern int *libintl_nl_domain_bindings;
 + extern
 + #ifdef __cplusplus
 + "C"
 +@@ -3618,7 +3618,7 @@
 + const char *_nl_expand_alias ();
 + int main() {
 + bindtextdomain ("", "");
 +-return (int) gettext ("") + _nl_msg_cat_cntr + *_nl_domain_bindings + *_n=
 l_expand_alias (0)
 ++return (int) gettext ("") + _nl_msg_cat_cntr + *libintl_nl_domain_binding=
 s + *_nl_expand_alias (0)
 + ; return 0; }
 + EOF
 + if { (eval echo configure:3625: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5;=
  } && test -s conftest${ac_exeext}; then
 +@@ -3638,7 +3638,7 @@
 + #include "confdefs.h"
 + #include <libintl.h>
 + extern int _nl_msg_cat_cntr;
 +-extern int *_nl_domain_bindings;
 ++extern int *libintl_nl_domain_bindings;
 + extern
 + #ifdef __cplusplus
 + "C"
 +@@ -3646,7 +3646,7 @@
 + const char *_nl_expand_alias ();
 + int main() {
 + bindtextdomain ("", "");
 +-return (int) gettext ("") + _nl_msg_cat_cntr + *_nl_domain_bindings + *_n=
 l_expand_alias (0)
 ++return (int) gettext ("") + _nl_msg_cat_cntr + *libintl_nl_domain_binding=
 s + *_nl_expand_alias (0)
 + ; return 0; }
 + EOF
 + if { (eval echo configure:3653: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5;=
  } && test -s conftest${ac_exeext}; then
 diff -ruN xchat.orig/pkg-plist xchat/pkg-plist
 --- xchat.orig/pkg-plist	Tue Oct 15 12:21:10 2002
 +++ xchat/pkg-plist	Tue Oct 15 12:20:50 2002
 @@ -34,6 +34,7 @@
  share/locale/lv/LC_MESSAGES/xchat.mo
  share/locale/nl/LC_MESSAGES/xchat.mo
  share/locale/no/LC_MESSAGES/xchat.mo
 +share/locale/pl/LC_MESSAGES/xchat.mo
  share/locale/pt/LC_MESSAGES/xchat.mo
  share/locale/pt_BR/LC_MESSAGES/xchat.mo
  share/locale/ro/LC_MESSAGES/xchat.mo
 @@ -44,5 +45,6 @@
  share/locale/sv/LC_MESSAGES/xchat.mo
  share/locale/tr/LC_MESSAGES/xchat.mo
  share/locale/uk/LC_MESSAGES/xchat.mo
 +share/locale/vi/LC_MESSAGES/xchat.mo
  share/locale/zh_CN/LC_MESSAGES/xchat.mo
  share/locale/zh_TW.Big5/LC_MESSAGES/xchat.mo
 
 --=-plIAe3YJy7neL7W92Zrt--
 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Mon Oct 21 09:26:26 PDT 2002 
State-Changed-Why:  
I just committed an update per Jim's approval.  This issue can be closed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44051 
>Unformatted:
