From nobody@FreeBSD.org  Mon Oct  7 19:57:38 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6520937B401
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  7 Oct 2002 19:57:38 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1C73943E97
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  7 Oct 2002 19:57:38 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.6/8.12.6) with ESMTP id g982vb7R046540
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 7 Oct 2002 19:57:37 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.6/8.12.6/Submit) id g982vbN2046539;
	Mon, 7 Oct 2002 19:57:37 -0700 (PDT)
Message-Id: <200210080257.g982vbN2046539@www.freebsd.org>
Date: Mon, 7 Oct 2002 19:57:37 -0700 (PDT)
From: Jamie Aczel <temperanza@softhome.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: patch for audio/gdcd
X-Send-Pr-Version: www-1.0

>Number:         43809
>Category:       ports
>Synopsis:       patch for audio/gdcd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    adamw
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 07 20:00:13 PDT 2002
>Closed-Date:    Mon May 05 20:59:54 PDT 2003
>Last-Modified:  Mon May 05 20:59:54 PDT 2003
>Originator:     Jamie Aczel
>Release:        4.7-RC
>Organization:
n/a
>Environment:
>Description:
This is a patch I hacked out to correct one build problem with gdcd, caused by a variable namechange in new versions of libcdaudio. The port builds now but segfaults in strncpy() - please get a better programer to figure out why.

I hope the shar submits properly- haven't managed to get sendmail configured so the local send-pr won't work on my machine. Sorry ._.
>How-To-Repeat:
Error I patched: Just build the port as it is.

New error:

This GDB was configured as "i386-unknown-freebsd"...
(no debugging symbols found)...
Core was generated by `gdcd'.
Program terminated with signal 11, Segmentation fault.
#0  0x285fdac8 in strncpy () from /usr/lib/libc_r.so.4
>Fix:
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	patch-ai
#
echo x - patch-ai
sed 's/^X//' >patch-ai << 'END-of-patch-ai'
X--- source/coverart.c.orig	Mon Oct  7 18:31:11 2002
X+++ source/coverart.c	Mon Oct  7 18:30:37 2002
X@@ -96,7 +96,7 @@
X 	 return NULL;
X       }
X       
X+      write(fd, art.art_image, art.art_length);
X-      write(fd, art.art_data, art.art_length);
X       close(fd);
X       
X       thread_invoke_operation(display_sock, "COVR", filename, strlen(filename));
X@@ -167,7 +167,7 @@
X 	 return NULL;
X       }
X       
X+      write(fd, art.art_image, art.art_length);
X-      write(fd, art.art_data, art.art_length);
X       close(fd);
X    } else
X       snprintf(filename, 108, "L%s.png", cddb_genre(data.data_genre));
END-of-patch-ai
exit
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->adamw 
Responsible-Changed-By: adamw 
Responsible-Changed-When: Sat Oct 19 14:53:09 PDT 2002 
Responsible-Changed-Why:  
I'll take care of this problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43809 
State-Changed-From-To: open->closed 
State-Changed-By: adamw 
State-Changed-When: Mon May 5 20:56:40 PDT 2003 
State-Changed-Why:  
gdcd doesn't seem to be actively maintained, and this problem is not 
FreeBSD-specific. I have never gotten gdcd to even start up, and the 
port is about to be removed from the tree, anyhow. 

Thanks anyway for submitting the patch, Jamie. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43809 
>Unformatted:
