From dick@ns.tar.com  Mon Aug 25 07:44:22 1997
Received: from ns.tar.com (ns.tar.com [204.95.187.2])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id HAA16149
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Aug 1997 07:44:19 -0700 (PDT)
Received: (from root@localhost)
	by ns.tar.com (8.8.7/8.8.7) id JAA04887;
	Mon, 25 Aug 1997 09:44:10 -0500 (CDT)
Message-Id: <199708251444.JAA04887@ns.tar.com>
Date: Mon, 25 Aug 1997 09:44:10 -0500 (CDT)
From: Richard Seaman <dick@ns.tar.com>
Reply-To: dick@ns.tar.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Apache build fails if mod_proxy is included in Configuration
X-Send-Pr-Version: 3.2

>Number:         4380
>Category:       ports
>Synopsis:       Apache build fails if mod_proxy is included in Configuration
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 25 07:50:00 PDT 1997
>Closed-Date:    Mon Aug 25 16:12:56 PDT 1997
>Last-Modified:  Mon Aug 25 16:13:29 PDT 1997
>Originator:     Richard Seaman, Jr.
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	
Problem exists for the port apache (Apache 1.2.1 as of this writing).

Problem exists in FreeBSB-current, but I strongly suspect it exists in
RELENG-2.2.2 also, but I can't check it.  (I also think the problem
exists for apache-current under both FreeBSD-current and RELENG-2.2.2
as well).

The problem also exists for Apache 1.2.4, not yet included in the
Apache ports tree.

>Description:

	
When mod_proxy is included in the Apache configuration, the build fails
when compiling the file proxy_cache.c.  The origin of the problem is
that the Apache port substitutes FreeBSD md5 libraries for the Apache
md5 handling, but does so incompletely in the Apache proxy library.

Note: This substitution of FreeBSD md5 library is also incomplete in
other areas (eg. in the Apache support directory, where the FreeBSD
port doesn't attempt to include anything, including even the Apache
man pages!).

Maintenance of this port would be much easier if the Apache md5
library is used instead.  After all, FreeBSD is a platform explicitly
supported by the Apache team.  However, in this case the patch
supplied below would not be necessary, but other changes to the
Apache port would be.  

I'd be happy to submit the changes necessary to revert the Apache
port to use the (default) Apache md5 library, should this be
deemed desirable.

>How-To-Repeat:

	
After installing the ports patches, edit the file src/Configuration to
include mod_proxy, which is not enabled in the default configuration.
Run the Configure script and resume the apache build.

>Fix:
	
	
Create a patch file patch-ai as follows:

*** src/modules/proxy/proxy_cache.c.orig        Mon Aug 25 08:42:45 1997 
--- src/modules/proxy/proxy_cache.c     Mon Aug 25 08:43:38 1997         
***************                                                          
*** 52,58 ****                                                           
                                                                         
  /* Cache and garbage collection routines for Apache proxy */           
                                                                         
! #include "md5.h"                                                       
                                                                         
  #include "mod_proxy.h"                                                 
  #include "http_log.h"                                                  
--- 52,59 ----                                                           
                                                                         
  /* Cache and garbage collection routines for Apache proxy */           
                                                                         
! #include <sys/types.h>                                                 
! #include <md5.h>                                                       
                                                                         
  #include "mod_proxy.h"                                                 
  #include "http_log.h"                                                  

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ache 
State-Changed-When: Mon Aug 25 16:12:56 PDT 1997 
State-Changed-Why:  
FreeBSD md5 substitution removed 
>Unformatted:
