From ernst@localhost.jollem.com  Mon Sep 30 11:35:58 2002
Return-Path: <ernst@localhost.jollem.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C4E8537B404; Mon, 30 Sep 2002 11:35:58 -0700 (PDT)
Received: from localhost.jollem.com (uds241-44.dial.hccnet.nl [62.251.44.241])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 22E3443E4A; Mon, 30 Sep 2002 11:35:51 -0700 (PDT)
	(envelope-from ernst@localhost.jollem.com)
Received: from localhost.jollem.com (localhost.jollem.com [127.0.0.1])
	by localhost.jollem.com (8.12.5/8.12.5) with ESMTP id g8UIZmf1000891;
	Mon, 30 Sep 2002 20:35:48 +0200 (CEST)
	(envelope-from ernst@localhost.jollem.com)
Received: (from ernst@localhost)
	by localhost.jollem.com (8.12.5/8.12.5/Submit) id g8UIZmUC000890;
	Mon, 30 Sep 2002 20:35:48 +0200 (CEST)
Message-Id: <200209301835.g8UIZmUC000890@localhost.jollem.com>
Date: Mon, 30 Sep 2002 20:35:48 +0200 (CEST)
From: Ernst de Haan <znerd@freebsd.org>
Reply-To: Ernst de Haan <znerd@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: mharo@freebsd.org
Subject: portlint 2.3.3 does not handle URLs that end in '.html'
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         43537
>Category:       ports
>Synopsis:       portlint 2.3.3 does not handle URLs that end in '.html'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 30 11:40:01 PDT 2002
>Closed-Date:    Sat Jul 19 17:32:39 PDT 2003
>Last-Modified:  Sat Jul 19 17:32:39 PDT 2003
>Originator:     Ernst de Haan
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD heinz 4.6-STABLE FreeBSD 4.6-STABLE #2: Wed Aug 28 23:38:45 CEST 2002 root@heinz:/usr/obj/usr/src/sys/HEINZ i386
>Description:
When I run portlint on ports/java/jdk12, I get
>How-To-Repeat:
# cd /usr/ports/java/jdk12
# portlint
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-comment.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-descr.
OK: checking Makefile.
WARN: Makefile 85: whitespace before end of line.
WARN: possible direct use of command "awk" found. use ${AWK} instead.
WARN: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: possible use of absolute pathname "/usr/bin/cpio", in Makefile.
FATAL: URL "http://www.sun.com/software/java2/download.html" should end with "/".
WARN: extra item placed in the *_DEPENDS section.
WARN: "PKGNAMESUFFIX" has to appear earlier in Makefile.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/distinfo.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/files/patch-aa.
1 fatal errors and 6 warnings found.

The 'FATAL' line is incorrect IMO.
>Fix:
Suggestion:

See if the filename ends with .html or .htm and allow that too. But then
perhaps you should extend this to allow any URL if it ends with:

	/[^/]+\.[^/]+$

So that's a / followed by a number of non-slash characters, followed by a dot,
followed by another number of non-slash characters.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->mharo 
Responsible-Changed-By: znerd 
Responsible-Changed-When: Mon Sep 30 12:24:01 PDT 2002 
Responsible-Changed-Why:  
Over to MAINTAINER. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43537 

From: Edwin Groothuis <edwin@mavetju.org>
To: Ernst de Haan <znerd@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org, mharo@FreeBSD.org
Subject: Re: ports/43537: portlint 2.3.3 does not handle URLs that end in '.html'
Date: Tue, 1 Oct 2002 09:04:56 +1000

 On Mon, Sep 30, 2002 at 08:35:48PM +0200, Ernst de Haan wrote:
 > 
 > >Number:         43537
 > >Category:       ports
 > >Synopsis:       portlint 2.3.3 does not handle URLs that end in '.html'
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-ports
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          change-request
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Mon Sep 30 11:40:01 PDT 2002
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Ernst de Haan
 > >Release:        FreeBSD 4.6-STABLE i386
 > >Organization:
 > FreeBSD Project
 > >Environment:
 > System: FreeBSD heinz 4.6-STABLE FreeBSD 4.6-STABLE #2: Wed Aug 28 23:38:45 CEST 2002 root@heinz:/usr/obj/usr/src/sys/HEINZ i386
 > >Description:
 > When I run portlint on ports/java/jdk12, I get
 > >How-To-Repeat:
 > # cd /usr/ports/java/jdk12
 > # portlint
 > OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-comment.
 > OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-descr.
 > OK: checking Makefile.
 > WARN: Makefile 85: whitespace before end of line.
 > WARN: possible direct use of command "awk" found. use ${AWK} instead.
 > WARN: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
 > WARN: possible use of absolute pathname "/usr/bin/cpio", in Makefile.
 > FATAL: URL "http://www.sun.com/software/java2/download.html" should end with "/".
 > WARN: extra item placed in the *_DEPENDS section.
 > WARN: "PKGNAMESUFFIX" has to appear earlier in Makefile.
 > OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/distinfo.
 > OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/files/patch-aa.
 > 1 fatal errors and 6 warnings found.
 > 
 > The 'FATAL' line is incorrect IMO.
 
 I don't agree with you that the URL on the FATAL line is incorrect(*),
 but I do disagree with you that the message is incorrect.
 
 Please check the Makefile, it has as MASTER_SITES:
 MASTER_SITES=   # http://www.sun.com/software/java2/download.html
 #                http://www.eyesbeyond.com/freebsddom/java/jdk.html
 
 Actually, this is "MASTER_SITES= " (verified with make -V MASTER_SITES).
 Portlint doesn't pick this up because it thinks that the string "#
 http://www.sun.com/software/java2/download.html" is the value for
 MASTER_SITES.
 
 So portlint should be taught[sp, past tense of to teach] that it
 should ignore everything after the #. But not for everything, only
 for lines which don't have # at the first character:
 
 --- /tmp/portlint	Tue Oct  1 08:31:35 2002
 +++ portlint	Tue Oct  1 08:44:22 2002
 @@ -706,6 +706,7 @@
  #			next;
  #		}
  #		next if ($tmp);
 +		s/^(.+)#.*?([\t ]*)$/$1$2/;
  		$rawwhole .= $_;
  	}
  	close(IN);
 
 With this patch, portlint gives me not the FATAL about the URL.
 
 (*) It is incorrect for the ports-system because the ports system
     will just append ${PORTNAME}-${PORTVERSION} to it, making it
     http://www/blaat.htmljdk-1.2.tar.gz which 404s as well. Maybe
     support for http://www/blaat?jdk-1.2.tar.gz should be added?
 
 Edwin
 
 -- 
 Edwin Groothuis      |            Personal website: http://www.MavEtJu.org
 edwin@mavetju.org    |    Weblog: http://www.mavetju.org/weblog/weblog.php 
 bash$ :(){ :|:&};:   | Interested in MUDs? http://www.FatalDimensions.org/
Responsible-Changed-From-To: mharo->ports-bugs 
Responsible-Changed-By: mharo 
Responsible-Changed-When: Wed Jul 16 21:36:51 PDT 2003 
Responsible-Changed-Why:  
no longer maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=24651 
Responsible-Changed-From-To: mharo->ports-bugs 
Responsible-Changed-By: mharo 
Responsible-Changed-When: Wed Jul 16 21:36:51 PDT 2003 
Responsible-Changed-Why:  
I'm no longer the maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39487 
Responsible-Changed-From-To: mharo->ports-bugs 
Responsible-Changed-By: mharo 
Responsible-Changed-When: Wed Jul 16 21:36:51 PDT 2003 
Responsible-Changed-Why:  
I'm no longer the maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43537 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat Jul 19 17:32:25 PDT 2003 
State-Changed-Why:  
Fixed, thanks for reporting! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43537 
>Unformatted:
