From nobody@FreeBSD.org  Sun Sep 29 13:41:00 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A888937B401
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Sep 2002 13:41:00 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4612B43E3B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Sep 2002 13:41:00 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.6/8.12.6) with ESMTP id g8TKep7R008006
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Sep 2002 13:40:51 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.6/8.12.6/Submit) id g8TKepVh008005;
	Sun, 29 Sep 2002 13:40:51 -0700 (PDT)
Message-Id: <200209292040.g8TKepVh008005@www.freebsd.org>
Date: Sun, 29 Sep 2002 13:40:51 -0700 (PDT)
From: "Christopher H. Laco" <chris.laco@threetech.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: p5-XML-Sablotron v.96 fails to build under Perl  < 5.6.x
X-Send-Pr-Version: www-1.0

>Number:         43485
>Category:       ports
>Synopsis:       p5-XML-Sablotron v.96 fails to build under Perl  < 5.6.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    skv
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 29 13:50:02 PDT 2002
>Closed-Date:    Tue Nov 05 05:59:59 PST 2002
>Last-Modified:  Tue Nov 05 05:59:59 PST 2002
>Originator:     Christopher H. Laco
>Release:        4.6-STABLE
>Organization:
>Environment:
FreeBSD morpheus.internal.matrix.network 4.6-STABLE FreeBSD 4.6-STABLE #2: Thu Aug 15 22:31:55 EDT 2002     claco@morpheus.internal.matrix.network:/usr/obj/usr/src/sys/TUNED_IPF  i386
>Description:
It appears that p5-XML-Sablotron v.96 won't compile under any perl less than 5.6.x judging from the errors below.

Version .95 compiled and installed just fine.
The symptom below happen under both portupgrade and stock make install clean in the ports tree.

[root@morpheus /usr/ports] $ portupgrade p5-XML-Sablotron
--->  Upgrading 'p5-XML-Sablotron-0.95' to 'p5-XML-Sablotron-0.96' (textproc/p5-XML-Sablotron)
--->  Building '/usr/ports/textproc/p5-XML-Sablotron'
===>  Cleaning for libiconv-1.8_1
===>  Cleaning for autoconf213-2.13.000227_2
===>  Cleaning for automake14-1.4.5_2
===>  Cleaning for libtool-1.3.4_4
===>  Cleaning for m4-1.4_1
===>  Cleaning for expat-1.95.5
===>  Cleaning for Sablot-0.96_2
===>  Cleaning for p5-XML-Sablotron-0.96
===>  Extracting for p5-XML-Sablotron-0.96
>How-To-Repeat:
On a system w/ the stock perl (5.005_3) installed....

cd /usr/ports/textproc/p5-XML-Sablotron
make install clean


>Fix:
      
>Release-Note:
>Audit-Trail:

From: "Christopher H. Laco" <chrislaco@hotmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/43485: p5-XML-Sablotron v.96 fails to build under Perl < 5.6.x  
Date: Sun, 29 Sep 2002 20:08:30 -0400

 Here's a patch to the Makefile.PL; not sure how to add this to the port as
 a pre-compile patch?
 
 --------
 P.S.  Could someone nslookup 66.72.53.129 for me?
 From here and from tracrt.com, it resolves just fine, but mx1.freebsd.org is 
 griping about 'cannot find your hostname' on that IP.
 
 Thx.
 ----------
 
 
 
 --- Makefile.PL.old     Sun Sep 29 17:10:13 2002
 +++ Makefile.PL Sun Sep 29 17:10:45 2002
 @@ -35,6 +35,7 @@
 use English;
 use Config;
 use strict;
 +use vars qw($libs @extras);
 # See lib/ExtUtils/MakeMaker.pm for details of how to influence
 # the contents of the Makefile that is written.
 
 @@ -182,7 +183,7 @@
      }
 }
 
 -our $libs = '';
 +$libs = '';
 
 if ($js_found || $js_libpath) {
      $libs = "-l$js_libname $libs" if $js_libname;
 @@ -205,7 +206,6 @@
 $inc = "-I$sablot_incpath $inc"
    if $sablot_incpath;
 
 -our @extras;
 push(@extras, INC => $inc) if $inc;
 
 push(@extras, CAPI => 'TRUE')
 
 
 
 
 
 _________________________________________________________________
 Send and receive Hotmail on your mobile device: http://mobile.msn.com
 
Responsible-Changed-From-To: freebsd-ports->skv 
Responsible-Changed-By: ijliao 
Responsible-Changed-When: Mon Oct 14 06:57:23 PDT 2002 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43485 

From: "Peter LaForest" <plaforest@fish5.com>
To: <freebsd-gnats-submit@FreeBSD.org>, <chris.laco@threetech.com>
Cc:  
Subject: Re: ports/43485: p5-XML-Sablotron v.96 fails to build under Perl  < 5.6.x
Date: Thu, 24 Oct 2002 16:45:06 -0400

 Erwin,
 
 Thank you!
 
 Worked like a charm.
 
 Pete
State-Changed-From-To: open->closed 
State-Changed-By: skv 
State-Changed-When: Tue Nov 5 05:59:39 PST 2002 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43485 
>Unformatted:
 >> Checksum OK for XML-Sablotron-0.96.tar.gz.
 ===>   p5-XML-Sablotron-0.96 depends on shared library: sablot.69 - found
 ===>   p5-XML-Sablotron-0.96 depends on shared library: iconv.3 - found
 ===>  Patching for p5-XML-Sablotron-0.96
 ===>  Configuring for p5-XML-Sablotron-0.96
 Global symbol "$libs" requires explicit package name at ./Makefile.PL line 185.
 Bareword "our" not allowed while "strict subs" in use at ./Makefile.PL line 208.
 Array found where operator expected at ./Makefile.PL line 208, at end of line
         (Do you need to predeclare our?)
 syntax error at ./Makefile.PL line 208, near "our @extras"
 Global symbol "@extras" requires explicit package name at ./Makefile.PL line 208.
 Execution of ./Makefile.PL aborted due to compilation errors.
 *** Error code 255
 
 Stop in /usr/ports/textproc/p5-XML-Sablotron.
 ** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade84159.0 make
 ** Fix the problem and try again.
 ** The following packages were not installed or upgraded (*:skipped / !:failed)
         ! textproc/p5-XML-Sablotron (p5-XML-Sablotron-0.95)     (unknown build error)
 
