From grog@lemis.com  Thu Sep 26 19:30:38 2002
Return-Path: <grog@lemis.com>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B9A6B37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 26 Sep 2002 19:30:38 -0700 (PDT)
Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 99A2D43E65
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 26 Sep 2002 19:30:37 -0700 (PDT)
	(envelope-from grog@lemis.com)
Received: by wantadilla.lemis.com (Postfix, from userid 1004)
	id 0298E8147C; Fri, 27 Sep 2002 12:00:34 +0930 (CST)
Message-Id: <20020927023034.0298E8147C@wantadilla.lemis.com>
Date: Fri, 27 Sep 2002 12:00:34 +0930 (CST)
From: Greg 'groggy' Lehey <grog@lemis.com>
Reply-To: Greg 'groggy' Lehey <grog@lemis.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: graphics/mpeg2play does not install documentation
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         43408
>Category:       ports
>Synopsis:       graphics/mpeg2play does not install documentation
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 26 19:40:01 PDT 2002
>Closed-Date:    Mon May 19 17:53:56 CEST 2003
>Last-Modified:  Mon May 19 17:53:56 CEST 2003
>Originator:     Greg 'groggy' Lehey
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
LEMIS (SA) Pty Ltd
>Environment:
System: FreeBSD wantadilla.lemis.com 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Dec 31 19:08:24 CST 2001 grog@monorchid.lemis.com:/src/FreeBSD/5-CURRENT-MONORCHID/src/sys/i386/compile/MONORCHID i386

	Not release specific.
>Description:
	The graphics/mpeg2play port does not install any documentation.

>How-To-Repeat:
	cd /usr/ports/graphics/mpeg2play
	make install
>Fix:

	The problem is, of course, that the port barely has any
	documentation.  There is README, however; this should be
	installed in /usr/share/doc/mpeg2play.



>Release-Note:
>Audit-Trail:

From: dirk.meyer@dinoex.sub.org (Dirk Meyer)
To: charnier@lirmm.fr, freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/43408: graphics/mpeg2play does not install
	documentation
Date: Sun, 18 May 2003 10:19:51 +0200

 This patch installs the README, if NOPORTDOCS is not defined.
 any objections to commit this?
 
 kind regards Dirk
 
 - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
 - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/multimedia/mpeg2play/Makefile,v
 retrieving revision 1.10
 diff -u -r1.10 Makefile
 --- Makefile	4 Apr 2003 01:38:38 -0000	1.10
 +++ Makefile	18 May 2003 08:17:36 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	mpeg2play
  PORTVERSION=	1.1b
 +PORTREVISION=	1
  CATEGORIES=	multimedia
  MASTER_SITES=	ftp://ftp.funet.fi/pub/graphics/packages/mpeg/mpeg2play/
  
 @@ -20,5 +21,9 @@
  do-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/mpeg2play ${PREFIX}/bin
  	${INSTALL_DATA} ${WRKSRC}/Mpeg2play ${PREFIX}/lib/X11/app-defaults
 +.if !defined(NOPORTDOCS)
 +	${MKDIR} ${DOCSDIR}
 +	${CP} ${WRKSRC}/README ${DOCSDIR}/README
 +.endif
  
  .include <bsd.port.mk>
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/multimedia/mpeg2play/pkg-plist,v
 retrieving revision 1.2
 diff -u -r1.2 pkg-plist
 --- pkg-plist	12 Aug 1997 06:56:30 -0000	1.2
 +++ pkg-plist	18 May 2003 08:17:36 -0000
 @@ -1,2 +1,4 @@
  bin/mpeg2play
  lib/X11/app-defaults/Mpeg2play
 +%%PORTDOCS%%share/doc/mpeg2play/README
 +%%PORTDOCS%%@dirrm share/doc/mpeg2play

From: KATO Tsuguru <tkato@prontomail.com>
To: Dirk Meyer <dirk.meyer@dinoex.sub.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/43408: graphics/mpeg2play does not install documentation
Date: Sun, 18 May 2003 19:09:37 +0900

 On Sun, 18 May 2003 01:30:05 -0700 (PDT)
 dirk.meyer@dinoex.sub.org (Dirk Meyer) wrote:
 
 >  any objections to commit this?
 
 I suppose
 
 >  +	${CP} ${WRKSRC}/README ${DOCSDIR}/README
 
 had better be replaced with
 
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Mon May 19 17:52:59 CEST 2003 
State-Changed-Why:  
pacth to add docs has been committed. 


Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Mon May 19 17:52:59 CEST 2003 
Responsible-Changed-Why:  
I have looked inth this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43408 
>Unformatted:
