From dchapes@ddm.wox.org  Fri Aug 16 17:40:32 2002
Return-Path: <dchapes@ddm.wox.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0F3EC37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 16 Aug 2002 17:40:32 -0700 (PDT)
Received: from squigy.ddm.wox.org (p5b.neon.sentex.ca [64.7.130.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 45FE543E6A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 16 Aug 2002 17:40:29 -0700 (PDT)
	(envelope-from dchapes@ddm.wox.org)
Received: from rama.ddm.wox.org (rama.ddm.wox.org [204.50.152.20])
	by squigy.ddm.wox.org (Postfix) with ESMTP
	id 9640D8B802; Fri, 16 Aug 2002 20:40:27 -0400 (EDT)
Received: by rama.ddm.wox.org (Postfix, from userid 5000)
	id 29C2272DE0; Fri, 16 Aug 2002 20:40:25 -0400 (EDT)
Message-Id: <20020817004024.GA43808@ddm.wox.org>
Date: Fri, 16 Aug 2002 20:40:24 -0400
From: Dave Chapeskie <bsdport@ddm.wox.org>
Reply-To: Dave Chapeskie <bsdport@ddm.wox.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: girgen@partitur.se
Subject: postgresql-odbc change request [PATCH]
X-Send-Pr-Version: 3.113

>Number:         41739
>Category:       ports
>Synopsis:       postgresql-odbc support for unixodbc [PATCH]
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 16 17:50:01 PDT 2002
>Closed-Date:    Mon Dec 23 12:09:24 PST 2002
>Last-Modified:  Mon Dec 23 12:09:24 PST 2002
>Originator:     Dave Chapeskie
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
DDM Consulting
>Environment:
System: FreeBSD rama.ddm.wox.org 4.5-STABLE FreeBSD 4.5-STABLE #0: Sat Mar 2 16:42:36 EST 2002 dchapes@rama.ddm.wox.org:/stripe0/usr/obj/stripe0/usr/src/sys/RAMA i386

>Description:

I have need of the unixodbc version of the PostgreSQL odbc drivers and
need to have other packages depend on it.  Thus I not only need the
compilation option provided in the port makefile via the DRIVER_MANAGER
variable but I also need the name of the produced package to be
different from the normal one.

The standard way of indicating compilation options in package names is
by the use of PKGNAMESUFFIX.  I've attached a patch which does this.
It's done so that the current default package name doesn't change.
Using -iodbc instead of the current -odbc would probably be better but
that would entail changing the current default package name and breaking
existing dependencies.

>How-To-Repeat:

>Fix:

Index: Makefile
===================================================================
RCS file: /cvs/ports/databases/postgresql-odbc/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	11 Apr 2002 05:08:34 -0000	1.2
+++ Makefile	15 Aug 2002 20:53:07 -0000
@@ -5,7 +5,7 @@
 # $FreeBSD: ports/databases/postgresql-odbc/Makefile,v 1.2 2002/04/11
05:08:34 ijliao Exp $
 #
 
-PORTNAME=	postgresql-odbc
+PORTNAME=	postgresql
 CATEGORIES=	databases
 
 MAINTAINER=	girgen@partitur.se
@@ -30,10 +30,12 @@
 # folks say their is the best, so you might be better off removing
 # the others?
 .if ${DRIVER_MANAGER} == "unixodbc"
+PKGNAMESUFFIX=		-unixodbc
 CONFIGURE_ARGS+=	--with-unixodbc
 LIB_DEPENDS+=		odbc.1:${PORTSDIR}/databases/unixODBC
 PLIST_SUB+=UNIXODBC="" IODBC="@comment "
 .else	# assume we're using iodbc
+PKGNAMESUFFIX=		-odbc
 LIB_DEPENDS+=		iodbc.3:${PORTSDIR}/databases/libiodbc
 CONFIGURE_ARGS+=	--with-iodbc
--with-odbcinst=${LOCALBASE}/etc/libiodbc
 PLIST_SUB+=UNIXODBC="@comment " IODBC=""

>Release-Note:
>Audit-Trail:

From: Palle Girgensohn <girgen@pingpong.net>
To: Dave Chapeskie <bsdport@ddm.wox.org>,
	FreeBSD-gnats-submit@FreeBSD.ORG
Cc:  
Subject: Re: ports/41739: postgresql-odbc change request [PATCH]
Date: Tue, 20 Aug 2002 11:27:09 +0200

 Hi,
 
 As the maintainer, I like what I see. Anyone who has the right to commit, 
 please do so. Just don't bump any PORTREVISIONs, please.
 
 Cheers,
 Palle
 

From: Palle Girgensohn <girgen@partitur.se>
To: freebsd-gnats-submit@FreeBSD.org, bsdport@ddm.wox.org
Cc:  
Subject: Re: ports/41739: postgresql-odbc support for unixodbc [PATCH]
Date: Mon, 26 Aug 2002 00:41:27 +0200

 Please commit this PR.
 
 /Palle (Maintainer)
 
State-Changed-From-To: open->closed 
State-Changed-By: okazaki 
State-Changed-When: Mon Dec 23 12:08:35 PST 2002 
State-Changed-Why:  
superseded by ports/45882 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41739 
>Unformatted:
