From alane@wwweasel.geeksrus.net  Tue Aug 13 01:23:54 2002
Return-Path: <alane@wwweasel.geeksrus.net>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C896537B400; Tue, 13 Aug 2002 01:23:54 -0700 (PDT)
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 13CD043E6A; Tue, 13 Aug 2002 01:23:54 -0700 (PDT)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: from wwweasel.geeksrus.net (alane@localhost [127.0.0.1])
	by wwweasel.geeksrus.net (8.12.5/8.12.5) with ESMTP id g7D8NSsU048781;
	Tue, 13 Aug 2002 04:23:28 -0400 (EDT)
	(envelope-from alane@wwweasel.geeksrus.net)
Received: (from alane@localhost)
	by wwweasel.geeksrus.net (8.12.5/8.12.5/Submit) id g7D8NSS2048780;
	Tue, 13 Aug 2002 04:23:28 -0400 (EDT)
	(envelope-from alane)
Message-Id: <200208130823.g7D8NSS2048780@wwweasel.geeksrus.net>
Date: Tue, 13 Aug 2002 04:23:28 -0400 (EDT)
From: Alan Eldridge <ports@geeksrus.net>
Reply-To: Alan Eldridge <ports@geeksrus.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: anholt@freebsd.org
Subject: x11/XFree86-4 metaport: if make target is 'package', make indiv pkgs (POLA)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         41606
>Category:       ports
>Synopsis:       x11/XFree86-4 metaport: if make target is 'package', make indiv pkgs (POLA)
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    anholt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 13 01:30:02 PDT 2002
>Closed-Date:    Thu Jan 09 14:16:40 PST 2003
>Last-Modified:  Thu Jan 09 14:16:40 PST 2003
>Originator:     Alan Eldridge
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.6-STABLE FreeBSD 4.6-STABLE #0: Wed Aug 7 21:42:28 EDT 2002 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/WWWEASEL i386

>Description:

It is reasonable that if the user did a make package on the metaport, that
(s)he would expect that individual ports would have packages made. I made this
same patch for the kde3 metaport after speaking with some non-developer users
and consulting with will.

Should go in pre-4.7.

This patch also forces a recursive make clean to solve "abnormal" make failures
that are reported from time to time by users (like "it skipped package X").
This is temporary until a bsd.port.mk fix is committed (RSN).

Finally, removes extra whitespace that makes portlint bitch.

>How-To-Repeat:
>Fix:

==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
--- Makefile	Sat Jul 20 06:12:59 2002
+++ Makefile.new	Sat Jul 20 11:48:45 2002
@@ -14,6 +14,8 @@
 DISTFILES=	# none
 EXTRACT_ONLY=	# none
 
+MAINTAINER=	anholt@FreeBSD.org
+
 LIB_DEPENDS=	Xft.1:${PORTSDIR}/x11/XFree86-4-libraries
 RUN_DEPENDS=	xvinfo:${PORTSDIR}/x11/XFree86-4-clients \
 	${X11BASE}/lib/X11/doc/ddx.TXT:${PORTSDIR}/x11/XFree86-4-documents \
@@ -26,9 +28,6 @@
 	${X11BASE}/bin/xf86cfg:${PORTSDIR}/x11-servers/XFree86-4-Server \
 	${X11BASE}/bin/Xwrapper-4:${PORTSDIR}/x11/wrapper
 
-
-MAINTAINER=	anholt@FreeBSD.org
-
 NO_BUILD=	yes
 LATEST_LINK=	XFree86
 FONT100DPI=	${X11BASE}/lib/X11/fonts/100dpi/UTBI__10-ISO8859-1.pcf.gz
@@ -36,6 +35,13 @@
 FONTCYR=	${X11BASE}/lib/X11/fonts/cyrillic/crox1c.pcf.gz
 FONTDEFAULT=	${X11BASE}/lib/X11/fonts/misc/cursor.pcf.gz
 FONTSCALE=	${X11BASE}/lib/X11/fonts/PEX/Roman.phont
+
+.if make(package)
+DEPENDS_TARGET="package"
+.endif
+
+.undef NOCLEANDEPENDS
+pre-everything: clean
 
 do-install:	# empty
 
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->anholt 
Responsible-Changed-By: lioux 
Responsible-Changed-When: Tue Aug 13 20:42:17 PDT 2002 
Responsible-Changed-Why:  
Over to maintainer(s) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41606 
State-Changed-From-To: open->closed 
State-Changed-By: anholt 
State-Changed-When: Thu Jan 9 14:15:58 PST 2003 
State-Changed-Why:  
This patch had been almost completely committed, and I don't think the remaining part 
(pre-everything: clean) would be good. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41606 
>Unformatted:
