From knu@iDaemons.org  Fri Aug  9 04:23:03 2002
Return-Path: <knu@iDaemons.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 838EC37B400; Fri,  9 Aug 2002 04:23:03 -0700 (PDT)
Received: from mail.musha.org (daemon.musha.org [210.189.104.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0AA8443E6E; Fri,  9 Aug 2002 04:23:03 -0700 (PDT)
	(envelope-from knu@iDaemons.org)
Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32])
	by mail.musha.org (Postfix) with ESMTP
	id 2319A519BF; Fri,  9 Aug 2002 20:23:02 +0900 (JST)
Message-Id: <86wur0uvhl.wl@archon.local.idaemons.org>
Date: Fri, 09 Aug 2002 20:23:02 +0900
From: "Akinori MUSHA" <knu@iDaemons.org>
To: Alan Eldridge <ports@geeksrus.net>
Cc: FreeBSD-gnats-submit@freebsd.org, knu@freebsd.org
In-Reply-To: <86y9bguw7z.wl@archon.local.idaemons.org>
Subject: Re: latest portupgrade prevents make arg -DNO_IGNORE from working
References: <200208090755.g797t4C0068184@wwweasel.geeksrus.net>
	<86y9bguw7z.wl@archon.local.idaemons.org>

>Number:         41475
>Category:       ports
>Synopsis:       Re: latest portupgrade prevents make arg -DNO_IGNORE from working
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 09 04:30:02 PDT 2002
>Closed-Date:    Mon Aug 19 16:56:45 PDT 2002
>Last-Modified:  Mon Aug 19 16:56:45 PDT 2002
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 At Fri, 09 Aug 2002 20:07:12 +0900,
 I wrote:
 > As I explained above, there is a case where user is terribly hurt and
 > that's why the check was introduced.  I'll alter the code to check
 > NO_IGNORE also to solve your problem.
 
 Here's a patch, but beware, defining NO_IGNORE could be dangerous in
 some cases (ports).
 
 Index: portupgrade
 ===================================================================
 RCS file: /home/cvs/pkgtools/bin/portupgrade,v
 retrieving revision 1.182
 diff -u -1 -r1.182 portupgrade
 --- portupgrade	4 Aug 2002 22:46:15 -0000	1.182
 +++ portupgrade	9 Aug 2002 11:20:30 -0000
 @@ -1039,5 +1039,5 @@
  
 -  output = `cd #{portdir} && #{shelljoin(*cmdargs)} -V PKGNAME -V IGNORE 2>&1`.to_a
 +  output = `cd #{portdir} && #{shelljoin(*cmdargs)} -V PKGNAME -V IGNORE -V NO_IGNORE 2>&1`.to_a
  
 -  if output.size != 2
 +  if output.size != 3
      warning_message "Makefile of '#{origin}' is possibly broken:"
 @@ -1048,2 +1048,3 @@
    ignore = output[1].chomp
 +  no_ignore = !output[2].chomp.empty?
  
 @@ -1052,3 +1053,5 @@
      STDERR.puts "\t" + ignore
 -    raise IgnoreMarkError
 +    raise IgnoreMarkError unless no_ignore
 +
 +    warning_message "Proceeding anyway since NO_IGNORE is defined"
    end
 
 -- 
                      /
                     /__  __            Akinori.org / MUSHA.org
                    / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
 Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp
 
 "When I leave I don't know what I'm hoping to find
               When I leave I don't know what I'm leaving behind.."
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: keramida 
State-Changed-When: Mon Aug 19 16:56:20 PDT 2002 
State-Changed-Why:  
Followup to ports/41467 misfiled as a new PR. 


Responsible-Changed-From-To: gnats-admin->freebsd-ports 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Mon Aug 19 16:56:20 PDT 2002 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=41475 
>Unformatted:
