From nobody@FreeBSD.org  Thu Aug  8 06:35:37 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B891E37B400
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2002 06:35:37 -0700 (PDT)
Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7E99243E77
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2002 06:35:37 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g78DZbOT034288
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.4/8.12.4/Submit) id g78DZbjr034286;
	Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
Message-Id: <200208081335.g78DZbjr034286@www.freebsd.org>
Date: Thu, 8 Aug 2002 06:35:37 -0700 (PDT)
From: Jens Rehsack <rehsack@liwing.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Sablot 0.95 exports constants
X-Send-Pr-Version: www-1.0

>Number:         41447
>Category:       ports
>Synopsis:       Sablot 0.95 exports constants
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    skv
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 08 06:40:01 PDT 2002
>Closed-Date:    Wed Aug 14 08:39:48 PDT 2002
>Last-Modified:  Wed Aug 14 08:39:48 PDT 2002
>Originator:     Jens Rehsack
>Release:        4.6-STABLE
>Organization:
LiWing IT-Services
>Environment:
>Description:
The actualized sablot-port exports in sxpath.h some global constants.
This lacks C/C++ conventions who say it should be declared as
x.h:
const long int x;
x.c
const long int x = a;

This multiple export bugs if the header will included multiple times into object files of a library.
This happens in php4 - what causes my (wrong!) PR/41405.
>How-To-Repeat:
Build PHP4 with Sablot 0.95
>Fix:
--- src/engine/sxpath.h.orig	Thu Aug  8 12:59:11 2002
+++ src/engine/sxpath.h		Thu Aug  8 12:59:52 2002
@@ -66,9 +66,9 @@
 typedef void *QueryContext;
 
 /*option constants */
-const unsigned long SXPF_DISPOSE_NAMES = 1;
-const unsigned long SXPF_DISPOSE_VALUES = 2;
-const unsigned long SXPF_SUPPORTS_UNPARSED_ENTITIES = 4;
+#define SXPF_DISPOSE_NAMES 1
+#define SXPF_DISPOSE_VALUES 2
+#define SXPF_SUPPORTS_UNPARSED_ENTITIES 4
 
 /*
  *    DOM handler functions
>Release-Note:
>Audit-Trail:

From: Jens Rehsack <rehsack@liwing.de>
To: freebsd-gnats-submit@FreeBSD.org, rehsack@liwing.de
Cc:  
Subject: Re: ports/41447: Sablot 0.95 exports constants
Date: Thu, 08 Aug 2002 16:09:49 +0200

 Better patch:
 
 --- src/engine/sxpath.h.orig	Thu Aug  8 12:59:11 2002
 +++ src/engine/sxpath.h		Thu Aug  8 12:59:52 2002
 @@ -66,9 +66,9 @@
  typedef void *QueryContext;
  
  /*option constants */
 -const unsigned long SXPF_DISPOSE_NAMES = 1;
 -const unsigned long SXPF_DISPOSE_VALUES = 2;
 -const unsigned long SXPF_SUPPORTS_UNPARSED_ENTITIES = 4;
 +#define SXPF_DISPOSE_NAMES 1UL
 +#define SXPF_DISPOSE_VALUES 2UL
 +#define SXPF_SUPPORTS_UNPARSED_ENTITIES 4UL
  
  /*
   *    DOM handler functions
 
 regards
 Jens
 -- 
 L     i  W     W     W  i                 Jens Rehsack
 L        W     W     W
 L     i   W   W W   W   i  nnn    gggg    LiWing IT-Services
 L     i    W W   W W    i  n  n  g   g
 LLLL  i     W     W     i  n  n  g   g    Friesenstrae 2
                                   gggg    06112 Halle
                                      g
                                  g   g
 Tel.:  +49 - 3 45 - 5 17 05 91    ggg     e-Mail: <rehsack@liwing.de>
 Fax:   +49 - 3 45 - 5 17 05 92            http://www.liwing.de/
Responsible-Changed-From-To: freebsd-ports->skv 
Responsible-Changed-By: pat 
Responsible-Changed-When: Thu Aug 8 07:42:29 PDT 2002 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41447 
State-Changed-From-To: open->closed 
State-Changed-By: skv 
State-Changed-When: Wed Aug 14 08:38:54 PDT 2002 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41447 
>Unformatted:
