From edwin@mavetju.org  Fri Jul 12 07:05:58 2002
Return-Path: <edwin@mavetju.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7219E37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 07:05:58 -0700 (PDT)
Received: from topaz.mdcc.cx (topaz.mdcc.cx [212.204.230.141])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1404E43E31
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 07:05:58 -0700 (PDT)
	(envelope-from edwin@mavetju.org)
Received: from k7.mavetju (topaz.mdcc.cx [212.204.230.141])
	by topaz.mdcc.cx (Postfix) with ESMTP id 4ACE52B6AE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 16:05:56 +0200 (CEST)
Received: by k7.mavetju (Postfix, from userid 1001)
	id 322646A711E; Sat, 13 Jul 2002 00:05:54 +1000 (EST)
Message-Id: <20020712140554.322646A711E@k7.mavetju>
Date: Sat, 13 Jul 2002 00:05:54 +1000 (EST)
From: Edwin Groothuis <edwin@mavetju.org>
Reply-To: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] fix devel/jam REINPLACE problem
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40485
>Category:       ports
>Synopsis:       [patch] fix devel/jam REINPLACE problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    okazaki
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 12 07:10:02 PDT 2002
>Closed-Date:    Sun Aug 04 16:51:53 PDT 2002
>Last-Modified:  Sun Aug 04 16:51:53 PDT 2002
>Originator:     Edwin Groothuis
>Release:        FreeBSD 4.5-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 4.5-RELEASE FreeBSD 4.5-RELEASE #3: Mon Mar 11 13:32:05 EST 2002 edwin@k7.mavetju.org:/usr/src/sys/compile/k7 i386

>Description:

The new REINPLACE_CMD command doesn't support \t as abbrevation for
tab and the makefile for devel/jam needs that.

>How-To-Repeat:

cd /usr/ports/devel/jam
make

>Fix:

Note that the "spaces" after the + are tabs!

--- Makefile.old	Fri Jul 12 23:55:50 2002
+++ Makefile	Fri Jul 12 23:58:31 2002
@@ -21,7 +21,7 @@
 pre-patch:
 	@${REINPLACE_CMD} -e 's|^CC|#CC|g ; \
 		 s|^CFLAGS|#CFLAGS|g ; \
-		 s|\tjam|\t\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
+		 s|	jam|	\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
 
 do-install:
 .if ${MACHINE_ARCH} == "alpha"


ps. are you already getting sick of my PR's? :-P
>Release-Note:
>Audit-Trail:

From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Edwin Groothuis <edwin@mavetju.org>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/40485: [patch] fix devel/jam REINPLACE problem
Date: Fri, 12 Jul 2002 17:11:41 +0200

 --=.IGcGz?k3wj'p'z
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 On Sat, 13 Jul 2002 00:05:54 +1000 (EST) Edwin Groothuis wrote:
 
 > The new REINPLACE_CMD command doesn't support \t as abbrevation for
 > tab and the makefile for devel/jam needs that.
 [...]
 > --- Makefile.old	Fri Jul 12 23:55:50 2002
 > +++ Makefile	Fri Jul 12 23:58:31 2002
 > @@ -21,7 +21,7 @@
 >  pre-patch:
 >  	@${REINPLACE_CMD} -e 's|^CC|#CC|g ; \
 >  		 s|^CFLAGS|#CFLAGS|g ; \
 > -		 s|\tjam|\t\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
 > +		 s|	jam|	\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
 >  
 >  do-install:
 >  .if ${MACHINE_ARCH} == "alpha"
 
 i think a better fix for that would be a files/patch-aa like that one
 that existed until the last update ;]
 
 cheers
   simon
 
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.IGcGz?k3wj'p'z
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.7 (FreeBSD)
 
 iD8DBQE9LvG2r5S+dk6z85oRAg2aAJ9Dqc0beZhRpRNSBkfJCUd94ZERUwCdFQtv
 rxJ2irP0kRj0q8DLJaljap0=
 =+LrD
 -----END PGP SIGNATURE-----
 
 --=.IGcGz?k3wj'p'z--
 

From: Edwin Groothuis <edwin@mavetju.org>
To: Simon 'corecode' Schubert <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/40485: [patch] fix devel/jam REINPLACE problem
Date: Sat, 13 Jul 2002 01:22:52 +1000

 On Fri, Jul 12, 2002 at 05:11:41PM +0200, Simon 'corecode' Schubert wrote:
 > On Sat, 13 Jul 2002 00:05:54 +1000 (EST) Edwin Groothuis wrote:
 > 
 > > The new REINPLACE_CMD command doesn't support \t as abbrevation for
 > > tab and the makefile for devel/jam needs that.
 > [...]
 > > --- Makefile.old	Fri Jul 12 23:55:50 2002
 > > +++ Makefile	Fri Jul 12 23:58:31 2002
 > > @@ -21,7 +21,7 @@
 > >  pre-patch:
 > >  	@${REINPLACE_CMD} -e 's|^CC|#CC|g ; \
 > >  		 s|^CFLAGS|#CFLAGS|g ; \
 > > -		 s|\tjam|\t\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
 > > +		 s|	jam|	\$$\{.CURDIR\}/jam|g' ${WRKSRC}/Makefile
 > >  
 > >  do-install:
 > >  .if ${MACHINE_ARCH} == "alpha"
 > 
 > i think a better fix for that would be a files/patch-aa like that one
 > that existed until the last update ;]
        ^^^---vvv
 (Unfortunatly there is no Attic available for ports)
 
 I agree, except that I don't think(*) that it would be possible due
 to use of ${.CURDIR}.
 
 Edwin
 
 (*) Feel free to correct me if I'm wrong, I'm used to it :-)
 
 -- 
 Edwin Groothuis      |           Personal website: http://www.MavEtJu.org
 edwin@mavetju.org    |        Interested in MUDs? Visit Fatal Dimensions:
 bash$ :(){ :|:&};:   |                    http://www.FatalDimensions.org/

From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Edwin Groothuis <edwin@mavetju.org>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/40485: [patch] fix devel/jam REINPLACE problem
Date: Fri, 12 Jul 2002 17:31:25 +0200

 --=.1c0CEOQYK+dDxp
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 On Sat, 13 Jul 2002 01:22:52 +1000 Edwin Groothuis wrote:
 > > i think a better fix for that would be a files/patch-aa like that one
 > > that existed until the last update ;]
 >        ^^^---vvv
 > (Unfortunatly there is no Attic available for ports)
 
 there is. at least for me and cvsweb.cgi:
 <http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/jam/files/Attic/>
 
 > I agree, except that I don't think(*) that it would be possible due
 > to use of ${.CURDIR}.
 
 why not? i don't think there is a difference using sed or patch to
 replace ``jam0'' with ``${.CURdir}/jam0''
 
 cheers
   simon
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.1c0CEOQYK+dDxp
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.7 (FreeBSD)
 
 iD8DBQE9LvZQr5S+dk6z85oRAmKuAJ9fULRgmQQkhDHNZSa1lDhpPm4haQCaA+6F
 BAkhb4KgbZ6CVzxDoGX2YfI=
 =CnbU
 -----END PGP SIGNATURE-----
 
 --=.1c0CEOQYK+dDxp--
 

From: Edwin Groothuis <edwin@mavetju.org>
To: Simon 'corecode' Schubert <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/40485: [patch] fix devel/jam REINPLACE problem
Date: Sat, 13 Jul 2002 01:43:41 +1000

 On Fri, Jul 12, 2002 at 05:31:25PM +0200, Simon 'corecode' Schubert wrote:
 > On Sat, 13 Jul 2002 01:22:52 +1000 Edwin Groothuis wrote:
 > > > i think a better fix for that would be a files/patch-aa like that one
 > > > that existed until the last update ;]
 > >        ^^^---vvv
 > > (Unfortunatly there is no Attic available for ports)
 > 
 > there is. at least for me and cvsweb.cgi:
 > <http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/jam/files/Attic/>
 > 
 > > I agree, except that I don't think(*) that it would be possible due
 > > to use of ${.CURDIR}.
 > 
 > why not? i don't think there is a difference using sed or patch to
 > replace ``jam0'' with ``${.CURdir}/jam0''
 
 Aha, I didn't recall if ${.CURDIR} was known inside work/jam-xxx/Makefile
 or not and guessed for the "no it doesn't". You're right :-)
 
 Edwin
 
 -- 
 Edwin Groothuis      |           Personal website: http://www.MavEtJu.org
 edwin@mavetju.org    |        Interested in MUDs? Visit Fatal Dimensions:
 bash$ :(){ :|:&};:   |                    http://www.FatalDimensions.org/

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: Edwin Groothuis <edwin@mavetju.org>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/40485: [patch] fix devel/jam REINPLACE problem
Date: Sat, 13 Jul 2002 03:27:10 +0200

 On Sat, Jul 13, 2002 at 12:05:54AM +1000, Edwin Groothuis wrote:
 > 
 > >Number:         40485
 
 PR #40484 may be close since it is superceeded by this one.
 
 > >Category:       ports
 > >Synopsis:       [patch] fix devel/jam REINPLACE problem
 
 to update a PR, it is far better to submit a followup rather than to
 submit a new PR. to do so, use something like this :
 
         echo please, close this PR which was a local problem. thanks. |
 	# or cat file |
         mail -s "Re: ports/32524: Port build failed: x11-toolkits/qt23" \
         freebsd-gnats-submit@FreeBSD.org
 
 the important thing is `ports/32524'.
 
 more informations here :
 
         Writing FreeBSD Problem Reports
         http://www.FreeBSD.org/doc/en_US.ISO8859-1/articles/problem-
 
 Cyrille.
 -- 
 Cyrille Lefevre                 mailto:cyrille.lefevre@laposte.net
State-Changed-From-To: open->closed 
State-Changed-By: okazaki 
State-Changed-When: Sun Aug 4 16:44:23 PDT 2002 
State-Changed-Why:  
Fixed, thanks! 


Responsible-Changed-From-To: freebsd-ports->okazaki 
Responsible-Changed-By: okazaki 
Responsible-Changed-When: Sun Aug 4 16:44:23 PDT 2002 
Responsible-Changed-Why:  
I handled this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40485 
>Unformatted:
