From gvs@staff.rinet.ru  Sat Jun 29 07:08:16 2002
Return-Path: <gvs@staff.rinet.ru>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 584D737B408
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 29 Jun 2002 07:08:16 -0700 (PDT)
Received: from staff.rinet.ru (staff.rinet.ru [195.54.192.46])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3B94843E06
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 29 Jun 2002 07:08:15 -0700 (PDT)
	(envelope-from gvs@staff.rinet.ru)
Received: (from gvs@localhost)
	by staff.rinet.ru (8.11.6/8.11.4) id g5TE8C778581;
	Sat, 29 Jun 2002 18:08:12 +0400 (MSD)
	(envelope-from gvs)
Message-Id: <200206291408.g5TE8C778581@staff.rinet.ru>
Date: Sat, 29 Jun 2002 18:08:12 +0400 (MSD)
From: Seva Gluschenko <gvs@rinet.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: noc@rinet.ru
Subject: Makefile for netpbm port has several flaws
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39998
>Category:       ports
>Synopsis:       Makefile for netpbm port has several flaws
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 29 07:10:02 PDT 2002
>Closed-Date:    Wed Oct 09 12:05:47 PDT 2002
>Last-Modified:  Wed Oct 09 12:05:47 PDT 2002
>Originator:     Seva Gluschenko
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
Cronyx Plus LLC
>Environment:
System: FreeBSD staff.rinet.ru 4.6-STABLE FreeBSD 4.6-STABLE #3: Fri Jan 25 22:41:27 MSK 2002 root@staff.rinet.ru:/usr/obj/usr/src/sys/staff i386

>Description:
	While trying to build netpbm from ports I've found several disasters
	which prevent that port from building. First, when fetch does not find
	the port source in distfiles and attempts to fetch it from the
	master site, it tries in SourceForge:

MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR=     ${PORTNAME}

	but receives just a HTML document instead of an archive, actually.
	I think it's because of some changes in SourceForge which aren't
	reflected by port maintainer.

	Second and more principal, trying to build, I've got an error while
	applying patches. Then I untared an archive from scratch by hand and
	used a command as follows:

	> make -d l

	Here is what I got:

[skip]
===>  Applying FreeBSD patches for netpbm-10.2
cd /usr/ports/graphics/netpbm && make 'CKSUMFILES+=netpbm-10.2.tgz' post-patch
-e 's|%%X11BASE%%|/usr/X11R6|g' /usr/ports/graphics/netpbm/work/netpbm-10.2/pm_c
onfig.h
-e: not found
*** Error code 127
Stop in /usr/ports/graphics/netpbm.
*** Error code 1

	After looking in Makefile, I've found

USE_REINPLACE=  yes

	and later

post-patch:
        @${REINPLACE_CMD} -e 's|%%X11BASE%%|${X11BASE}|g' ${WRKSRC}/pm_config.h
        @${REINPLACE_CMD} -e 's|<shhopt.h>|<pm_shhopt.h>|g' ${WRKSRC}/lib/pm.h

	I don't know what is that REINPLACE_CMD. Trying

	> make -d v | grep REINPLACE_C

	produced no output. I've got a goal myself typing

	> make REINPLACE_CMD="perl -pi'.orig'"

	guessing the meaning from the variable name.

	
>How-To-Repeat:
	All the information needed is already written above.
	
>Fix:
	No fix available since I don't know the structure of embedded FreeBSD
	makefiles well enough to intrude there with my fixes.
	


>Release-Note:
>Audit-Trail:

From: Hye-Shik Chang <perky@fallin.lv>
To: freebsd-gnats-submit@FreeBSD.org, gvs@rinet.ru
Cc:  
Subject: Re: ports/39998: Makefile for netpbm port has several flaws
Date: Fri, 5 Jul 2002 15:26:16 +0900

 Can you try again after cvs up whole ports tree? (esp. Mk/)
 
 -- 
 Hye-Shik Chang <perky@fallin.lv>
 Yonsei University, Seoul
 ^D

From: Seva Gluschenko <gvs@rinet.ru>
To: Hye-Shik Chang <perky@fallin.lv>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/39998: Makefile for netpbm port has several flaws
Date: Fri, 5 Jul 2002 11:25:07 +0400 (MSD)

 Message of Hye-Shik Chang at Jul 5 15:26 ...
 
 HC> Can you try again after cvs up whole ports tree? (esp. Mk/)
 
 Well, it was, in order:
 
 cvs up -d Mk Tools
 cvs get -l -d ....
 
 etc etc
 
 however, there was some delay between CVSing Mk/Tools and CVSing
 netpbm, maybe something changed since that.
 
 SY, Seva Gluschenko, just stranger on The Road. | http://gvs.rinet.ru/
 Cronyx Plus / RiNet network administrator.      | GVS-RIPE | GVS3-RIPN
 
State-Changed-From-To: open->closed 
State-Changed-By: ijliao 
State-Changed-When: Wed Oct 9 12:05:34 PDT 2002 
State-Changed-Why:  
I think it's solved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39998 
>Unformatted:
