From lev@ftp.translate.ru  Sun Jun 16 12:33:59 2002
Return-Path: <lev@ftp.translate.ru>
Received: from ftp.translate.ru (ftp.translate.ru [195.131.4.140])
	by hub.freebsd.org (Postfix) with ESMTP id 616AC37B429
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Jun 2002 12:33:58 -0700 (PDT)
Received: (from lev@localhost)
	by ftp.translate.ru (8.11.6/8.11.2) id g5GJadl94684;
	Sun, 16 Jun 2002 23:36:39 +0400 (MSD)
	(envelope-from lev)
Message-Id: <200206161936.g5GJadl94684@ftp.translate.ru>
Date: Sun, 16 Jun 2002 23:36:39 +0400 (MSD)
From: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Reply-To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39376
>Category:       ports
>Synopsis:       Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    alane
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 16 12:40:01 PDT 2002
>Closed-Date:    Sun Jun 16 18:09:02 PDT 2002
>Last-Modified:  Sun Jun 16 20:50:01 PDT 2002
>Originator:     Lev A. Serebryakov <lev@serebryakov.spb.ru>
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD freebsd.sereb.net 4.4-STABLE FreeBSD 4.4-STABLE #1: Sat Dec 8 13:48:40 MSK 2001 root@freebsd.sereb.net:/usr/obj/usr/src/sys/LEVMAIL i386
Ports collection: 16 Jun 2002


>Description:

  This PR adds ability to build not onky KDevelop 2.1.1 for KDE3, but for
  KDE 2.2.x too. Default is KDE3, and user could specify FOR_KDE=2 on command
  line and KDevelop 2.1.1 for KDE 2.2.2 will be build.

  This PR is result of ports/39363 duscussion in ports mailing list.
	

  ADDED FILES:	
     distinfo.kde2
     distinfo.kde3
  REMOVED FILES:
     distinfo

>How-To-Repeat:
	

>Fix:
diff -ruN kdevelop.orig/Makefile kdevelop/Makefile
--- kdevelop.orig/Makefile	Sun Jun 16 23:18:21 2002
+++ kdevelop/Makefile	Sun Jun 16 23:26:59 2002
@@ -5,13 +5,22 @@
 # $FreeBSD: ports/devel/kdevelop/Makefile,v 1.46 2002/06/15 16:16:04 will Exp $
 #
 
+FOR_KDE?=	3
+
 PORTNAME=	kdevelop
 PORTVERSION=	2.1.1
 CATEGORIES?=	devel kde
 MASTER_SITES=	${MASTER_SITE_KDE}
 MASTER_SITE_SUBDIR=	stable/3.0.1/src
 DIST_SUBDIR=	KDE
+
+.if ${FOR_KDE} == 3
 DISTNAME=	${PORTNAME}-${PORTVERSION}_for_KDE_3.0
+MD5_FILE=	${MASTERDIR}/distinfo.kde3
+.elif ${FOR_KDE} == 2
+DISTNAME=	${PORTNAME}-${PORTVERSION}_for_KDE_2.2
+MD5_FILE=	${MASTERDIR}/distinfo.kde2
+.endif
 
 MAINTAINER?=	kde@FreeBSD.org
 
@@ -19,14 +28,14 @@
 .if defined(WITH_OPTIONAL_DEPENDS)
 RUN_DEPENDS+=	autoconf:${PORTSDIR}/devel/autoconf \
 		automake:${PORTSDIR}/devel/automake \
-		kiconedit:${PORTSDIR}/graphics/kdegraphics3 \
-		ark:${PORTSDIR}/misc/kdeutils3 \
+		kiconedit:${PORTSDIR}/graphics/kdegraphics${FOR_KDE} \
+		ark:${PORTSDIR}/misc/kdeutils${FOR_KDE} \
 		glimpse:${PORTSDIR}/textproc/glimpse \
-		kbabel:${PORTSDIR}/devel/kdesdk3 \
+		kbabel:${PORTSDIR}/devel/kdesdk${FOR_KDE} \
 		a2ps:${PORTSDIR}/print/a2ps-letter
 .endif
 
-USE_KDELIBS_VER=3
+USE_KDELIBS_VER=${FOR_KDE}
 USE_BZIP2=	yes
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
@@ -35,6 +44,20 @@
 CONFIGURE_ARGS+=--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
 
 pre-everything::
+.if ${FOR_KDE} == 3
+	@${ECHO_MSG}
+	@${ECHO_MSG} "You selected to build KDevelop ${PORTVERSION} for KDE 3.x
+	@${ECHO_MSG} "If you want KDevelop for KDE 2.2.x, please run make with
+	@${ECHO_MSG}
+.elif ${FOR_KDE} == 2
+	@${ECHO_MSG}
+	@${ECHO_MSG} "You selected to build KDevelop ${PORTVERSION} for KDE 2.2.x
+	@${ECHO_MSG} "If you want KDevelop for KDE 3.x, please run make with
+	@${ECHO_MSG} "FOR_KDE=3 parameter"
+	@${ECHO_MSG}
+.else
+BROKEN=		"Please, select FOR_KDE version 2 or 3"
+.endif
 .if !defined(WITH_OPTIONAL_DEPENDS)
 	@${ECHO_MSG}
 	@${ECHO_MSG} "You may define WITH_OPTIONAL_DEPENDS (make WITH_OPTIONAL_DEPENDS=YES)"
diff -ruN kdevelop.orig/distinfo kdevelop/distinfo
--- kdevelop.orig/distinfo	Sun Jun 16 23:18:21 2002
+++ kdevelop/distinfo	Thu Jan  1 03:00:00 1970
@@ -1 +0,0 @@
-MD5 (KDE/kdevelop-2.1.1_for_KDE_3.0.tar.bz2) = eea8e3b3b3d3bb88933185b3bdf29d75
diff -ruN kdevelop.orig/distinfo.kde2 kdevelop/distinfo.kde2
--- kdevelop.orig/distinfo.kde2	Thu Jan  1 03:00:00 1970
+++ kdevelop/distinfo.kde2	Sun Jun 16 23:27:14 2002
@@ -0,0 +1 @@
+MD5 (KDE/kdevelop-2.1.1_for_KDE_2.2.tar.bz2) = c41db80c84e57d1184dcf4eb40b26e11
diff -ruN kdevelop.orig/distinfo.kde3 kdevelop/distinfo.kde3
--- kdevelop.orig/distinfo.kde3	Thu Jan  1 03:00:00 1970
+++ kdevelop/distinfo.kde3	Sun Jun 16 11:33:15 2002
@@ -0,0 +1 @@
+MD5 (KDE/kdevelop-2.1.1_for_KDE_3.0.tar.bz2) = eea8e3b3b3d3bb88933185b3bdf29d75
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->kde 
Responsible-Changed-By: alane 
Responsible-Changed-When: Sun Jun 16 13:03:10 PDT 2002 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39376 

From: Alan E <alane@geeksrus.net>
To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/39376: Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
Date: Sun, 16 Jun 2002 16:23:38 -0400

 On Sun, Jun 16, 2002 at 11:36:39PM +0400, Lev A. Serebryakov wrote:
 >
 >>Number:         39376
 >>Category:       ports
 >>Synopsis:       Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
 
 Have you verified that the pkg-plists are the same for both versions? I
 don't see those in the diffs.
 -- 
 AlanE

From: Alan E <alane@geeksrus.net>
To: FreeBSD Bugs <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: ports/39376: Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
Date: Sun, 16 Jun 2002 16:49:22 -0400

 Additionally, Lev, remember that it has to work (correctly), and even
 then, Will has the final say over whether to accept it. If he accepts
 it, it means we take responsibility to maintain it, and I know neither
 he nor I wants that responsibility.
 
 Will, would you care to comment again to save Lev some work if it's
 going to be for naught?
 -- 
 AlanE
Responsible-Changed-From-To: kde->alane 
Responsible-Changed-By: alane 
Responsible-Changed-When: Sun Jun 16 16:15:58 PDT 2002 
Responsible-Changed-Why:  
I will close once the final reply from will arrives and is attached to the 
audit log. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39376 

From: Alan E <alane@geeksrus.net>
To: FreeBSD Bugs <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: ports/39376: Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
Date: Sun, 16 Jun 2002 19:12:06 -0400

 ----- Forwarded message from Will Andrews <will@csociety.org> -----
 On Sun, Jun 16, 2002 at 01:50:03PM -0700, Alan E wrote:
 >  Additionally, Lev, remember that it has to work (correctly), and even
 >  then, Will has the final say over whether to accept it. If he accepts
 >  it, it means we take responsibility to maintain it, and I know neither
 >  he nor I wants that responsibility.
 >  
 >  Will, would you care to comment again to save Lev some work if it's
 >  going to be for naught?
 
 As far as kdevelop for kde2 is concerned, I don't think it's
 worth modifying the port to work for KDE2.  I think Lev has never
 actually tried developing apps for KDE using kdevelop-for-kde2..
 because as I said before, it never actually worked.  Of course,
 that's hearsay mostly because I usually prefer vim.  But several
 other people on the KDE/FreeBSD team that I trust tell me so.
 Not to mention, nobody should be developing any new apps for
 KDE2 anyways, so...
 
 Note that in the future it may become plausible to modify it.
 But it is not plausible right now.  So, let's not bother.
 
 Regards,
 -- 
 wca
 ----- End forwarded message -----
 
 -- 
 AlanE
State-Changed-From-To: open->closed 
State-Changed-By: alane 
State-Changed-When: Sun Jun 16 18:07:03 PDT 2002 
State-Changed-Why:  
Rejected by Will@, head of kde-freebsd. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39376 

From: Lev Serebryakov <lev@serebryakov.spb.ru>
To: Alan E <alane@geeksrus.net>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re[2]: ports/39376: Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
Date: Mon, 17 Jun 2002 07:45:08 +0400

 Hello, Alan!
 Monday, June 17, 2002, 12:23:38 AM, you wrote:
 
 >>>Number:         39376
 >>>Category:       ports
 >>>Synopsis:       Additional knob for port devel/kdevelop: port could be build for KDE 2.2.x TOO!
 AE> Have you verified that the pkg-plists are the same for both versions? I
 AE> don't see those in the diffs.
   I've don't touch pkg-plist, and installed/deinstalled KDevelop 2.2.1
   for KDE 2.2.2 on my home box (with check of file tree before and
   after). So, I've ferified, that this (original) pkg-plist is Ok for
   KDevelop 2.2.1/KDE2.2.2. Of course, I could not promise, that this
   pkg-plist is Ok for KDE3, but I think it was verified by
   kde@FreeBSD.org :)
 
 
                Lev Serebryakov
 /-----------------------------------------------\
 | FIDONet: 2:5030/661.0                         |
 | E-Mail:  lev@serebryakov.spb.ru               |
 | Page:    http://lev.serebryakov.spb.ru/       |
 | ICQ UIN: 3670018                              |
 | Phone:   You know, if you have world nodelist |
 \===============================================/
 
>Unformatted:
