From ler@lerlaptop.lerctr.org  Thu Apr 25 19:35:54 2002
Return-Path: <ler@lerlaptop.lerctr.org>
Received: from lerlaptop.lerctr.org (lerlaptop.lerctr.org [207.158.72.14])
	by hub.freebsd.org (Postfix) with ESMTP id D9F8237B419
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 25 Apr 2002 19:35:53 -0700 (PDT)
Received: from lerlaptop.lerctr.org (localhost [127.0.0.1])
	by lerlaptop.lerctr.org (8.12.3/8.12.3) with ESMTP id g3Q2ZsvE003881
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 25 Apr 2002 21:35:54 -0500 (CDT)
	(envelope-from ler@lerlaptop.lerctr.org)
Received: (from ler@localhost)
	by lerlaptop.lerctr.org (8.12.3/8.12.3/Submit) id g3Q2Zrbc003852;
	Thu, 25 Apr 2002 21:35:53 -0500 (CDT)
Message-Id: <200204260235.g3Q2Zrbc003852@lerlaptop.lerctr.org>
Date: Thu, 25 Apr 2002 21:35:53 -0500 (CDT)
From: Larry Rosenman <ler@lerctr.org>
Reply-To: Larry Rosenman <ler@lerctr.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: mail/evolution port needs a patch for TZ handling with DST
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         37471
>Category:       ports
>Synopsis:       mail/evolution port needs a patch for TZ handling with DST
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 25 19:40:01 PDT 2002
>Closed-Date:    Fri Apr 26 14:26:06 PDT 2002
>Last-Modified:  Fri Apr 26 14:26:06 PDT 2002
>Originator:     Larry Rosenman
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
LERCTR Consulting
>Environment:
System: FreeBSD lerlaptop 4.5-STABLE FreeBSD 4.5-STABLE #16: Sun Apr 21 13:43:39 CDT 2002 ler@lerlaptop:/usr/obj/usr/src/sys/LERLAPTOP i386


>Description:
the mail/evolution port mis-handles Daylight savings time.  There is a patch
that will fix it in 1.0.4, but who knows when that will be released.  I'll
place a patch that works for FreeBSD below.
>How-To-Repeat:
Build Evolution 1.3, send mail (in a place where DST is in effect), note
the Date: header has a Timezone indiction is one hour west of where it was

>Fix:

I discovered (and reported to the Evolution team) a bug where on
FreeBSD the timezone is adjusted to be one hour off from reality when
DST is in effect. 

The Evolution team fixed it in CVS for 1.0.4, but I don't know when it
will be out.  

Can the port be modified to patch

camel/camel-mime-message.c

to remove the lines around line 212 
that set offset += 100? 

Not a problem, but please submit a patch instead of a verbal description.

Thanks!

-Maxim
Here is my quickie patch, I'm not sure how y'all want to do it.  it
definately fixes FreeBSD....


*** camel-mime-message.c.orig Wed Apr 10 10:19:38 2002
--- camel-mime-message.c      Wed Apr 10 09:31:51 2002
***************
*** 209,216 ****
--- 209,218 ----
              tz = -local->tm_gmtoff;
  #endif
              offset = -(((tz/60/60) * 100) + (tz/60 % 60));
+ #if 0
              if (local->tm_isdst>0)
                      offset += 100;
+ #endif
      }
      message->date = date;
      message->date_offset = offset;



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->gnome 
Responsible-Changed-By: pat 
Responsible-Changed-When: Thu Apr 25 20:08:46 PDT 2002 
Responsible-Changed-Why:  
Over to maintainers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37471 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Fri Apr 26 14:25:47 PDT 2002 
State-Changed-Why:  
Committed with a slight modification.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37471 
>Unformatted:
