From marcus@shumai.marcuscom.com  Sat Mar  9 01:51:10 2002
Return-Path: <marcus@shumai.marcuscom.com>
Received: from shumai.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46])
	by hub.freebsd.org (Postfix) with ESMTP id 150B437B402
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  9 Mar 2002 01:51:09 -0800 (PST)
Received: (from marcus@localhost)
	by shumai.marcuscom.com (8.11.6/8.11.6) id g299pB327989;
	Sat, 9 Mar 2002 04:51:11 -0500 (EST)
	(envelope-from marcus)
Message-Id: <200203090951.g299pB327989@shumai.marcuscom.com>
Date: Sat, 9 Mar 2002 04:51:11 -0500 (EST)
From: Joe Marcus Clarke <marcus@marcuscom.com>
Reply-To: Joe Marcus Clarke <marcus@marcuscom.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Fix xscreensaver's vidwhacker hacks on -stable
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         35702
>Category:       ports
>Synopsis:       [PATCH] Fix xscreensaver's vidwhacker hacks on -stable
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 09 02:00:02 PST 2002
>Closed-Date:    Sun Mar 17 12:20:31 PST 2002
>Last-Modified:  Sun Mar 17 12:20:31 PST 2002
>Originator:     Joe Marcus Clarke
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
MarcusCom, Inc.
>Environment:
System: FreeBSD shumai.marcuscom.com 4.5-STABLE FreeBSD 4.5-STABLE #0: Mon Mar 4 23:37:10 EST 2002 marcus@shumai.marcuscom.com:/usr/obj/usr/src/sys/SHUMAI i386


	
>Description:
xscreensaver's xscreensaver-getimage-file file assumes Perl 5.6.x, but only
requires Perl 5.  Perl 5.00503's Fcntl.pm does not include the "mode" export
tag.  Thus, all the screen grabbing hacks fail.  Since POSIX.pm includes
all the fcntl.h modes in both Perl 5.00503 and 5.6.0, I think the attached
patch will work all around.
>How-To-Repeat:
Try to RotZoomer, for example on -stable.  You will see a Perl compilation
failure.
>Fix:

PORTREVISION should probably be bumped, too.

	

--- patch-driver::xscreensaver-getimage-file begins here ---
--- driver/xscreensaver-getimage-file.orig	Sat Mar  9 04:37:53 2002
+++ driver/xscreensaver-getimage-file	Sat Mar  9 04:45:35 2002
@@ -28,8 +28,8 @@
 use strict;
 
 use POSIX;
+use POSIX ':fcntl_h';
 use Fcntl;
-use Fcntl ':mode';
 
 my $progname = $0; $progname =~ s@.*/@@g;
 my $version = q{ $Revision: 1.8 $ }; $version =~ s/^[^0-9]+([0-9.]+).*$/$1/;
--- patch-driver::xscreensaver-getimage-file ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->dougb 
Responsible-Changed-By: pat 
Responsible-Changed-When: Sat Mar 9 09:14:41 PST 2002 
Responsible-Changed-Why:  
Over to maintainer 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=35702 
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Sun Mar 17 12:19:41 PST 2002 
State-Changed-Why:  

Yours is the third different solution for fixing this problem. Please 
submit your suggestion to the software author so that he can fix this 
in the next version. 

Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=35702 
>Unformatted:
