From alane@geeksrus.net  Thu Feb  7 19:36:12 2002
Return-Path: <alane@geeksrus.net>
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226])
	by hub.freebsd.org (Postfix) with ESMTP id A21AF37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Feb 2002 19:36:09 -0800 (PST)
Received: (from alane@localhost)
	by wwweasel.geeksrus.net (8.11.6/8.11.6) id g183ZmI34191;
	Thu, 7 Feb 2002 22:35:48 -0500 (EST)
	(envelope-from alane)
Message-Id: <200202080335.g183ZmI34191@wwweasel.geeksrus.net>
Date: Thu, 7 Feb 2002 22:35:48 -0500 (EST)
From: Alan Eldridge <ports@geeksrus.net>
Reply-To: Alan Eldridge <ports@geeksrus.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Maintainer update: audio/freeamp: be consistent with xmms re default plugins
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         34724
>Category:       ports
>Synopsis:       Maintainer update: audio/freeamp: be consistent with xmms re default plugins
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 07 19:40:01 PST 2002
>Closed-Date:    Thu Feb 7 19:49:49 PST 2002
>Last-Modified:  Thu Feb 07 19:50:01 PST 2002
>Originator:     Alan Eldridge
>Release:        FreeBSD 4.5-RELEASE i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Tue Feb 5 22:58:09 EST 2002 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/WWWEASEL i386

>Description:

After a discussion regarding accomodating people with default dependent
port settings, I realized I was not following my own advice here.

>How-To-Repeat:

>Fix:

Index: audio/freeamp/Makefile
===================================================================
RCS file: /home/alane/cvsroot/ports/audio/freeamp/Makefile,v
retrieving revision 1.14
diff -u -3 -r1.14 Makefile
--- audio/freeamp/Makefile	20 Jan 2002 00:22:51 -0000	1.14
+++ audio/freeamp/Makefile	8 Feb 2002 03:33:37 -0000
@@ -21,6 +21,7 @@
 WRKSRC=		${WRKDIR}/${PORTNAME}
 USE_BZIP2=	yes
 USE_GTK=	yes
+WANT_ESOUND=	yes
 USE_GMAKE=	yes
 USE_AUTOCONF_VER=213
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include ${PTHREAD_CFLAGS}" \
@@ -34,7 +35,7 @@
 CFLAGS+=	"-D_M_ALPHA"
 .endif
 
-.if defined(WITH_ESOUND) || defined(WITH_ALL_PLUGINS)
+.if defined(HAVE_ESOUND) || defined(WITH_ALL_PLUGINS)
 USE_ESOUND=	yes
 PLIST_SUB+=	ESOUND=""
 .else
@@ -50,7 +51,7 @@
 PLIST_SUB+=	LIBARTS="@comment "
 .endif
 
-.if defined(WITH_VORBIS) || defined(WITH_ALL_PLUGINS)
+.if !defined(WITHOUT_VORBIS) || defined(WITH_ALL_PLUGINS)
 LIB_DEPENDS+=	vorbis.1:${PORTSDIR}/audio/libvorbis
 PLIST_SUB+=	VORBIS=""
 .else
@@ -62,9 +63,9 @@
 	@${ECHO_MSG}
 	@${ECHO_MSG} "You may use the following build options:"
 	@${ECHO_MSG}
-	@${ECHO_MSG} "WITH_ESOUND=yes       build with ESounD outout plugin"
-	@${ECHO_MSG} "WITH_LIBARTS=yes      build with libArts output plugin"
-	@${ECHO_MSG} "WITH_VORBIS=yes       build with Ogg/Vorbis codec plugin"
+	@${ECHO_MSG} "WITH_LIBARTS	build with libArts output plugin"
+	@${ECHO_MSG} "WITHOUT_ESOUND	do NOT build with esd support"
+	@${ECHO_MSG} "WITHOUT_VORBIS	do NOT build with Ogg/Vorbis codec plugin"
 	@${ECHO_MSG}
 	@${ECHO_MSG} "WITH_ALL_PLUGINS=yes  build with all plugins"
 	@${ECHO_MSG}

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pat 
State-Changed-When: Thu Feb 7 19:49:49 PST 2002 
State-Changed-Why:  
Committed, Thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34724 
>Unformatted:
