From rk@home.ronald.org  Fri Feb  1 16:25:42 2002
Return-Path: <rk@home.ronald.org>
Received: from kiste.thiemo.net (kiste.thiemo.net [193.159.181.84])
	by hub.freebsd.org (Postfix) with ESMTP id DB27A37B404
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Feb 2002 16:25:40 -0800 (PST)
Received: (from uucp@localhost)
	by kiste.thiemo.net (8.9.3/8.9.3) with UUCP id BAA71432
	for FreeBSD-gnats-submit@freebsd.org; Sat, 2 Feb 2002 01:25:37 +0100 (CET)
	(envelope-from rk@home.ronald.org)
Received: (from rk@localhost)
	by wallace.home.ronald.org (8.11.6/8.11.6) id g11MM1l00765;
	Fri, 1 Feb 2002 23:22:01 +0100 (CET)
	(envelope-from rk@ronald.org)
Message-Id: <200202012222.g11MM1l00765@wallace.home.ronald.org>
Date: Fri, 1 Feb 2002 23:22:01 +0100 (CET)
From: Ronald Kuehn <rk@ronald.org>
Reply-To: Ronald Kuehn <rk@ronald.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Port fix: security/gnupg missing LIB_DEPENDS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         34543
>Category:       ports
>Synopsis:       Port fix: security/gnupg missing LIB_DEPENDS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 01 16:30:00 PST 2002
>Closed-Date:    Sun Feb 3 15:01:09 PST 2002
>Last-Modified:  Sun Feb 03 15:01:55 PST 2002
>Originator:     Ronald Kuehn
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD wallace.home.ronald.org 4.4-STABLE FreeBSD 4.4-STABLE #3: Tue Dec 11 04:55:09 CET 2001 rk@merlin.home.ronald.org:/usr/build/obj/usr/src/sys/WALLACE i386


	
>Description:

The security/gnupg port is missing LIB_DEPENDS (iconv and gdbm).

>How-To-Repeat:

Build the package and try to install it on a different system (w/o the
above named libraries).

>Fix:

--- Makefile.old	Fri Feb  1 23:17:43 2002
+++ Makefile	Fri Feb  1 23:16:49 2002
@@ -16,6 +16,9 @@
 
 MAINTAINER=	kuriyama@FreeBSD.org
 
+LIB_DEPENDS=	iconv.2:${PORTSDIR}/converters/iconv \
+		gdbm.2:${PORTSDIR}/databases/gdbm
+
 #RESTRICTED=	"Crypto; export-controlled"
 GNU_CONFIGURE=	YES
 CONFIGURE_ARGS=	--with-included-gettext
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->kuriyama 
Responsible-Changed-By: pat 
Responsible-Changed-When: Fri Feb 1 19:49:33 PST 2002 
Responsible-Changed-Why:  
Over to maintainer 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34543 

From: Jun Kuriyama <kuriyama@imgsrc.co.jp>
To: Ronald Kuehn <rk@ronald.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/34543: Port fix: security/gnupg missing LIB_DEPENDS
Date: Sat, 02 Feb 2002 12:59:42 +0900

 At Sat, 2 Feb 2002 00:30:14 +0000 (UTC),
 Ronald Kuehn wrote:
 > >Description:
 > 
 > The security/gnupg port is missing LIB_DEPENDS (iconv and gdbm).
 > 
 > >How-To-Repeat:
 > 
 > Build the package and try to install it on a different system (w/o the
 > above named libraries).
 
 I think this is not required.  Gnupg links for these library if
 configure find them and most features of gnupg works fine without
 linking them.
 
 Do you think we should force to install iconv and gdbm who want to use
 gnupg itself only?
 
 
 -- 
 Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
              <kuriyama@FreeBSD.org> // FreeBSD Project

From: Ronald Kuehn <rk@ronald.org>
To: Jun Kuriyama <kuriyama@imgsrc.co.jp>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/34543: Port fix: security/gnupg missing LIB_DEPENDS
Date: Sat, 2 Feb 2002 22:01:20 +0100

 Jun Kuriyama wrote:
 > At Sat, 2 Feb 2002 00:30:14 +0000 (UTC),
 > Ronald Kuehn wrote:
 > > >Description:
 > > 
 > > The security/gnupg port is missing LIB_DEPENDS (iconv and gdbm).
 > > 
 > > >How-To-Repeat:
 > > 
 > > Build the package and try to install it on a different system (w/o the
 > > above named libraries).
 > 
 > I think this is not required.  Gnupg links for these library if
 > configure find them and most features of gnupg works fine without
 > linking them.
 > 
 > Do you think we should force to install iconv and gdbm who want to use
 > gnupg itself only?
 
 Well, the problem is as follows: I did a "make package" on one system
 (which has libgdbm and libiconv). Gnupg uses these libraries if found.
 But the package does not contain the correct dependencies. If you install
 that package on a different system (w/o libgdbm/libiconv) gnupg won't work.
 So we have a package that requires those libs but doesn't say so.
 
 I don't know what we should do here. Either add LIB_DEPENDS and thus
 requiring libgdbm and libiconv or find a way to make that optional
 during the build. I think hidden dependencies are a bad thing. If gnupg
 is linked against other libraries the package should contain them
 as LIB_DEPENDS.
 
 Bye,
   Ronald
 
 -- 
 * The whole problem with the world is that fools and fanatics are always
 * so certain of themselves, but wiser people so full of doubts.
 *                                                     --Bertrand Russell
State-Changed-From-To: open->closed 
State-Changed-By: kuriyama 
State-Changed-When: Sun Feb 3 15:01:09 PST 2002 
State-Changed-Why:  
I added conditional dependency line.  Please cvsup and try again. 

Thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34543 
>Unformatted:
