From nobody@FreeBSD.org  Wed Jan  2 09:33:07 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 3375237B417
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Jan 2002 09:33:07 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g02HX7x03021;
	Wed, 2 Jan 2002 09:33:07 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200201021733.g02HX7x03021@freefall.freebsd.org>
Date: Wed, 2 Jan 2002 09:33:07 -0800 (PST)
From: jan grant <jan.grant@bristol.ac.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: portupgrade -P -i -a: problem at line 1382 of portupgrade (origin undefined)
X-Send-Pr-Version: www-1.0

>Number:         33478
>Category:       ports
>Synopsis:       portupgrade -P -i -a: problem at line 1382 of portupgrade (origin undefined)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    knu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 02 09:40:00 PST 2002
>Closed-Date:    Fri Jan 4 05:52:53 JST 2002
>Last-Modified:  Fri Jan 04 05:53:04 JST 2002
>Originator:     jan grant
>Release:        4-stable
>Organization:
University of Bristol
>Environment:
not applicable; it's a generic kernel      
>Description:
running
	portupgrade -P -i -a
bombs out with the following error:
/usr/local/sbin/portupgrade:1382:in `install_pkg': undefined method `origin' for "lcms-1.07_1":String (NameError)
        from /usr/local/sbin/portupgrade:953:in `upgrade_pkg'
        from /usr/local/sbin/portupgrade:661:in `main'
        from /usr/local/sbin/portupgrade:609:in `each'
        from /usr/local/sbin/portupgrade:609:in `main'
        from /usr/local/sbin/portupgrade:186:in `initialize'
        from /usr/local/sbin/portupgrade:186:in `new'
        from /usr/local/sbin/portupgrade:186:in `main'
        from /usr/local/sbin/portupgrade:1622

>How-To-Repeat:
portupgrade -P -i -a
ruby is version 1.6.6
>Fix:
      
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->knu 
Responsible-Changed-By: dirk 
Responsible-Changed-When: Wed Jan 2 11:28:49 PST 2002 
Responsible-Changed-Why:  
Over to maintainer! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33478 

From: "Akinori MUSHA" <knu@iDaemons.org>
To: jan grant <jan.grant@bristol.ac.uk>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/33478: portupgrade -P -i -a: problem at line 1382 of portupgrade (origin undefined)
Date: Thu, 03 Jan 2002 08:12:09 +0900

 Thanks for catching it; I recognized the problem and the cause.
 
 Does this patch help?
 
 Index: portupgrade
 ===================================================================
 RCS file: /home/cvs/pkgtools/bin/portupgrade,v
 retrieving revision 1.160
 diff -u -u -r1.160 portupgrade
 --- portupgrade	30 Dec 2001 22:08:20 -0000	1.160
 +++ portupgrade	2 Jan 2002 23:05:01 -0000
 @@ -950,7 +950,7 @@
    teardown_proc2 = uninstall_pkg(oldpkgname, $uninstall_extra_flags)
  
    if have_package
 -    install_pkg(newpkgname, logfile, teardown_proc1, teardown_proc2)
 +    install_pkg(newpkgname, origin, logfile, teardown_proc1, teardown_proc2)
    else
      install_port(origin, logfile, teardown_proc1, teardown_proc2)
    end
 @@ -1198,7 +1198,7 @@
    if have_package
      return true if $fetch_only
  
 -    install_pkg(newpkgname, logfile)
 +    install_pkg(newpkgname, origin, logfile)
    else
      build_port(origin, logfile)
  
 @@ -1365,7 +1365,7 @@
  
  # raises:
  #   InstallError
 -def install_pkg(pkgname, logfile = nil, *teardown_procs)
 +def install_pkg(pkgname, origin, logfile = nil, *teardown_procs)
    cmdargs = [PkgDB::CMD[:pkg_add], '-f', pkgname]
  
    progress_message "Installing the new version via the package"
 
 
 -- 
                      /
                     /__  __            Akinori.org / MUSHA.org
                    / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
 Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp
 
 "Somewhere out of a memory.. of lighted streets on quiet nights.."

From: Jan Grant <Jan.Grant@bristol.ac.uk>
To: Akinori MUSHA <knu@iDaemons.org>
Cc: freebsd-gnats-submit <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: ports/33478: portupgrade -P -i -a: problem at line 1382 of       
         portupgrade (origin undefined)
Date: Thu, 3 Jan 2002 09:51:38 +0000 (GMT)

 On Thu, 3 Jan 2002, Akinori MUSHA wrote:
 
 > Thanks for catching it; I recognized the problem and the cause.
 >
 > Does this patch help?
 
 Perfectly; this PR can be CLOSED (fixed).
 
 Cheers,
 
 -- 
 jan grant, ILRT, University of Bristol. http://www.ilrt.bris.ac.uk/
 Tel +44(0)117 9287088 Fax +44 (0)117 9287112 RFC822 jan.grant@bris.ac.uk
 Theoremhood is positively decidable.
 It just takes time at least exponential in the length of the proof.
 
State-Changed-From-To: open->closed 
State-Changed-By: knu 
State-Changed-When: Fri Jan 4 05:52:53 JST 2002 
State-Changed-Why:  
Fixed, thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33478 
>Unformatted:
