From bms@spc.org  Wed Dec 26 22:30:52 2001
Return-Path: <bms@spc.org>
Received: from bigboy.spc.org (dolly.good1.com [195.206.69.225])
	by hub.freebsd.org (Postfix) with ESMTP id 38EE737B419
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 26 Dec 2001 22:30:51 -0800 (PST)
Received: from kiowa.dek.spc.org (adsl-217-154-12-3.mistral.co.uk [217.154.12.3])
	by bigboy.spc.org (Postfix) with ESMTP id 768493132
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Dec 2001 06:32:26 +0000 (GMT)
Received: by kiowa.dek.spc.org (Postfix, from userid 1001)
	id DC4A42102C; Thu, 27 Dec 2001 06:30:52 +0000 (GMT)
Message-Id: <20011227063052.DC4A42102C@kiowa.dek.spc.org>
Date: Thu, 27 Dec 2001 06:30:52 +0000 (GMT)
From: Bruce M Simpson <bms@spc.org>
Reply-To: Bruce M Simpson <bms@spc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
In-Reply-To: <200112270620.fBR6K0O27596@freefall.freebsd.org>
Subject: Build breaks on CURRENT due to <sys/dir.h> changes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         33225
>Category:       ports
>Synopsis:       Build breaks on CURRENT due to <sys/dir.h> changes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    me
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 26 22:40:01 PST 2001
>Closed-Date:    Sun Jan 19 09:27:30 PST 2003
>Last-Modified:  Sun Jan 19 09:27:30 PST 2003
>Originator:     Bruce M Simpson
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD kiowa.dek.spc.org 5.0-CURRENT FreeBSD 5.0-CURRENT #7: Mon Dec 24 04:57:54 GMT 2001 root@kiowa.dek.spc.org:/usr/src/sys/i386/compile/KIOWA i386

>Description:
	Build actually breaks due to stdout no longer being usable as
	a constant initializer in mmv.c (changes in libc).
>How-To-Repeat:
	Try building on CURRENT without the patch below.
>Fix:
	Modified patch-aa file for CURRENT is enclosed.
	Only change was to shift initialization of outfile to happen
	at runtime from main().

--- patch-aa begins here ---
--- mmv.c.orig	Thu Dec 27 06:12:50 2001
+++ mmv.c	Thu Dec 27 06:26:29 2001
@@ -88,7 +88,6 @@
 #endif
 
 #include <stdio.h>
-#include <ctype.h>
 
 #ifdef MSDOS
 /* for MS-DOS (under Turbo C 1.5)*/
@@ -126,7 +125,6 @@
 #include <sys/file.h>
 
 extern char *getenv();
-extern long lseek();
 extern char *malloc();
 
 #ifdef DIRENT
@@ -176,7 +174,6 @@
 
 #else
 /* for System V and BSD */
-#include <string.h>
 #include <sys/signal.h>
 #include <fcntl.h>
 #endif
@@ -370,7 +367,7 @@
 static int snap(/* REP *first, REP *p */);
 static void showdone(/* REP *fin */);
 static void breakout(/*  */);
-static int breakrep(/* */);
+static void breakrep(/* */);
 static void breakstat(/* */);
 static void quit(/*  */);
 static int copymove(/* REP *p */);
@@ -389,7 +386,6 @@
 static int getstat(/* char *full, FILEINFO *f */);
 static int dwritable(/* HANDLE *h */);
 static int fwritable(/* char *hname, FILEINFO *f */);
-static void memmove(/* void *to, void *from, int k */);
 #endif
 #ifndef RENAME
 static int rename(/* char *from, char *to */);
@@ -410,7 +406,7 @@
 static SLICER slicer[2] = {{NULL, NULL, 0}, {NULL, NULL, 0}};
 
 static int badreps = 0, paterr = 0, direrr, failed = 0, gotsig = 0, repbad;
-static FILE *outfile = stdout;
+static FILE *outfile;
 
 static char IDF[] = "$$mmvdid.";
 static char TEMP[] = "$$mmvtmp.";
@@ -471,6 +467,7 @@
 {
 	char *frompat, *topat;
 
+        outfile = stdout;
 	init();
 	procargs(argc, argv, &frompat, &topat);
 	domatch(frompat, topat);
@@ -2550,10 +2547,9 @@
 }
 
 
-static int breakrep()
+static void breakrep()
 {
 	gotsig = 1;
-	return(1);
 }
 
 
@@ -2832,7 +2828,7 @@
 }
 
 
-#ifndef MSDOS
+#if 0
 static void memmove(to, from, k)
 	char *to, *from;
 	unsigned k;
--- patch-aa ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->me 
Responsible-Changed-By: ijliao 
Responsible-Changed-When: Thu Dec 27 00:54:29 PST 2001 
Responsible-Changed-Why:  
over to maintianer 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33225 

From: "David W. Chapman Jr." <dwcjr@inethouston.net>
To: freebsd-gnats-submit@FreeBSD.org, bms@spc.org
Cc:  
Subject: Re: ports/33225: Build breaks on CURRENT due to <sys/dir.h> changes
Date: Sun, 27 Jan 2002 10:42:59 -0600

 What port is this for?
 
State-Changed-From-To: open->feedback 
State-Changed-By: arved 
State-Changed-When: Mon Oct 28 14:36:21 PST 2002 
State-Changed-Why:  
A fix was committed by se in june 2002, does this fix the problem? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=33225 
State-Changed-From-To: feedback->closed 
State-Changed-By: arved 
State-Changed-When: Sun Jan 19 09:27:09 PST 2003 
State-Changed-Why:  
Feedback timeout (2.5 months) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=33225 
>Unformatted:
