From marcus@shumai.marcuscom.com  Thu Dec  6 14:24:08 2001
Return-Path: <marcus@shumai.marcuscom.com>
Received: from shumai.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46])
	by hub.freebsd.org (Postfix) with ESMTP id E5AFD37B419
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Dec 2001 14:24:07 -0800 (PST)
Received: (from marcus@localhost)
	by shumai.marcuscom.com (8.11.6/8.11.6) id fB6MONq35975;
	Thu, 6 Dec 2001 17:24:23 -0500 (EST)
	(envelope-from marcus)
Message-Id: <200112062224.fB6MONq35975@shumai.marcuscom.com>
Date: Thu, 6 Dec 2001 17:24:23 -0500 (EST)
From: Joe Marcus Clarke <marcus@marcuscom.com>
Reply-To: Joe Marcus Clarke <marcus@marcuscom.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Recent Nautilus patch causes infinite loop
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         32566
>Category:       ports
>Synopsis:       Recent Nautilus patch causes infinite loop
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 06 14:30:00 PST 2001
>Closed-Date:    Fri Dec 7 00:54:08 PST 2001
>Last-Modified:  Fri Dec 07 00:56:18 PST 2001
>Originator:     Joe Marcus Clarke
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
MarcusCom, Inc.
>Environment:
System: FreeBSD shumai.marcuscom.com 4.4-STABLE FreeBSD 4.4-STABLE #0: Sat Dec 1 19:32:11 EST 2001 marcus@shumai.marcuscom.com:/usr/obj/usr/src/sys/SHUMAI i386


	
>Description:
	After applying the patch to get rid of the harmless warning from gnomevfs 
about local path not starting with `/', nautilus doesn't work anymore.  gdb 
shows nautilus is in an infinite loop around line 979.
>How-To-Repeat:
	CVSup the latest ports, upgrade nautilus, and try running it.
>Fix:
Apply this patch to patch-libnautilus-private::nautilus-volume-monitor.c.  Not
sure if PORTREVISION should be bumped since it wasn't bumped with the 
addition of this patch.

--- patch-libnautilus-private::nautilus-volume-monitor.c.orig	Thu Dec  6 17:18:18 2001
+++ patch-libnautilus-private::nautilus-volume-monitor.c	Thu Dec  6 17:18:52 2001
@@ -169,7 +169,6 @@
  	fclose (fh);
 +#else
 +	while ((ent = getfsent ()) != NULL) {
-+		{static int b = 1; while (b);}
 +		if (strcmp(ent->fs_vfstype, "swap") == 0)
 +			continue;
 +		volume = create_volume (ent->fs_spec, ent->fs_file);
>Release-Note:
>Audit-Trail:

From: Joe Clarke <jclarke@cisco.com>
To: freebsd-gnats-submit@FreeBSD.org, marcus@marcuscom.com
Cc:  
Subject: Re: ports/32566: Recent Nautilus patch causes infinite loop
Date: Thu, 06 Dec 2001 17:42:35 -0500

 Sorry, the patch wasn't complete.  This patch should be better:
 
 --- patch-libnautilus-private::nautilus-volume-monitor.c.orig   Thu Dec 
 6 17:41:42 2001
 +++ patch-libnautilus-private::nautilus-volume-monitor.c        Thu Dec 
 6 17:41:54 2001
 @@ -163,13 +163,12 @@
           while (! getmntent(fh, &ent)) {
                   volume = create_volume (ent.mnt_special,
 ent.mnt_mountp);
                   volume->is_removable = has_removable_mntent_options
 (&ent);
 -@@ -932,6 +979,23 @@
 +@@ -932,6 +979,22 @@
           }
 
         fclose (fh);
  +#else
  +      while ((ent = getfsent ()) != NULL) {
 -+              {static int b = 1; while (b);}
  +              if (strcmp(ent->fs_vfstype, "swap") == 0)
  +                      continue;
  +              volume = create_volume (ent->fs_spec, ent->fs_file);
 
 --
 Joe Clarke, CCIE #5384             |          |
 Customer Support Engineer        |||||      |||||
 Phone: +1 (919) 392-2867    ..:|||||||||::|||||||||:..
 Email: jclarke@cisco.com     c i s c o  S y s t e m s
 
 ----------------------------------------------------------------------------
Responsible-Changed-From-To: freebsd-ports->gnome 
Responsible-Changed-By: pat 
Responsible-Changed-When: Thu Dec 6 16:57:19 PST 2001 
Responsible-Changed-Why:  
Over to maintainers. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32566 
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Fri Dec 7 00:54:08 PST 2001 
State-Changed-Why:  
Committed, thank you for reporting. I donno how this debugging trap slipped 
into a commit... :((( 

http://www.freebsd.org/cgi/query-pr.cgi?pr=32566 
>Unformatted:
