From root@gits.dyndns.org  Thu Sep  6 06:21:16 2001
Return-Path: <root@gits.dyndns.org>
Received: from smtp.noos.fr (zola.noos.net [212.198.2.76])
	by hub.freebsd.org (Postfix) with ESMTP id C94D637B403
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Sep 2001 06:21:15 -0700 (PDT)
Received: (qmail 37866021 invoked by uid 0); 6 Sep 2001 13:21:14 -0000
Received: from unknown (HELO gits.dyndns.org) ([212.198.231.187]) (envelope-sender <root@gits.dyndns.org>)
          by 212.198.2.76 (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <FreeBSD-gnats-submit@freebsd.org>; 6 Sep 2001 13:21:14 -0000
Received: (from root@localhost)
	by gits.dyndns.org (8.11.6/8.11.6) id f86DLD643188;
	Thu, 6 Sep 2001 15:21:13 +0200 (CEST)
	(envelope-from root)
Message-Id: <200109061321.f86DLD643188@gits.dyndns.org>
Date: Thu, 6 Sep 2001 15:21:13 +0200 (CEST)
From: Cyrille Lefevre <clefevre@citeweb.net>
Reply-To: Cyrille Lefevre <clefevre@citeweb.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Maintainer update: misc/findutils (minor fix)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         30389
>Category:       ports
>Synopsis:       Maintainer update: misc/findutils (minor fix)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 06 06:30:01 PDT 2001
>Closed-Date:    Wed Sep 12 16:26:14 PDT 2001
>Last-Modified:  Wed Sep 12 16:26:51 PDT 2001
>Originator:     Cyrille Lefevre
>Release:        FreeBSD 4.4-RC i386
>Organization:
ACME
>Environment:

System: FreeBSD gits 4.4-RC FreeBSD 4.4-RC #29: Sat Aug 25 14:49:20 CEST 2001 root@gits:/disk2/4.x-stable/src/sys/compile/CUSTOM i386

>Description:
	Makefile
		MAKE_ARGS added.
>How-To-Repeat:
	n/a
>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/findutils/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile	2001/06/09 12:59:31	1.10
+++ Makefile	2001/09/06 13:20:21
@@ -14,21 +14,20 @@
 
 MAINTAINER=	clefevre@redirect.to
 
-GNU_CONFIGURE=	yes
-
-#
 # Global variables
 #
 
+GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--program-prefix=g # --localstatedir=${LOCALSTATEDIR}
 MAKE_ARGS=	INSTALL_SCRIPT="${INSTALL_SCRIPT}"
 
 USE_GMAKE=	yes
+# PREFIX isn't honored. force it w/ prefix.
+MAKE_ARGS+=	prefix=${PREFIX}
 
 MAN1=		gfind.1 gxargs.1 glocate.1 gupdatedb.1
 MAN5=		glocatedb.5
 
-#
 # Local variables
 #
 
@@ -36,14 +35,12 @@
 
 INSTALL_INFO?=	install-info
 
-#
 # Post-extract
 #
 
 post-extract:
 	@${RM} -f ${WRKSRC}/doc/${PORTNAME:S/utils//}.info*
 
-#
 # Post-patch
 #
 
@@ -51,7 +48,6 @@
 	@${PERL} -pi.fbsd -e 's|makeinfo|makeinfo --no-split|g' \
 		${WRKSRC}/doc/Makefile.in
 
-#
 # Post-configure
 #
 
@@ -60,7 +56,6 @@
 	@${PERL} -pi.fbsd -e 's|\$$\(prefix\)/var|${LOCALSTATEDIR}|g' \
 		${WRKSRC}/Makefile ${WRKSRC}/locate/Makefile
 
-#
 # Post-install
 #
 
>Release-Note:
>Audit-Trail:

From: Peter Pentchev <roam@ringlet.net>
To: Cyrille Lefevre <clefevre@citeweb.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/30389: Maintainer update: misc/findutils (minor fix)
Date: Thu, 6 Sep 2001 16:55:10 +0300

 On Thu, Sep 06, 2001 at 03:21:13PM +0200, Cyrille Lefevre wrote:
 > 
 > >Number:         30389
 > >Category:       ports
 > >Synopsis:       Maintainer update: misc/findutils (minor fix)
 > >Originator:     Cyrille Lefevre
 > >Release:        FreeBSD 4.4-RC i386
 > >Organization:
 > ACME
 > >Environment:
 > 
 > System: FreeBSD gits 4.4-RC FreeBSD 4.4-RC #29: Sat Aug 25 14:49:20 CEST 2001 root@gits:/disk2/4.x-stable/src/sys/compile/CUSTOM i386
 > 
 > >Description:
 > 	Makefile
 > 		MAKE_ARGS added.
 > >How-To-Repeat:
 > 	n/a
 > >Fix:
 > 
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/ncvs/ports/misc/findutils/Makefile,v
 > retrieving revision 1.10
 > diff -u -r1.10 Makefile
 > --- Makefile	2001/06/09 12:59:31	1.10
 > +++ Makefile	2001/09/06 13:20:21
 > @@ -14,21 +14,20 @@
 >  
 >  MAINTAINER=	clefevre@redirect.to
 >  
 > -GNU_CONFIGURE=	yes
 > -
 > -#
 >  # Global variables
 >  #
 >  
 > +GNU_CONFIGURE=	yes
 >  CONFIGURE_ARGS=	--program-prefix=g # --localstatedir=${LOCALSTATEDIR}
 >  MAKE_ARGS=	INSTALL_SCRIPT="${INSTALL_SCRIPT}"
 >  
 >  USE_GMAKE=	yes
 > +# PREFIX isn't honored. force it w/ prefix.
 > +MAKE_ARGS+=	prefix=${PREFIX}
 
 Are you really sure of that?
 
 After a 'make PREFIX=~roam/tmp clean configure', I have:
 
 [root@ringworld:v5 /usr/ports/misc/findutils]# grep ^prefix work/findutils-4.1/Makefile
 prefix = /home/roam/tmp
 [root@ringworld:v5 /usr/ports/misc/findutils]#
 
 It would seem that GNU_CONFIGURE honors the PREFIX environment variable
 (as it has for quite some time..)
 
 Besides, as I pointed out in another email, even for cases when GNU
 configure scripts do not set the Makefile prefix properly, I think
 that MAKE_ENV would be a better place to put environment variables
 than MAKE_ARGS..
 
 G'luck,
 Peter
 
 -- 
 Do you think anybody has ever had *precisely this thought* before?
State-Changed-From-To: open->closed 
State-Changed-By: lioux 
State-Changed-When: Wed Sep 12 16:26:14 PDT 2001 
State-Changed-Why:  
Committed, thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=30389 
>Unformatted:
