From petef@entropy.databits.net  Wed Aug  8 07:45:29 2001
Return-Path: <petef@entropy.databits.net>
Received: from entropy.databits.net (electron.databits.net [207.29.204.16])
	by hub.freebsd.org (Postfix) with ESMTP id 146F637B40C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  8 Aug 2001 07:45:18 -0700 (PDT)
	(envelope-from petef@entropy.databits.net)
Received: (from petef@localhost)
	by entropy.databits.net (8.11.1/8.11.1) id f78Ej2p22173;
	Wed, 8 Aug 2001 10:45:02 -0400 (EDT)
	(envelope-from petef)
Message-Id: <200108081445.f78Ej2p22173@entropy.databits.net>
Date: Wed, 8 Aug 2001 10:45:02 -0400 (EDT)
From: Pete Fritchman <petef@databits.net>
Reply-To: Pete Fritchman <petef@databits.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Fix USE_MESA in bsd.port.mk
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         29546
>Category:       ports
>Synopsis:       Fix USE_MESA in bsd.port.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 08 07:50:01 PDT 2001
>Closed-Date:    Thu Aug 30 19:14:32 PDT 2001
>Last-Modified:  Thu Aug 30 19:14:48 PDT 2001
>Originator:     Pete Fritchman
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Databits Network Services, Inc.
>Environment:
System: FreeBSD entropy.databits.net 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Tue Aug 7 22:57:00 EDT 2001 root@entropy.databits.net:/usr/obj/usr/src/sys/ENTROPY i386

>Description:

It seems to me that USE_MESA implies that the ${PORTSDIR}/graphics/Mesa3 port
needs to be installed.  The LIB_DEPENDS when XFREE86_VERSION=4 don't 
accomplish this:

excerpt from bsd.port.mk:

.if ${XFREE86_VERSION} == 3
...
.else
...
.if defined(USE_MESA)
LIB_DEPENDS+=                   GLU.1:${PORTSDIR}/graphics/Mesa3
.endif
...

But, this will dependency will never cause graphics/Mesa3 to be installed
because the GLU.1 shared library is included with XFree86 4.1:

entropy [26] % pkg_info -W /usr/X11R6/lib/libGLU.so.1
/usr/X11R6/lib/libGLU.so.1 was installed by package XFree86-4.1.0_4
entropy [27] % 

It looks like we could depend on libglut instead for XFree86 4.

>How-To-Repeat:

See PR 29536.  I'm not sure if the submitter has XFree86 4 or not, but I do
and this prompted a problem for me (and it looks like it's causing his problem
as well).

>Fix:

Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.376
diff -u -r1.376 bsd.port.mk
--- bsd.port.mk	2001/08/03 11:35:35	1.376
+++ bsd.port.mk	2001/08/08 14:15:55
@@ -843,7 +843,7 @@
 USE_XLIB=				yes
 .endif
 .if defined(USE_MESA)
-LIB_DEPENDS+=			GLU.1:${PORTSDIR}/graphics/Mesa3
+LIB_DEPENDS+=			glut.3:${PORTSDIR}/graphics/Mesa3
 .endif
 XAWVER=					7
 PKG_IGNORE_DEPENDS?=	'this_port_does_not_exist'
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->portmgr 
Responsible-Changed-By: lioux 
Responsible-Changed-When: Thu Aug 9 09:21:09 PDT 2001 
Responsible-Changed-Why:  
Over to maintainer 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29546 

From: FUJISHIMA Satsuki <sf@FreeBSD.org>
To: Pete Fritchman <petef@databits.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/29546: Fix USE_MESA in bsd.port.mk
Date: Fri, 31 Aug 2001 08:48:20 +0900

 portmgr:
 Please commit this now or fix this broken dependency in another way.
 
 -- 
 FUJISHIMA Satsuki
State-Changed-From-To: open->closed 
State-Changed-By: will 
State-Changed-When: Thu Aug 30 19:14:32 PDT 2001 
State-Changed-Why:  
Fixed, thanks. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29546 
>Unformatted:
