From ianjhart@freeloader.freeserve.co.uk  Sun Jul 29 08:26:42 2001
Return-Path: <ianjhart@freeloader.freeserve.co.uk>
Received: from pc1-cove4-0-cust214.bir.cable.ntl.com (pc1-cove4-0-cust214.bir.cable.ntl.com [213.105.93.214])
	by hub.freebsd.org (Postfix) with ESMTP id B2B4737B403
	for <freebsd-gnats-submit@freebsd.org>; Sun, 29 Jul 2001 08:26:41 -0700 (PDT)
	(envelope-from ianjhart@freeloader.freeserve.co.uk)
Received: from alpha.private (alpha.private [192.168.0.2])
	by pc1-cove4-0-cust214.bir.cable.ntl.com (8.11.3/8.11.3) with ESMTP id f6TFQeu03163
	for <freebsd-gnats-submit@freebsd.org>; Sun, 29 Jul 2001 16:26:40 +0100 (BST)
	(envelope-from ianjhart@alpha.private)
Received: (from root@localhost)
	by alpha.private (8.11.4/8.11.4) id f6TFGAW01211
	for freebsd-gnats-submit@freebsd.org; Sun, 29 Jul 2001 16:16:10 +0100 (BST)
	(envelope-from ianjhart)
Received: (from root@localhost)
	by alpha.private (8.11.4/8.11.4av) id f6TFG7N01201;
	Sun, 29 Jul 2001 16:16:07 +0100 (BST)
	(envelope-from ianjhart)
Message-Id: <200107291516.f6TFG7N01201@alpha.private>
Date: Sun, 29 Jul 2001 16:16:07 +0100 (BST)
From: ian j hart <ianjhart@freeloader.freeserve.co.uk>
Reply-To: ian j hart <ianjhart@freeloader.freeserve.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: p5-IMAP-Admin get_acl returns no data
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         29302
>Category:       ports
>Synopsis:       p5-IMAP-Admin get_acl returns no data
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tobez
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 29 08:30:01 PDT 2001
>Closed-Date:    Tue Aug 14 07:27:36 PDT 2001
>Last-Modified:  Tue Aug 14 07:27:54 PDT 2001
>Originator:     ian j hart
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD alpha.private 4.3-STABLE FreeBSD 4.3-STABLE #7: Tue Jul 24 21:34:59 BST 2001 ianjhart@alpha.private:/usr/obj/usr/src/sys/ALPHA i386


	
>Description:

	Calling get_acl results in "Use of uninitialised value" error.
>How-To-Repeat:

	Apply IO::Socket::INET patch as per pr29161

	#! /usr/bin/perl -w
	
	use IMAP::Admin;
	
	$imap = IMAP::Admin->new('Server' => 'localhost',
			'Login' => 'cyradm',
			'Password' => 'editmefirst',
			);
	
	$who = "user.testimapadmingetacl";
	
	$err = $imap->create($who);
	if($err != 0) {print "$imap->{'Error'}";}
	
	@acl = $imap->get_acl($who);
	
	print "$acl[0] $acl[1]\n";
		
	$err = $imap->set_acl($who, "cyradm", "lrswipcda");
	if($err != 0) {print "$imap->{'Error'}";}
	
	$imap->delete($who);
	if($err != 0) {print "$imap->{'Error'}";}
	
	$imap->close;

>Fix:

	De-obfuscate the code. Note this includes the aforementioned pr29161 patch
	
	*** Admin.pm.orig	Sun Jul 29 15:22:18 2001
	--- Admin.pm	Sun Jul 29 14:50:27 2001
	***************
	*** 6,12 ****
	  use Carp;
	  use IO::Select;
	  use IO::Socket;
	! use IO::Socket::INET;
	  use Text::ParseWords qw(parse_line);
	  use Cwd;
	  
	--- 6,12 ----
	  use Carp;
	  use IO::Select;
	  use IO::Socket;
	! #use IO::Socket::INET;
	  use Text::ParseWords qw(parse_line);
	  use Cwd;
	  
	***************
	*** 463,469 ****
	      print $fh qq{try GETACL "$mailbox"\n};
	      delete $self->{'acl'};
	      my $try = $self->_read;
	!     while ($try =~ /^\* ACL\s+(?:\".*?\"|.*?)\s+((\".*?\"|.*?)(?:\s)(?{ push @{$self->{'acl'}}, $2; }))+(\w+)(?{ push @{$self->{'acl'}}, $3; })$/) {
	  	$try = $self->_read;
	      }
	      if ($try =~ /^try OK/) {
	--- 463,471 ----
	      print $fh qq{try GETACL "$mailbox"\n};
	      delete $self->{'acl'};
	      my $try = $self->_read;
	!     while ($try =~ /^\* ACL\s+(?:\".*?\"|.*?)\s+((\".*?\"|.*?)(?:\s))+(\w+)$/) {
	! 	push (@{$self->{'acl'}}, $2);
	! 	push (@{$self->{'acl'}}, $3);
	  	$try = $self->_read;
	      }
	      if ($try =~ /^try OK/) {
	
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->tobez 
Responsible-Changed-By: tobez 
Responsible-Changed-When: Mon Jul 30 02:37:31 PDT 2001 
Responsible-Changed-Why:  
I'll take care of this. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29302 
State-Changed-From-To: open->closed 
State-Changed-By: tobez 
State-Changed-When: Tue Aug 14 07:27:36 PDT 2001 
State-Changed-Why:  
Committed, thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29302 
>Unformatted:
