From nobody@FreeBSD.org  Sat Jun 23 15:34:29 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8DBC837B408
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 23 Jun 2001 15:34:29 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f5NMYTt80308;
	Sat, 23 Jun 2001 15:34:29 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200106232234.f5NMYTt80308@freefall.freebsd.org>
Date: Sat, 23 Jun 2001 15:34:29 -0700 (PDT)
From: asimov <asimov@owirc.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: p5-Net-IRC-0.70_1  eats irc text with colons in them
X-Send-Pr-Version: www-1.0

>Number:         28378
>Category:       ports
>Synopsis:       p5-Net-IRC-0.70_1  eats irc text with colons in them
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    jedgar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 23 15:40:02 PDT 2001
>Closed-Date:    Fri Nov 22 11:12:15 PST 2002
>Last-Modified:  Fri Nov 22 11:12:15 PST 2002
>Originator:     asimov
>Release:        4.0
>Organization:
n/a
>Environment:
FreeBSD dragon.angrycandy.net 4.2-STABLE FreeBSD 4.2-STABLE #1: Wed Feb  7 23:54:25 MST 2001     schofiel@dragon.angrycandy.net:/archive/pubone/scratch/usr/src/sys/DRAGON  i386
>Description:
when doing:
	$conn->add_handler('public',	\&on_public);
any irc text with a : in it gets messed up, like..
"Asimov: boo" gets turned into ":Asimov"
"blah blah blah : boo" gets turned into ":boo"

>How-To-Repeat:
use p5-Net-IRC-0.70_1  to parse irc text with a ":" in it
>Fix:

>Release-Note:
>Audit-Trail:

From: "Asimov" <asimov@owirc.com>
To: <freebsd-gnats-submit@FreeBSD.org>, "Asimov" <asimov@owirc.com>
Cc:  
Subject: Re: ports/28378: p5-Net-IRC-0.70_1  eats irc text with colons in them
Date: Sat, 23 Jun 2001 19:18:38 -0400

 the problem seems to be on line 1101 in connection.pm
 
 ($from, $line) = $line =~ m/^(.*):(.*?)$/;
 
 should probably be
 
 ($from, $line) = $line =~ m/^(.*?):(.*)$/;
 
 and was introduced in the last patch that fixed ipv6 numeric address
 mismatching
 
 
 --
 asimov@efnet
 asimov@starlink
 
 

From: Jun Kuriyama <kuriyama@imgsrc.co.jp>
To: asimov <asimov@owirc.com>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: ports/28378: p5-Net-IRC-0.70_1  eats irc text with colons in them
Date: Tue, 26 Jun 2001 11:11:14 +0900

 Could you try new patch "patch-Connection.pm" attached below?
 
 
 --- Connection.pm.orig	Tue May 30 07:12:02 2000
 +++ Connection.pm	Wed Jun 13 17:01:06 2001
 @@ -1101,7 +1101,7 @@
  		 /x)                      # That ought to do it for now...
  	{
  	    $line = substr $line, 1 if $line =~ /^:/;
 -	    ($from, $line) = split ":", $line, 2;
 +	    ($from, $line) = $line =~ m/^(\S+\s.*?):(.*)$/;
  	    ($from, $type, @stuff) = split /\s+/, $from;
  	    $type = lc $type;
  	    
   	    
 
 -- 
 Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
              <kuriyama@FreeBSD.org> // FreeBSD Project

From: "Asimov" <asimov@owirc.com>
To: "Jun Kuriyama" <kuriyama@imgsrc.co.jp>
Cc: <freebsd-gnats-submit@FreeBSD.ORG>
Subject: Re: ports/28378: p5-Net-IRC-0.70_1  eats irc text with colons in them
Date: Tue, 26 Jun 2001 09:31:46 -0400

 ok, that seems to have solved the text parsing problem... but i'm still
 getting some odd warnings
 
 [  214] !WARN! PERL: Use of uninitialized value at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1105.
 [  215] !WARN! PERL: Use of uninitialized value at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1131.
 [  216] !WARN! PERL: Unknown event type:  at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC.pm line 150
 [  217] !WARN! PERL: Use of uninitialized value at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1257.
 [  218] !WARN! PERL: Funky parse case:
  at /usr/local/lib/perl5/site_perl/5.005/Net/IRC.pm line 150
 
 it seems to do it on channel join (only the initial join) and on the
 first line of text it sees, but it also does it at odd other times
 without the funky parse case.
 
 [  223] !WARN! PERL: Use of uninitialized value at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1105.
 [  224] !WARN! PERL: Use of uninitialized value at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1131.
 [  225] !WARN! PERL: Unknown event type:  at
 /usr/local/lib/perl5/site_perl/5.005/Net/IRC.pm line 150
 
 i've piddled and piddled with it and cant seem to get it narrowed down
 to a specific cause.... I hope its of some help at least
 
 
 ----- Original Message -----
 From: "Jun Kuriyama" <kuriyama@imgsrc.co.jp>
 To: "asimov" <asimov@owirc.com>
 Cc: <freebsd-gnats-submit@FreeBSD.ORG>
 Sent: Monday, June 25, 2001 10:11 PM
 Subject: Re: ports/28378: p5-Net-IRC-0.70_1 eats irc text with colons in
 them
 
 
 >
 > Could you try new patch "patch-Connection.pm" attached below?
 >
 >
 > --- Connection.pm.orig Tue May 30 07:12:02 2000
 > +++ Connection.pm Wed Jun 13 17:01:06 2001
 > @@ -1101,7 +1101,7 @@
 >   /x)                      # That ought to do it for now...
 >   {
 >       $line = substr $line, 1 if $line =~ /^:/;
 > -     ($from, $line) = split ":", $line, 2;
 > +     ($from, $line) = $line =~ m/^(\S+\s.*?):(.*)$/;
 >       ($from, $type, @stuff) = split /\s+/, $from;
 >       $type = lc $type;
 >
 >
 >
 > --
 > Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
 >              <kuriyama@FreeBSD.org> // FreeBSD Project
 

From: Jun Kuriyama <kuriyama@imgsrc.co.jp>
To: "Asimov" <asimov@owirc.com>
Cc: <freebsd-gnats-submit@FreeBSD.ORG>
Subject: Re: ports/28378: p5-Net-IRC-0.70_1  eats irc text with colons in them
Date: Tue, 26 Jun 2001 22:37:38 +0900

 At Tue, 26 Jun 2001 09:31:46 -0400,
 Asimov wrote:
 > ok, that seems to have solved the text parsing problem... but i'm still
 > getting some odd warnings
 > 
 > [  214] !WARN! PERL: Use of uninitialized value at
 > /usr/local/lib/perl5/site_perl/5.005/Net/IRC/Connection.pm line 1105.
 
 Could you test with new patch and show me message?
 
 
 --- Connection.pm.orig	Tue May 30 07:12:02 2000
 +++ Connection.pm	Tue Jun 26 22:36:10 2001
 @@ -1101,7 +1101,8 @@
  		 /x)                      # That ought to do it for now...
  	{
  	    $line = substr $line, 1 if $line =~ /^:/;
 -	    ($from, $line) = split ":", $line, 2;
 +	    ($from, $line) = $line =~ m/^(\S+\s.*?):(.*)$/;
 +print STDERR "kuriyama: $from\n";
  	    ($from, $type, @stuff) = split /\s+/, $from;
  	    $type = lc $type;
  	    
 
 -- 
 Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc.
              <kuriyama@FreeBSD.org> // FreeBSD Project
Responsible-Changed-From-To: freebsd-ports->jedgar 
Responsible-Changed-By: petef 
Responsible-Changed-When: Fri Nov 2 22:55:06 PST 2001 
Responsible-Changed-Why:  
Over to maintainer 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28378 

From: Chris Faulhaber <jedgar@fxp.org>
To: asimov <asimov@owirc.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/28378: p5-Net-IRC-0.70_1  eats irc text with colons in them
Date: Tue, 27 Nov 2001 09:39:38 -0500

 --6TrnltStXW4iwmi0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 I committed the patch from kuriyama (and updated the port to
 0.71).  Please follow-up if you still have problems.
 
 Thanks...
 
 --=20
 Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
 --------------------------------------------------------
 FreeBSD: The Power To Serve   -   http://www.FreeBSD.org
 
 --6TrnltStXW4iwmi0
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (FreeBSD)
 Comment: FreeBSD: The Power To Serve
 
 iEYEARECAAYFAjwDpaoACgkQObaG4P6BelDBmACdHDfUElabBjT5Q9JuUpJJ3GxQ
 EhoAnjthfxJ4U7mJWfjoGoXcoNch7gfr
 =reP1
 -----END PGP SIGNATURE-----
 
 --6TrnltStXW4iwmi0--
State-Changed-From-To: open->closed 
State-Changed-By: nork 
State-Changed-When: Fri Nov 22 11:10:43 PST 2002 
State-Changed-Why:  
It seems already committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=28378 
>Unformatted:
