From nobody@FreeBSD.org  Mon May 28 13:53:02 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id D6F8A37B423
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2001 13:53:01 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4SKr1T06968;
	Mon, 28 May 2001 13:53:01 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200105282053.f4SKr1T06968@freefall.freebsd.org>
Date: Mon, 28 May 2001 13:53:01 -0700 (PDT)
From: ats@first.gmd.de
To: freebsd-gnats-submit@FreeBSD.org
Subject: ports/java/linux-jdk14 misses a line 
X-Send-Pr-Version: www-1.0

>Number:         27718
>Category:       ports
>Synopsis:       ports/java/linux-jdk14 misses a line
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 28 14:00:07 PDT 2001
>Closed-Date:    Tue May 29 05:33:17 PDT 2001
>Last-Modified:  Tue May 29 05:33:51 PDT 2001
>Originator:     Andreas Schulz
>Release:        4.3-RELEASE
>Organization:
GMD-FIRST
>Environment:
FreeBSD freebsd.first.gmd.de 4.3-RELEASE FreeBSD 4.3-RELEASE #0: Thu May  3 20:2
8:30 CEST 2001     root@freebsd.first.gmd.de:/usr/src/sys/compile/FREEBSD  i386
>Description:
ports/java/linx-jdk14 the makefile tries to fetch the source file
from freebsd instead putting out the message how to get it. 
It misses the setting of the DISTFILES variable. This doesn't get
set for bsd.port.pre.mk. 
So the Makefile needs an additional line after EXTRACT_SUFX with
DISTFILES= ${DISTNAME}${EXTRACT_SUFX}
or something similar.
>How-To-Repeat:
Do a make checksum without the source and look at the output :-).
>Fix:
Fix see above in the full description.
>Release-Note:
>Audit-Trail:

From: Ernst de Haan <ernst@jollem.com>
To: ats@first.gmd.de
Cc: freebsd-gnats-submit@FreeBSD.ORG, sobomax@FreeBSD.ORG
Subject: Re: ports/27718: ports/java/linux-jdk14 misses a line
Date: Tue, 29 May 2001 00:44:40 +0200

 --IJpNTDwzlM2Ie8A6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Thanks Andreas,
 
 Here's a diff file that will fix this. I tested and indeed found that
 DISTFILES needs to be set in order for the IGNORE section to be activated.
 Will have to look into how this works, I assumed DISTFILES was already defined
 as ${DISTNAME}${EXTRACT_SUFX}.
 
 Anyway. Thanks again.
 
 This diff also makes sure that the JDK is *de*registered when it is installed.
 
 
 /Ernst
 
 
 ats@first.gmd.de wrote:
 > 
 > >Number:         27718
 > >Category:       ports
 > >Synopsis:       ports/java/linux-jdk14 misses a line
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-ports
 > >State:          closed
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Mon May 28 14:00:07 PDT 2001
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Andreas Schulz
 > >Release:        4.3-RELEASE
 > >Organization:
 > GMD-FIRST
 > >Environment:
 > FreeBSD freebsd.first.gmd.de 4.3-RELEASE FreeBSD 4.3-RELEASE #0: Thu May  3 20:2
 > 8:30 CEST 2001     root@freebsd.first.gmd.de:/usr/src/sys/compile/FREEBSD  i386
 > >Description:
 > ports/java/linx-jdk14 the makefile tries to fetch the source file
 > from freebsd instead putting out the message how to get it. 
 > It misses the setting of the DISTFILES variable. This doesn't get
 > set for bsd.port.pre.mk. 
 > So the Makefile needs an additional line after EXTRACT_SUFX with
 > DISTFILES= ${DISTNAME}${EXTRACT_SUFX}
 > or something similar.
 > >How-To-Repeat:
 > Do a make checksum without the source and look at the output :-).
 > >Fix:
 > Fix see above in the full description.
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-ports" in the body of the message
 > 
 
 -- 
 Ernst de Haan
 Java Architect
 Jollem Information Technology
 
     "Come to me all who are weary and burdened
         and I will give you rest" -- Jesus Christ
 
 --IJpNTDwzlM2Ie8A6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="linux-jdk14_port.diff"
 
 diff -ruN --exclude=CVS /usr/ports/java/linux-jdk14/Makefile /home/ernst/freebsd-ports/java/linux-jdk14/Makefile
 --- /usr/ports/java/linux-jdk14/Makefile	Fri May 25 20:59:23 2001
 +++ /home/ernst/freebsd-ports/java/linux-jdk14/Makefile	Tue May 29 00:39:29 2001
 @@ -10,8 +10,7 @@
  CATEGORIES=	java devel
  MASTER_SITES=	#
  PKGNAMEPREFIX=	linux-
 -DISTNAME=	j2sdk-${JDK_VERSION:S/./_/g}-linux-i386
 -EXTRACT_SUFX=	.bin
 +DISTFILES=	j2sdk-${JDK_VERSION:S/./_/g}-linux-i386.bin
  
  MAINTAINER=	ernst@jollem.com
  
 @@ -21,7 +20,7 @@
  RESTRICTED=	"Redistribution of repackaged binaries not permitted"
  
  .if defined(BATCH) || defined(PACKAGE_BUILDING)
 -IGNORE=		"You can not legally distribute binaries"
 +IGNORE="You can not legally distribute binaries"
  .endif
  
  EXTRACT_CMD=		# empty
 diff -ruN --exclude=CVS /usr/ports/java/linux-jdk14/pkg-plist /home/ernst/freebsd-ports/java/linux-jdk14/pkg-plist
 --- /usr/ports/java/linux-jdk14/pkg-plist	Fri May 25 20:59:24 2001
 +++ /home/ernst/freebsd-ports/java/linux-jdk14/pkg-plist	Mon May 28 10:46:33 2001
 @@ -1165,3 +1165,4 @@
  @dirrm %%TARGET_PREFIX%%/man/ja_JP.eucJP
  @dirrm %%TARGET_PREFIX%%/man
  @dirrm %%TARGET_PREFIX%%
 +@unexec %%LOCALBASE%%/bin/unregistervm "%D/%%TARGET_PREFIX%%/bin/java"
 
 --IJpNTDwzlM2Ie8A6--
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Tue May 29 05:33:17 PDT 2001 
State-Changed-Why:  
Problem fixed, thank you for submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=27718 
>Unformatted:
