From jeremy@indigo.external.org  Sun Dec 17 17:23:10 2000
Return-Path: <jeremy@indigo.external.org>
Received: from indigo.external.org (c1118643-b.chmpgn1.il.home.com [24.181.130.163])
	by hub.freebsd.org (Postfix) with ESMTP id CFF1437B400
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 17 Dec 2000 17:23:09 -0800 (PST)
Received: (from jeremy@localhost)
	by indigo.external.org (8.11.1/8.11.1) id eBI1NGf56753;
	Sun, 17 Dec 2000 19:23:16 -0600 (CST)
	(envelope-from jeremy)
Message-Id: <200012180123.eBI1NGf56753@indigo.external.org>
Date: Sun, 17 Dec 2000 19:23:16 -0600 (CST)
From: Jeremy Shaffner <jeremy@external.org>
Sender: jeremy@indigo.external.org
Reply-To: Jeremy Shaffner <jeremy@external.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Recursive distclean for bsd.port.mk w/patch
X-Send-Pr-Version: 3.2

>Number:         23602
>Category:       ports
>Synopsis:       Recursive distclean for bsd.port.mk w/patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 17 17:30:01 PST 2000
>Closed-Date:    Tue Sep 03 02:32:26 PDT 2002
>Last-Modified:  Tue Sep 03 02:32:26 PDT 2002
>Originator:     Jeremy Shaffner
>Release:        FreeBSD 4.2-20001106-BETA i386
>Organization:
>Environment:

$FreeBSD: ports/Mk/bsd.port.mk,v 1.360 2000/11/16 13:06:25 asami Exp $

	

>Description:

The distclean target does a recursive clean on dependancies and does a distclean
for the current port.  Defining NOCLEANDEPENDS avoids the recursion.

But there is no target or variable for distcleaning all dependancies.

I suggest:  (in audio/freeamp for example)

$ make distclean -DDISTCLEANDEPENDS
===>  Cleaning for bzip2-1.0.1
===>  Deleting distfiles for bzip2-1.0.1
===>  Cleaning for esound-0.2.22
===>  Deleting distfiles for esound-0.2.22
===>  Cleaning for id3lib-3.7.13
===>  Deleting distfiles for id3lib-3.7.13
===>  Cleaning for libaudiofile-0.1.9
===>  Deleting distfiles for libaudiofile-0.1.9
===>  Cleaning for musicbrainz-1.0.0.pre5
===>  Deleting distfiles for musicbrainz-1.0.0.pre5
===>  Cleaning for ORBit-0.5.5
===>  Deleting distfiles for ORBit-0.5.5
===>  Cleaning for gettext-0.10.35
===>  Deleting distfiles for gettext-0.10.35
===>  Cleaning for glib-1.2.8
===>  Deleting distfiles for glib-1.2.8
===>  Cleaning for gmake-3.79.1
===>  Deleting distfiles for gmake-3.79.1
===>  Cleaning for imake-4.0.1
===>  Deleting distfiles for imake-4.0.1
===>  Cleaning for libtool-1.3.4_1
===>  Deleting distfiles for libtool-1.3.4_1
===>  Cleaning for nasm-0.98
===>  Deleting distfiles for nasm-0.98
===>  Cleaning for popt-1.5
===>  Deleting distfiles for popt-1.5
===>  Cleaning for gdk-pixbuf-0.9.0
===>  Deleting distfiles for gdk-pixbuf-0.9.0
===>  Cleaning for imlib-1.9.8.1
===>  Deleting distfiles for imlib-1.9.8.1
===>  Cleaning for jpeg-6b
===>  Deleting distfiles for jpeg-6b
===>  Cleaning for libungif-4.1.0b1
===>  Deleting distfiles for libungif-4.1.0b1
===>  Cleaning for png-1.0.8_1
===>  Deleting distfiles for png-1.0.8_1
===>  Cleaning for tiff-3.5.5
===>  Deleting distfiles for tiff-3.5.5
===>  Cleaning for freetype-1.3.1
===>  Deleting distfiles for freetype-1.3.1
===>  Cleaning for gtk-1.2.8
===>  Deleting distfiles for gtk-1.2.8
===>  Cleaning for XFree86-libraries-4.0.1_2
===>  Deleting distfiles for XFree86-libraries-4.0.1_2
===>  Cleaning for gnomelibs-1.2.8_1
===>  Deleting distfiles for gnomelibs-1.2.8_1
===>  Cleaning for freeamp-2.1.rc4
===>  Deleting distfiles for freeamp-2.1.rc4

	

>How-To-Repeat:

Patch follows.
	

>Fix:

--- /usr/ports/Mk/bsd.port.mk.orig	Sun Dec 17 16:49:15 2000
+++ /usr/ports/Mk/bsd.port.mk	Sun Dec 17 18:53:22 2000
@@ -2604,9 +2604,15 @@
 
 .if !target(clean-depends)
 clean-depends:
-	@for dir in $$(${ALL-DEPENDS-LIST}); do \
-		(cd $$dir; ${MAKE} NOCLEANDEPENDS=yes clean); \
-	done
+	@if [ ! ${DISTCLEANDEPENDS} ]; then \
+		for dir in $$(${ALL-DEPENDS-LIST}); do \
+			(cd $$dir; ${MAKE} NOCLEANDEPENDS=yes clean); \
+		done; \
+	else \
+		for dir in $$(${ALL-DEPENDS-LIST}); do \
+			(cd $$dir; ${MAKE} NOCLEANDEPENDS=yes distclean); \
+		done; \
+	fi
 .endif
 
 .if !target(deinstall-depends)
	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->asami 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sun Dec 17 22:24:31 PST 2000 
Responsible-Changed-Why:  

Over to Mr. bsd.port.mk 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23602 
Responsible-Changed-From-To: asami->portmgr 
Responsible-Changed-By: will 
Responsible-Changed-When: Wed Apr 4 01:18:50 PDT 2001 
Responsible-Changed-Why:  
Over to new maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23602 
State-Changed-From-To: open->closed 
State-Changed-By: alane 
State-Changed-When: Tue Sep 3 02:30:57 PDT 2002 
State-Changed-Why:  
Old. No followups. Apparently nobody cared in all this time. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23602 
>Unformatted:
