From ajk@iu.edu  Thu Aug 24 08:37:33 2000
Return-Path: <ajk@iu.edu>
Received: from kobayashi.uits.iupui.edu (kobayashi.uits.iupui.edu [134.68.11.80])
	by hub.freebsd.org (Postfix) with ESMTP id 8F26437B424
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 Aug 2000 08:37:32 -0700 (PDT)
Received: (from ajk@localhost)
	by kobayashi.uits.iupui.edu (8.9.3/8.9.3) id KAA42372;
	Thu, 24 Aug 2000 10:37:21 -0500 (EST)
	(envelope-from ajk)
Message-Id: <200008241537.KAA42372@kobayashi.uits.iupui.edu>
Date: Thu, 24 Aug 2000 10:37:21 -0500 (EST)
From: ajk@iu.edu
Reply-To: ajk@iu.edu
To: FreeBSD-gnats-submit@freebsd.org
Cc: XFree86@XFree86.org
Subject: [PATCH] XDM PAM support should not require (SystemV4 || HasShadowPasswd)
X-Send-Pr-Version: 3.2

>Number:         20821
>Category:       ports
>Synopsis:       [PATCH] XDM PAM support should not require (SystemV4 || HasShadowPasswd)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 24 08:40:01 PDT 2000
>Closed-Date:    Sat Nov 25 20:17:12 PST 2000
>Last-Modified:  Sat Nov 25 20:18:03 PST 2000
>Originator:     Andrew J. Korty
>Release:        FreeBSD 4.1-RELEASE i386
>Organization:
Indiana University
>Environment:

XFree86-4 port

>Description:

The Imakefile for XDM configures PAM support inside an #if statement
such that  (SystemV4 || HasShadowPasswd) would have to be true for
PAM support to be enabled at all.

Also, the defualt Imake configuration does not indicate that FreeBSD
supports PAM.

Also, 

>How-To-Repeat:

Build the XFree86-4 port, and run ldd on the xdm binary.  The
absence of libpam.so shows that PAM support has not been compiled
in.

>Fix:

The following patch fixes the problem in the Imakefile, but does
not change the Imake configuration for FreeBSD to indicate that
PAM is supported.  The latter can be accomplished by adding

	#define HasPam YES

somewhere in /usr/X11R6/lib/X11/config/FreeBSD.cf.

--- programs/xdm/Imakefile.orig	Sat Jun 17 13:48:22 2000
+++ programs/xdm/Imakefile	Thu Aug 24 09:34:49 2000
@@ -68,16 +68,16 @@
 
 XPM_DEFINES = -DXPM 
 
+#if HasPam
+PAM_LIBRARIES = -lpam DlLibrary
+PAM_DEFINES = -DUSE_PAM
+#endif
+
 #if SystemV4 || HasShadowPasswd
 #if !LinuxShadowSuite
 PWD_DEFINES = -DUSESHADOW
 #else
 PWD_DEFINES = -DUSESHADOW -DSHADOWSUITE
-#endif
-
-#if HasPam
-PAM_LIBRARIES = -lpam DlLibrary
-PAM_DEFINES = -DUSE_PAM
 #endif
 
 #if !defined(i386IscArchitecture) && !defined(i386ScoArchitecture) && !defined(LinuxArchitecture) && !defined(NTOArchitecture) && !defined(SGIArchitecture)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->jmz 
Responsible-Changed-By: dirk 
Responsible-Changed-When: Sat Aug 26 14:49:07 PDT 2000 
Responsible-Changed-Why:  
Over to Mr. Maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20821 
State-Changed-From-To: open->closed 
State-Changed-By: jmz 
State-Changed-When: Sat Nov 25 20:17:12 PST 2000 
State-Changed-Why:  
This problem has been fixed in PORTREVISION = 8 


http://www.freebsd.org/cgi/query-pr.cgi?pr=20821 
>Unformatted:
