From roam@orbitel.bg  Sat Aug 19 08:55:09 2000
Return-Path: <roam@orbitel.bg>
Received: from sentinel.office1.bg (sentinel.office1.bg [195.24.48.182])
	by hub.freebsd.org (Postfix) with SMTP id E319A37B43C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Aug 2000 08:55:06 -0700 (PDT)
Received: (qmail 52440 invoked by uid 1001); 19 Aug 2000 15:48:56 -0000
Message-Id: <20000819154856.52439.qmail@ringwraith.office1>
Date: 19 Aug 2000 15:48:56 -0000
From: Peter Pentchev <roam@orbitel.bg>
Reply-To: Peter Pentchev <roam@orbitel.bg>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] update port: mail/fetchmail to 5.5.0
X-Send-Pr-Version: 3.2

>Number:         20716
>Category:       ports
>Synopsis:       [PATCH] update port: mail/fetchmail to 5.5.0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 19 09:00:04 PDT 2000
>Closed-Date:    Mon Sep 4 17:42:23 PDT 2000
>Last-Modified:  Mon Sep 04 17:42:36 PDT 2000
>Originator:     Peter Pentchev <roam@orbitel.bg>
>Release:        FreeBSD 4.1-STABLE i386
>Organization:
Orbitel JSCo
>Environment:

current ports tree

>Description:

update fetchmail port from 5.4.4 to 5.5.0, fix a minor 5.5.0 bug
in the meantime (pop3.c, bad migration to DOTLINE macro).

>How-To-Repeat:

N/A

>Fix:

diff -urN ports/mail/fetchmail/Makefile myports/mail/fetchmail/Makefile
--- ports/mail/fetchmail/Makefile	Wed Aug  9 18:09:27 2000
+++ myports/mail/fetchmail/Makefile	Sat Aug 19 18:02:56 2000
@@ -10,7 +10,7 @@
 # want fetchmailconf to work, define WITH_X11
 
 PORTNAME=	fetchmail
-PORTVERSION= 	5.4.4
+PORTVERSION= 	5.5.0
 CATEGORIES=	mail ipv6
 MASTER_SITES=	ftp://ftp.ccil.org/pub/esr/fetchmail/
 
diff -urN ports/mail/fetchmail/files/md5 myports/mail/fetchmail/files/md5
--- ports/mail/fetchmail/files/md5	Wed Aug  9 18:09:27 2000
+++ myports/mail/fetchmail/files/md5	Sat Aug 19 18:05:25 2000
@@ -1 +1 @@
-MD5 (fetchmail-5.4.4.tar.gz) = 92e45cba6e248588278d53cecb1da7a3
+MD5 (fetchmail-5.5.0.tar.gz) = 40ce23412285a82b74b1ad24e2e4c2c2
diff -urN ports/mail/fetchmail/patches/patch-an myports/mail/fetchmail/patches/patch-an
--- ports/mail/fetchmail/patches/patch-an	Thu Jan  1 02:00:00 1970
+++ myports/mail/fetchmail/patches/patch-an	Sat Aug 19 18:31:03 2000
@@ -0,0 +1,11 @@
+--- pop3.c.orig	Sat Aug 19 18:30:49 2000
++++ pop3.c	Sat Aug 19 18:28:53 2000
+@@ -157,7 +157,7 @@
+ 
+ 		while ((ok = gen_recv(sock, buffer, sizeof(buffer))) == 0)
+ 		{
+-		    if (DOTLINE([0]))
++		    if (DOTLINE(buffer))
+ 			break;
+ 		    if (strncasecmp(buffer, "rpa", 3) == 0)
+ 			has_rpa = TRUE;

>Release-Note:
>Audit-Trail:

From: Maxim Sobolev <sobomax@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, roam@orbitel.bg, ve@sci.fi
Cc:  
Subject: Re: ports/20716: [PATCH] update port: mail/fetchmail to 5.5.0
Date: Mon, 04 Sep 2000 17:02:27 +0300

 What the MAINTAINER think about that?
 
 -Maxim
 
 

From: Peter Pentchev <roam@orbitel.bg>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, ve@sci.fi
Subject: Re: ports/20716: [PATCH] update port: mail/fetchmail to 5.5.0
Date: Mon, 4 Sep 2000 17:10:02 +0300

 Well yeah, I thought of contacting the maintainter too, a day or two
 after submitting the PR :\  No answer so far.. maybe this thread will
 elicit some reply? :)
 
 On Mon, Sep 04, 2000 at 05:02:27PM +0300, Maxim Sobolev wrote:
 > What the MAINTAINER think about that?
 
 G'luck,
 Peter
 
 -- 
 This sentence contains exactly threee erors.
 

From: Ville Eerola <Ville.Eerola@vehome.pp.sci.fi>
To: Peter Pentchev <roam@orbitel.bg>
Cc: Maxim Sobolev <sobomax@FreeBSD.org>,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/20716: [PATCH] update port: mail/fetchmail to 5.5.0
Date: Tue, 5 Sep 2000 01:39:17 +0300 (EEST)

 Peter Pentchev writes:
 > Well yeah, I thought of contacting the maintainter too, a day or two
 > after submitting the PR :\  No answer so far.. maybe this thread will
 > elicit some reply? :)
 > 
 > On Mon, Sep 04, 2000 at 05:02:27PM +0300, Maxim Sobolev wrote:
 > > What the MAINTAINER think about that?
 
 Hmmm... I seem to have missed the PR. However, I checked the fetchmail
 www-site, ad it appears that there is already a new version available
 (5.5.1), which fixes the problem that you fixed in a new patch. I
 would prefer the port to be upgraded to 5.5.1 in order to avoid extra
 patch files in the FreeBSD ports repository...
 
 Could you try the newer version and see if it works for you without
 the new patch? It should be a simple matter of new checksum and
 distfile name change in the Makefile.
 
 
 Regards, Ville
 
 -- 
 Ville Eerola                       |  Powered by
 ve@sci.fi                          |             FreeBSD
 

From: Peter Pentchev <roam@orbitel.bg>
To: Ville Eerola <Ville.Eerola@vehome.pp.sci.fi>
Cc: Maxim Sobolev <sobomax@FreeBSD.org>,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/20716: [PATCH] update port: mail/fetchmail to 5.5.0
Date: Tue, 5 Sep 2000 03:27:10 +0300

 On Tue, Sep 05, 2000 at 01:39:17AM +0300, Ville Eerola wrote:
 > 
 > Hmmm... I seem to have missed the PR. However, I checked the fetchmail
 > www-site, ad it appears that there is already a new version available
 > (5.5.1), which fixes the problem that you fixed in a new patch. I
 > would prefer the port to be upgraded to 5.5.1 in order to avoid extra
 > patch files in the FreeBSD ports repository...
 > 
 > Could you try the newer version and see if it works for you without
 > the new patch? It should be a simple matter of new checksum and
 > distfile name change in the Makefile.
 
 Yup, you're correct :) 5.5.1 is out, and the only code change is exactly
 this bugfix - all the other changes are in the language files.
 
 Attached is a trivial checksum-and-distfile Makefile patch :)
 
 Normally I'd be reluctant to recommend (and even to trust..) a non-gold
 fetchmail release - I have been bitten by fetchmail instabilities in the past -
 but seeing as the only change is really this bugfix, it seems safe to skip
 a gold version in this case :)
 
 G'luck,
 Peter
 
 -- 
 This sentence contains exactly threee erors.
 
 diff -urN ports/mail/fetchmail/Makefile myports/mail/fetchmail/Makefile
 --- ports/mail/fetchmail/Makefile	Wed Aug  9 18:09:27 2000
 +++ myports/mail/fetchmail/Makefile	Tue Sep  5 03:21:52 2000
 @@ -10,7 +10,7 @@
  # want fetchmailconf to work, define WITH_X11
  
  PORTNAME=	fetchmail
 -PORTVERSION= 	5.4.4
 +PORTVERSION= 	5.5.1
  CATEGORIES=	mail ipv6
  MASTER_SITES=	ftp://ftp.ccil.org/pub/esr/fetchmail/
  
 diff -urN ports/mail/fetchmail/files/md5 myports/mail/fetchmail/files/md5
 --- ports/mail/fetchmail/files/md5	Wed Aug  9 18:09:27 2000
 +++ myports/mail/fetchmail/files/md5	Tue Sep  5 03:24:10 2000
 @@ -1 +1 @@
 -MD5 (fetchmail-5.4.4.tar.gz) = 92e45cba6e248588278d53cecb1da7a3
 +MD5 (fetchmail-5.5.1.tar.gz) = 4f1124bcb616b9ec2724bef93e9cfea2
 

From: Ville Eerola <Ville.Eerola@vehome.pp.sci.fi>
To: Peter Pentchev <roam@orbitel.bg>
Cc: Maxim Sobolev <sobomax@FreeBSD.org>,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/20716: [PATCH] update port: mail/fetchmail to 5.5.0
Date: Tue, 5 Sep 2000 03:37:34 +0300 (EEST)

 Peter Pentchev writes:
 > Yup, you're correct :) 5.5.1 is out, and the only code change is exactly
 > this bugfix - all the other changes are in the language files.
 > 
 > Attached is a trivial checksum-and-distfile Makefile patch :)
 
 Now, it looks a lot better ;-) Just like so many other fetchmail
 upgrades... 
 
  
 > Normally I'd be reluctant to recommend (and even to trust..) a
 > non-gold fetchmail release - I have been bitten by fetchmail
 > instabilities in the past - but seeing as the only change is really
 > this bugfix, it seems safe to skip a gold version in this case :)
 
 Right. Now, we just need to get someone to commit this update. :-)
 
 
 Regards, Ville
 
 -- 
 Ville Eerola                       |  Powered by
 ve@sci.fi                          |             FreeBSD
 
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Mon Sep 4 17:42:23 PDT 2000 
State-Changed-Why:  
Update committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20716 
>Unformatted:
