From lioux@uol.com.br  Tue Jun  6 08:57:48 2000
Return-Path: <lioux@uol.com.br>
Received: from 200-191-152-242-as.acessonet.com.br (200-191-152-242-as.acessonet.com.br [200.191.152.242])
	by hub.freebsd.org (Postfix) with ESMTP id C930B37B950
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Jun 2000 08:57:43 -0700 (PDT)
	(envelope-from lioux@uol.com.br)
Received: (qmail 11069 invoked by uid 1001); 6 Jun 2000 15:55:08 -0000
Message-Id: <20000606155508.11068.qmail@Fedaykin.here>
Date: 6 Jun 2000 15:55:08 -0000
From: lioux@uol.com.br
Reply-To: lioux@uol.com.br
To: FreeBSD-gnats-submit@freebsd.org
Subject: Update graphics/gd to handbook compliance
X-Send-Pr-Version: 3.2

>Number:         19060
>Category:       ports
>Synopsis:       Update graphics/gd to handbook compliance
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 06 09:00:01 PDT 2000
>Closed-Date:    Tue Jun 6 09:03:21 PDT 2000
>Last-Modified:  Tue Jun  6 10:40:03 PDT 2000
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
>Environment:

FreeBSD Here.here 4.0-STABLE FreeBSD 4.0-STABLE #17: Wed May 24 19:49:37 EST 2000     root@:/usr/src/sys/compile/LIOUX  i386

>Description:

Updated graphics/gd to comply with Porter's Handbook shared
libraries guidelines. Shared library created by the port
should start with .1

>How-To-Repeat:

n/a

>Fix:

diff -ruN gd.ORIG/patches/patch-ac gd/patches/patch-ac
--- gd.ORIG/patches/patch-ac	Sun May 21 04:51:47 2000
+++ gd/patches/patch-ac	Tue Jun  6 12:47:25 2000
@@ -81,7 +81,7 @@
 +.c.so:
 +	${CC} -fpic -DPIC ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET}
 +
-+all: libgd.a libgd.so.0 $(PROGRAMS)
++all: libgd.a libgd.so.1 $(PROGRAMS)
  
  install: libgd.a $(BIN_PROGRAMS)
 -	sh ./install-item 644 libgd.a $(INSTALL_LIB)/libgd.a
@@ -103,8 +103,8 @@
 -	sh ./install-item 644 gdfontt.h $(INSTALL_INCLUDE)/gdfontt.h
 +	$(INSTALL) -c -m 644 libgd.a $(INSTALL_LIB)/libgd.a
 +	$(INSTALL) -c -m 755 pngtogd $(INSTALL_BIN)/pngtogd
-+	$(INSTALL) -c -m 755 libgd.so.0 $(INSTALL_LIB)/libgd.so.0
-+	ln -sf libgd.so.0 $(INSTALL_LIB)/libgd.so
++	$(INSTALL) -c -m 755 libgd.so.1 $(INSTALL_LIB)/libgd.so.1
++	ln -sf libgd.so.1 $(INSTALL_LIB)/libgd.so
 +	$(INSTALL) -c -m 755 pngtogd2 $(INSTALL_BIN)/pngtogd2
 +	$(INSTALL) -c -m 755 gdtopng $(INSTALL_BIN)/gdtopng
 +	$(INSTALL) -c -m 755 gd2topng $(INSTALL_BIN)/gd2topng
@@ -140,7 +140,7 @@
 +	$(AR) rc libgd.a $(OBJS)
  	-ranlib libgd.a
 +
-+libgd.so.0:   $(INCS) $(OBJS:S/o$/so/g)
-+	$(CC) -shared -Wl,-x -Wl,-assert -Wl,pure-text -Wl,-soname,$@ -o $@ $(OBJS:S/o$/so/g) $(LIBDIRS) $(LIBS)
-+	ln -sf libgd.so.0 libgd.so
++libgd.so.1:   $(INCS) $(OBJS:.o=.so)
++	$(CC) -shared -Wl,-x -Wl,-assert -Wl,pure-text -Wl,-soname,$@ -o $@ $(OBJS:.o=.so) $(LIBDIRS) $(LIBS)
++	ln -sf libgd.so.1 libgd.so
  
diff -ruN gd.ORIG/pkg/PLIST gd/pkg/PLIST
--- gd.ORIG/pkg/PLIST	Mon Jan 17 23:50:51 2000
+++ gd/pkg/PLIST	Tue Jun  6 12:51:27 2000
@@ -16,7 +16,7 @@
 include/gd/gdfontt.h
 lib/libgd.a
 lib/libgd.so
-lib/libgd.so.0
-@exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m %B
-@unexec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -R
+lib/libgd.so.1
 @dirrm include/gd
+@exec /sbin/ldconfig -m %B
+@unexec /sbin/ldconfig -R

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: will 
State-Changed-When: Tue Jun 6 09:03:21 PDT 2000 
State-Changed-Why:  
Committed, thanks!  I will take care of LIB_DEPENDS shortly. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19060 

From: Ade Lovett <ade@FreeBSD.org>
To: lioux@uol.com.br
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/19060: Update graphics/gd to handbook compliance
Date: Tue, 6 Jun 2000 11:44:07 -0500

 On Tue, Jun 06, 2000 at 03:55:08PM -0000, lioux@uol.com.br wrote:
 > Updated graphics/gd to comply with Porter's Handbook shared
 > libraries guidelines. Shared library created by the port
 > should start with .1
 
 What about patches for all those other ports that LIB_DEPENDS
 on graphics/gd ??  You can't just randomly change shared library
 numbers and expect everything to "just work".
 
 -aDe
 
 -- 
 Ade Lovett, Austin, TX.			ade@FreeBSD.org
 FreeBSD: The Power to Serve		http://www.FreeBSD.org/
 
>Unformatted:
