From nobody@FreeBSD.org  Thu May 22 15:00:00 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id E9AFEEB5
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 May 2014 15:00:00 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id D79292A45
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 May 2014 15:00:00 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s4MF008Q053406
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 May 2014 15:00:00 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s4MF002u053404;
	Thu, 22 May 2014 15:00:00 GMT
	(envelope-from nobody)
Message-Id: <201405221500.s4MF002u053404@cgiserv.freebsd.org>
Date: Thu, 22 May 2014 15:00:00 GMT
From: Joseph Benden <joe@thrallingpenguin.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Add staging support to www/gallery3
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: appleboy.tw@gmail.com

>Number:         190113
>Category:       ports
>Synopsis:       [patch] Add staging support to www/gallery3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 22 15:10:01 UTC 2014
>Closed-Date:    Sun May 25 05:31:12 UTC 2014
>Last-Modified:  Sun May 25 05:40:01 UTC 2014
>Originator:     Joseph Benden
>Release:        FreeBSD 11
>Organization:
>Environment:
FreeBSD lucy 11.0-CURRENT FreeBSD 11.0-CURRENT #4 r264887: Thu Apr 24 12:43:46 MST 2014     root@lucy:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Adds staging support to www/gallery3.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff --git a/www/gallery3/Makefile b/www/gallery3/Makefile
index 7f3da51..9d992a9 100644
--- a/www/gallery3/Makefile
+++ b/www/gallery3/Makefile
@@ -25,7 +25,6 @@ OPTIONS_DEFINE=	DCRAW FFMPEG GD GRAPHMAGICK IMAGEMAGICK JHEAD \
 		NETPBM NLS UNZIP
 OPTIONS_DEFAULT=	IMAGEMAGICK JHEAD UNZIP
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if defined(GALLERY3DIR)
@@ -76,8 +75,8 @@ RUN_DEPENDS+=	unzip:${PORTSDIR}/archivers/unzip
 .endif
 
 do-install:
-	@cd ${WRKSRC}/ && ${COPYTREE_SHARE} . ${WWWDIR}/
-	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}/
+	@cd ${WRKSRC}/ && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}/
+	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/
 	@${ECHO_CMD} '@exec ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}' >> ${TMPPLIST}
 
 .if !defined(BATCH)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 22 15:10:05 UTC 2014 
Responsible-Changed-Why:  
swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=190113 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu May 22 15:10:07 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=190113 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: appleboy.tw@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/190113: [patch] Add staging support to www/gallery3
Date: Thu, 22 May 2014 15:10:06 UT

 Maintainer of www/gallery3,
 
 Please note that PR ports/190113 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/190113
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Bo-Yi Wu <appleboy.tw@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/190113: [patch] Add staging support to www/gallery3
Date: Thu, 22 May 2014 23:48:52 +0800

 --089e012292f8e7f3fe04f9ff0d3d
 Content-Type: text/plain; charset=UTF-8
 
 Please commit it.
 
 Thanks.
 
 --
 About me: http://about.me/appleboy
 
 
 On Thu, May 22, 2014 at 11:10 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of www/gallery3,
 >
 > Please note that PR ports/190113 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/190113
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 --089e012292f8e7f3fe04f9ff0d3d
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 <div dir=3D"ltr">Please commit it.<div><br></div><div>Thanks.</div></div><d=
 iv class=3D"gmail_extra"><br clear=3D"all"><div><div>--</div>About me: <a h=
 ref=3D"http://about.me/appleboy" target=3D"_blank">http://about.me/appleboy=
 </a><br>
 
 </div>
 <br><br><div class=3D"gmail_quote">On Thu, May 22, 2014 at 11:10 PM, Edwin =
 Groothuis <span dir=3D"ltr">&lt;<a href=3D"mailto:edwin@freebsd.org" target=
 =3D"_blank">edwin@freebsd.org</a>&gt;</span> wrote:<br><blockquote class=3D=
 "gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
 -left:1ex">
 
 Maintainer of www/gallery3,<br>
 <br>
 Please note that PR ports/190113 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
 =C2=A0 =C2=A0 <a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports=
 /190113" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dpor=
 ts/190113</a><br>
 <span class=3D"HOEnZb"><font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></span></blockquote></div><br></div>
 
 --089e012292f8e7f3fe04f9ff0d3d--
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Sun May 25 05:31:12 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=190113 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/190113: commit references a PR
Date: Sun, 25 May 2014 05:30:26 +0000 (UTC)

 Author: miwi
 Date: Sun May 25 05:30:22 2014
 New Revision: 355127
 URL: http://svnweb.freebsd.org/changeset/ports/355127
 QAT: https://qat.redports.org/buildarchive/r355127/
 
 Log:
   - Stage support
   
   PR:		190113
   Submitted by:	Joseph Benden <joe@thrallingpenguin.com>
   Approved by:	maintainer
 
 Modified:
   head/www/gallery3/Makefile
 
 Modified: head/www/gallery3/Makefile
 ==============================================================================
 --- head/www/gallery3/Makefile	Sun May 25 05:29:24 2014	(r355126)
 +++ head/www/gallery3/Makefile	Sun May 25 05:30:22 2014	(r355127)
 @@ -25,7 +25,6 @@ OPTIONS_DEFINE=	DCRAW FFMPEG GD GRAPHMAG
  		NETPBM NLS UNZIP
  OPTIONS_DEFAULT=	IMAGEMAGICK JHEAD UNZIP
  
 -NO_STAGE=	yes
  .include <bsd.port.options.mk>
  
  .if defined(GALLERY3DIR)
 @@ -76,8 +75,8 @@ RUN_DEPENDS+=	unzip:${PORTSDIR}/archiver
  .endif
  
  do-install:
 -	@cd ${WRKSRC}/ && ${COPYTREE_SHARE} . ${WWWDIR}/
 -	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}/
 +	@cd ${WRKSRC}/ && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}/
 +	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/
  	@${ECHO_CMD} '@exec ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}' >> ${TMPPLIST}
  
  .if !defined(BATCH)
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
