From kubito@gmail.com  Thu May  8 22:15:22 2014
Return-Path: <kubito@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id D8B67305;
	Thu,  8 May 2014 22:15:22 +0000 (UTC)
Received: from mail-lb0-x235.google.com (mail-lb0-x235.google.com [IPv6:2a00:1450:4010:c04::235])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 35FB4B74;
	Thu,  8 May 2014 22:15:22 +0000 (UTC)
Received: by mail-lb0-f181.google.com with SMTP id u14so4464035lbd.26
        for <multiple recipients>; Thu, 08 May 2014 15:15:19 -0700 (PDT)
Received: from localhost (a91-154-115-217.elisa-laajakaista.fi. [91.154.115.217])
        by mx.google.com with ESMTPSA id wm10sm2313100lbb.29.2014.05.08.15.15.16
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Thu, 08 May 2014 15:15:16 -0700 (PDT)
Message-Id: <536c01f4.8a9d700a.0996.48cf@mx.google.com>
Date: Thu, 08 May 2014 15:15:16 -0700 (PDT)
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Sender: Raphael Kubo da Costa <kubito@gmail.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: sunpoet@FreeBSD.org
Subject: [PATCH] astro/cfitsio: Actually make -lz be passed to the linker.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         189487
>Category:       ports
>Synopsis:       [PATCH] astro/cfitsio: Actually make -lz be passed to the linker.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 08 22:20:01 UTC 2014
>Closed-Date:    Fri May 09 15:26:19 UTC 2014
>Last-Modified:  Fri May  9 15:30:00 UTC 2014
>Originator:     Raphael Kubo da Costa
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD orwell 11.0-CURRENT FreeBSD 11.0-CURRENT #9 r264665: Fri Apr 18 23:19:11 EEST
>Description:
The way the port's build system is set up, changing LDFLAGS does not have any effect. Instead, one should specify additional libraries at configure-time by setting LIBS, which is then passed to the linker at build time and is also used in the port's .pc file.

This should unbreak astro/wcslib when this port is installed, as it the detection is currently failing because of missing zlib symbols in the test programs built at configure-time.

Port maintainer (sunpoet@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- cfitsio-3.360.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 353360)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	cfitsio
 PORTVERSION=	3.360
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	astro
 MASTER_SITES=	http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/ \
 		http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/oldvers/ \
@@ -23,10 +23,10 @@
 
 ALL_TARGET=	libcfitsio.a shared
 CFLAGS+=	-I${INCLUDEDIR}
+CONFIGURE_ENV+=	LIBS="-L${LIBDIR} -lz"
 CONFIGURE_ARGS=	ac_cv_prog_FC=f2c
 GNU_CONFIGURE=	yes
 MAKE_ARGS=	ZLIB_SOURCES="zlib/zcompress.c zlib/zuncompress.c"
-LDFLAGS+=	-L${LIBDIR} -lz
 USE_LDCONFIG=	yes
 USES=		pkgconfig
 WRKSRC=		${WRKDIR}/${PORTNAME}
--- cfitsio-3.360.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 8 22:20:09 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189487 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Fri May 9 15:26:19 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189487 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/189487: commit references a PR
Date: Fri,  9 May 2014 15:26:10 +0000 (UTC)

 Author: sunpoet
 Date: Fri May  9 15:26:05 2014
 New Revision: 353466
 URL: http://svnweb.freebsd.org/changeset/ports/353466
 QAT: https://qat.redports.org/buildarchive/r353466/
 
 Log:
   - Pass -lz to libdata/pkgconfig/cfitsio.pc
   - Bump PORTREVISION for package change
   
   PR:		ports/189487
   Submitted by:	rakuco
 
 Modified:
   head/astro/cfitsio/Makefile
 
 Modified: head/astro/cfitsio/Makefile
 ==============================================================================
 --- head/astro/cfitsio/Makefile	Fri May  9 15:23:12 2014	(r353465)
 +++ head/astro/cfitsio/Makefile	Fri May  9 15:26:05 2014	(r353466)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	cfitsio
  PORTVERSION=	3.360
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	astro
  MASTER_SITES=	http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/ \
  		http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/oldvers/ \
 @@ -24,9 +24,9 @@ OPTIONS_DEFINE=	DOCS
  ALL_TARGET=	libcfitsio.a shared
  CFLAGS+=	-I${INCLUDEDIR}
  CONFIGURE_ARGS=	ac_cv_prog_FC=f2c
 +CONFIGURE_ENV=	LIBS="-L${LIBDIR} -lz"
  GNU_CONFIGURE=	yes
  MAKE_ARGS=	ZLIB_SOURCES="zlib/zcompress.c zlib/zuncompress.c"
 -LDFLAGS+=	-L${LIBDIR} -lz
  USE_LDCONFIG=	yes
  USES=		pkgconfig
  WRKSRC=		${WRKDIR}/${PORTNAME}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
